-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 13 pull requests #120743
Rollup of 13 pull requests #120743
Commits on Jan 16, 2024
-
Add unstable
-Z direct-access-external-data
cmdline flag forrustc
The new flag has been described in the Major Change Proposal at rust-lang/compiler-team#707
Configuration menu - View commit details
-
Copy full SHA for 06a4168 - Browse repository at this point
Copy the full SHA 06a4168View commit details
Commits on Jan 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f38489e - Browse repository at this point
Copy the full SHA f38489eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1edc9d - Browse repository at this point
Copy the full SHA d1edc9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1031598 - Browse repository at this point
Copy the full SHA 1031598View commit details
Commits on Jan 29, 2024
-
interning doesn't check alignment anymroe, because it doesn't do any …
…more projections.
Configuration menu - View commit details
-
Copy full SHA for 7a2b663 - Browse repository at this point
Copy the full SHA 7a2b663View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6d0225 - Browse repository at this point
Copy the full SHA b6d0225View commit details -
Configuration menu - View commit details
-
Copy full SHA for a73c448 - Browse repository at this point
Copy the full SHA a73c448View commit details -
Configuration menu - View commit details
-
Copy full SHA for a57a00e - Browse repository at this point
Copy the full SHA a57a00eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d46b98 - Browse repository at this point
Copy the full SHA 5d46b98View commit details
Commits on Feb 1, 2024
-
coverage: Split out counter increment sites from BCB node/edge counters
This makes it possible for two nodes/edges in the coverage graph to share the same counter, without causing the instrumentor to inject unwanted duplicate counter-increment statements.
Configuration menu - View commit details
-
Copy full SHA for 2e212b7 - Browse repository at this point
Copy the full SHA 2e212b7View commit details
Commits on Feb 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bae4f17 - Browse repository at this point
Copy the full SHA bae4f17View commit details
Commits on Feb 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d622195 - Browse repository at this point
Copy the full SHA d622195View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9aff42e - Browse repository at this point
Copy the full SHA 9aff42eView commit details -
Clarify order of operations during interning
Co-authored-by: Ralf Jung <post@ralfj.de>
Configuration menu - View commit details
-
Copy full SHA for c94769a - Browse repository at this point
Copy the full SHA c94769aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 411967c - Browse repository at this point
Copy the full SHA 411967cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cac1c4 - Browse repository at this point
Copy the full SHA 6cac1c4View commit details
Commits on Feb 6, 2024
-
Suggest turnging
if let
into irrefutablelet
if appropriateWhen encountering an `if let` tail expression without an `else` arm for an enum with a single variant, suggest writing an irrefutable `let` binding instead. ``` error[E0317]: `if` may be missing an `else` clause --> $DIR/irrefutable-if-let-without-else.rs:8:5 | LL | fn foo(x: Enum) -> i32 { | --- expected `i32` because of this return type LL | / if let Enum::Variant(value) = x { LL | | value LL | | } | |_____^ expected `i32`, found `()` | = note: `if` expressions without `else` evaluate to `()` = help: consider adding an `else` block that evaluates to the expected type help: consider using an irrefutable `let` binding instead | LL ~ let Enum::Variant(value) = x; LL ~ value | ``` Fix rust-lang#61788.
Configuration menu - View commit details
-
Copy full SHA for a939bad - Browse repository at this point
Copy the full SHA a939badView commit details -
Mark "unused binding" suggestion as maybe incorrect
Ignoring unused bindings should be a determination made by a human, `rustfix` shouldn't auto-apply the suggested change. Fix rust-lang#54196.
Configuration menu - View commit details
-
Copy full SHA for aef18c9 - Browse repository at this point
Copy the full SHA aef18c9View commit details -
Remove return value from
emit_stashed_diagnostics
.It's never used.
Configuration menu - View commit details
-
Copy full SHA for 8d1c20a - Browse repository at this point
Copy the full SHA 8d1c20aView commit details -
fix
llvm_out
to use the correct LLVM rootWhen `download-ci-llvm` is enabled, `llvm_out` ends up with the error below due to an incorrect path on cross-compilations. This change fixes that. ``` failed to execute command: "/rust/build/x86_64-unknown-linux-gnu/llvm/build/bin/llvm-config" "--version" ERROR: No such file or directory (os error 2) ``` Signed-off-by: onur-ozkan <work@onurozkan.dev>
Configuration menu - View commit details
-
Copy full SHA for 7fb4512 - Browse repository at this point
Copy the full SHA 7fb4512View commit details
Commits on Feb 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 14dda5f - Browse repository at this point
Copy the full SHA 14dda5fView commit details -
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Configuration menu - View commit details
-
Copy full SHA for 63cc3c7 - Browse repository at this point
Copy the full SHA 63cc3c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a59d006 - Browse repository at this point
Copy the full SHA a59d006View commit details -
Remove an
unchecked_claim_error_was_emitted
call.When `catch_fatal_errors` catches a `FatalErrorMarker`, it returns an `ErrorGuaranteed` that is conjured out of thin air with `unchecked_claim_error_was_emitted`. But that `ErrorGuaranteed` is never used. This commit changes it to instead conjure a `FatalError` out of thin air. (A non-deprecated action!) This makes more sense because `FatalError` and `FatalErrorMarker` are a natural pairing -- a `FatalErrorMarker` is created by calling `FatalError::raise`, so this is effectively getting back the original `FatalError`. This requires a tiny change in `catch_with_exit_code`. The old result of the `catch_fatal_errors` call there was `Result<Result<(), ErrorGuaranteed>, ErrorGuaranteed>` which could be `flatten`ed into `Result<(), ErrorGuaranteed>`. The new result of the `catch_fatal_errors` calls is `Result<Result<(), ErrorGuaranteed>, FatalError>`, which can't be `flatten`ed but is still easily matched for the success case.
Configuration menu - View commit details
-
Copy full SHA for e55df62 - Browse repository at this point
Copy the full SHA e55df62View commit details -
rustdoc: make
main
more like rustc's.By making non-unicode arguments a fatal error instead of a warning, we don't need to handle what comes after, which avoids the need for an `unchecked_claim_error_was_emitted` call.
Configuration menu - View commit details
-
Copy full SHA for e6794dd - Browse repository at this point
Copy the full SHA e6794ddView commit details -
rustdoc: remove
unchecked_claim_error_was_emitted
call inmain_args
.`main_args` calls `from_matches`, which does lots of initialization. If anything goes wrong, `from_matches` emits an error message and returns `Err(1)` (or `Err(3)`). `main_args` then turns the `Err(1)` into `Err(ErrorGuaranteed)`, because that's what `catch_with_exit_code` requires on error. But `catch_with_exit_code` doesn't do anything with the `ErrorGuaranteed`, it just exits with `EXIT_FAILURE`. We can avoid the creation of the `ErrorGuaranteed` (which requires an undesirable `unchecked_claim_error_was_emitted` call), by changing `from_matches` to instead eagerly abort if anything goes wrong. The behaviour from the user's point of view is the same: an early abort with an `EXIT_FAILURE` exit code. And we can also simplify `from_matches` to return an `Option` instead of a `Result`: - Old `Err(0)` case --> `None` - Old `Err(_)` case --> fatal error. This requires similar changes to `ScrapeExamplesOptions::new` and `load_call_locations`.
Configuration menu - View commit details
-
Copy full SHA for 83adf88 - Browse repository at this point
Copy the full SHA 83adf88View commit details -
Tighten up
ErrorGuaranteed
handling.- In `emit_producing_error_guaranteed`, only allow `Level::Error`. - In `emit_diagnostic`, only produce `ErrorGuaranteed` for `Level` and `DelayedBug`. (Not `Bug` or `Fatal`. They don't need it, because the relevant `emit` methods abort.) - Add/update various comments.
Configuration menu - View commit details
-
Copy full SHA for 97c157f - Browse repository at this point
Copy the full SHA 97c157fView commit details -
Rename
unchecked_claim_error_was_emitted
as `unchecked_error_guaran……teed`. It's more to-the-point.
Configuration menu - View commit details
-
Copy full SHA for 6889fe3 - Browse repository at this point
Copy the full SHA 6889fe3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5e6df0 - Browse repository at this point
Copy the full SHA c5e6df0View commit details -
Rollup merge of rust-lang#110482 - chrisnc:armv8r-target, r=wesleywiser
Add armv8r-none-eabihf target for the Cortex-R52.
Configuration menu - View commit details
-
Copy full SHA for 2b6f393 - Browse repository at this point
Copy the full SHA 2b6f393View commit details -
Rollup merge of rust-lang#119162 - heiher:direct-access-external-data…
…, r=petrochenkov Add unstable `-Z direct-access-external-data` cmdline flag for `rustc` The new flag has been described in the Major Change Proposal at rust-lang/compiler-team#707 Fixes rust-lang#118053
Configuration menu - View commit details
-
Copy full SHA for 2e7e637 - Browse repository at this point
Copy the full SHA 2e7e637View commit details -
Rollup merge of rust-lang#120302 - oli-obk:const_intern_cleanups, r=R…
…alfJung various const interning cleanups After rust-lang#119044 I noticed that some things can be simplified and refactored. This is also a requirement for rust-lang#116564 as there we'll need to treat the base allocation differently from the others r? ```@RalfJung```
Configuration menu - View commit details
-
Copy full SHA for c541dc4 - Browse repository at this point
Copy the full SHA c541dc4View commit details -
Rollup merge of rust-lang#120455 - JarlEvanson:sroa-miri-tests, r=cjg…
…illot Add FileCheck annotations to MIR-opt SROA tests Part of rust-lang#116971, adds FileCheck annotations to SROA MIR-opt tests in `tests/mir-opt/sroa` and a few uncategorized files. r? cjgillot
Configuration menu - View commit details
-
Copy full SHA for 5661a5b - Browse repository at this point
Copy the full SHA 5661a5bView commit details -
Rollup merge of rust-lang#120470 - estebank:issue-54196, r=compiler-e…
…rrors Mark "unused binding" suggestion as maybe incorrect Ignoring unused bindings should be a determination made by a human, `rustfix` shouldn't auto-apply the suggested change. Fix rust-lang#54196.
Configuration menu - View commit details
-
Copy full SHA for faa8be0 - Browse repository at this point
Copy the full SHA faa8be0View commit details -
Rollup merge of rust-lang#120479 - estebank:issue-61788, r=wesleywiser
Suggest turning `if let` into irrefutable `let` if appropriate When encountering an `if let` tail expression without an `else` arm for an enum with a single variant, suggest writing an irrefutable `let` binding instead. ``` error[E0317]: `if` may be missing an `else` clause --> $DIR/irrefutable-if-let-without-else.rs:8:5 | LL | fn foo(x: Enum) -> i32 { | --- expected `i32` because of this return type LL | / if let Enum::Variant(value) = x { LL | | value LL | | } | |_____^ expected `i32`, found `()` | = note: `if` expressions without `else` evaluate to `()` = help: consider adding an `else` block that evaluates to the expected type help: consider using an irrefutable `let` binding instead | LL ~ let Enum::Variant(value) = x; LL ~ value | ``` Fix rust-lang#61788.
Configuration menu - View commit details
-
Copy full SHA for 0aefc20 - Browse repository at this point
Copy the full SHA 0aefc20View commit details -
Rollup merge of rust-lang#120564 - Zalathar:increment-site, r=oli-obk
coverage: Split out counter increment sites from BCB node/edge counters This makes it possible for two nodes/edges in the coverage graph to share the same counter, without causing the instrumentor to inject unwanted duplicate counter-increment statements. --- ```@rustbot``` label +A-code-coverage
Configuration menu - View commit details
-
Copy full SHA for 57caa20 - Browse repository at this point
Copy the full SHA 57caa20View commit details -
Rollup merge of rust-lang#120633 - Nadrieril:place_info, r=compiler-e…
…rrors pattern_analysis: gather up place-relevant info We track 3 things about each place during exhaustiveness: its type, its (data) validity, and whether it's the scrutinee place. This PR gathers all three into a single struct. r? ````@compiler-errors````
Configuration menu - View commit details
-
Copy full SHA for 6edc4d7 - Browse repository at this point
Copy the full SHA 6edc4d7View commit details -
Rollup merge of rust-lang#120664 - SparrowLii:parallel_test, r=nnethe…
…rcote Add parallel rustc ui tests Updates rust-lang#118698 Add some ui tests for parallel rustc front end This is a relatively large feature so I think it's worth creating a new entity in tests/ui folder, so we need to modify the limit in tidy.
Configuration menu - View commit details
-
Copy full SHA for 8ba999e - Browse repository at this point
Copy the full SHA 8ba999eView commit details -
Rollup merge of rust-lang#120721 - onur-ozkan:incorrect-llvm-path-on-…
…cross-target, r=albertlarsan68 fix `llvm_out` to use the correct LLVM root When `download-ci-llvm` is enabled, `llvm_out` ends up with the error below due to an incorrect path on cross-compilations. This change fixes that. ```sh failed to execute command: "/rust/build/x86_64-unknown-linux-gnu/llvm/build/bin/llvm-config" "--version" ERROR: No such file or directory (os error 2) ```
Configuration menu - View commit details
-
Copy full SHA for 0d3ff16 - Browse repository at this point
Copy the full SHA 0d3ff16View commit details -
Rollup merge of rust-lang#120726 - saethlin:no-bashism, r=Mark-Simula…
…crum Don't use bashism in checktools.sh `if [[` doesn't work because this is a `/bin/sh` script. We were never running the success side of this `if` at all.
Configuration menu - View commit details
-
Copy full SHA for ce49414 - Browse repository at this point
Copy the full SHA ce49414View commit details -
Rollup merge of rust-lang#120733 - klensy:trait-const-fn, r=oli-obk
MirPass: make name more const Continues rust-lang#120161, this time applied to `MirPass` instead of `MirLint`, locally shaves few (very few) instructions off. r? `@cjgillot`
Configuration menu - View commit details
-
Copy full SHA for 4a110f2 - Browse repository at this point
Copy the full SHA 4a110f2View commit details -
Rollup merge of rust-lang#120735 - nnethercote:rm-some-unchecked_clai…
…ms, r=oli-obk Remove some `unchecked_claim_error_was_emitted` calls We want to drive the number of these calls down as much as possible. This PR gets rid of a bunch of them. r? `@oli-obk`
Configuration menu - View commit details
-
Copy full SHA for 600d3bb - Browse repository at this point
Copy the full SHA 600d3bbView commit details