-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtree update of rust-analyzer
#120916
Merged
Merged
Subtree update of rust-analyzer
#120916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts except for pats in fn bodies
minor: polish warning msg sorry for this 😅 ![PixPin_2024-02-04_18-33-23](https://github.com/rust-lang/rust-analyzer/assets/71162630/9aaa49d7-34f4-4c78-b91c-e85550252e25)
internal: Sync from downstream
To be added back later once we have a fix. See rust-lang#16471 and rust-lang/rust-analyzer#16497 (comment).
…_to_string, r=lnicola internal: Enable str_to_string Clippy rule This fix [the FIXME comment](https://github.com/rust-lang/rust-analyzer/blob/bb0de88f24cc3a8de10837585fbb8172f6859752/Cargo.toml#L183-L184)
…cro-generated-method, r=Veykril Fix incorrect inlining of functions that come from MBE macros Partial fix for rust-lang/rust-analyzer#16471. As a reminder, there are two issues there: 1. missing whitespace in parameter types (the first test) 2. the `self` parameter not being replaced by `this` in the function body (the second test) The first part is fixed in this PR. See [this comment](rust-lang/rust-analyzer#16497 (comment)) for the second.
Abstract more over ItemTreeLoc-like structs Allows reducing some code duplication by using functions generic over said structs. The diff isn't negative due to me adding some additional impls for completeness.
…r=Veykril minor: test that flip_trait_bound works with trait objects Closes rust-lang/rust-analyzer#16522.
internal: Cleanup 🧹
internal: Remove SELF_REF hack for self referential SyntaxContexts This should reduce the amount of SyntaxContexts we allocate
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Feb 11, 2024
@bors r+ p=1 subtree sync |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 11, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 11, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#117740 (Add some links and minor explanatory comments to `std::fmt`) - rust-lang#118307 (Remove an unneeded helper from the tuple library code) - rust-lang#119242 (Suggest less bug-prone construction of Duration in docs) - rust-lang#119449 (Fix `clippy::correctness` in the library) - rust-lang#120307 (core: add Duration constructors) - rust-lang#120459 (Document various I/O descriptor/handle conversions) - rust-lang#120729 (Update mdbook to 0.4.37) - rust-lang#120763 (Suggest pattern tests when modifying exhaustiveness) - rust-lang#120906 (Remove myself from some review rotations) - rust-lang#120916 (Subtree update of ` rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 11, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#117740 (Add some links and minor explanatory comments to `std::fmt`) - rust-lang#118307 (Remove an unneeded helper from the tuple library code) - rust-lang#119242 (Suggest less bug-prone construction of Duration in docs) - rust-lang#119449 (Fix `clippy::correctness` in the library) - rust-lang#120307 (core: add Duration constructors) - rust-lang#120459 (Document various I/O descriptor/handle conversions) - rust-lang#120729 (Update mdbook to 0.4.37) - rust-lang#120763 (Suggest pattern tests when modifying exhaustiveness) - rust-lang#120906 (Remove myself from some review rotations) - rust-lang#120916 (Subtree update of ` rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 11, 2024
Rollup merge of rust-lang#120916 - lnicola:sync-from-ra, r=lnicola Subtree update of ` rust-analyzer` r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ghost