Rollup of 10 pull requests

[matthiaskrgr]

Successful merges:

• Add some links and minor explanatory comments to std::fmt #117740 (Add some links and minor explanatory comments to std::fmt)
• Remove an unneeded helper from the tuple library code #118307 (Remove an unneeded helper from the tuple library code)
• Suggest less bug-prone construction of Duration in docs #119242 (Suggest less bug-prone construction of Duration in docs)
• Fix clippy::correctness in the library #119449 (Fix clippy::correctness in the library)
• core: add Duration constructors #120307 (core: add Duration constructors)
• Document various I/O descriptor/handle conversions #120459 (Document various I/O descriptor/handle conversions)
• Update mdbook to 0.4.37 #120729 (Update mdbook to 0.4.37)
• Suggest pattern tests when modifying exhaustiveness #120763 (Suggest pattern tests when modifying exhaustiveness)
• Remove myself from some review rotations #120906 (Remove myself from some review rotations)
• Subtree update of rust-analyzer #120916 (Subtree update of rust-analyzer)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=10

[bors]

📌 Commit 3ac0872 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 3ac0872 with merge eb5a0ed...

[rust-log-analyzer]

The job dist-apple-various failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[117/119] Building CXX object lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_thread.cpp.o
[118/119] Building CXX object lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_interceptors.cpp.o
[119/119] Linking CXX shared library lib/darwin/libclang_rt.asan_ios_dynamic.dylib
clang-14: warning: argument unused during compilation: '-static-libstdc++' [-Wunused-command-line-argument]
-iphoneos_version_min has been renamed to -ios_version_min
ld: warning: '/Users/runner/work/rust/rust/build/aarch64-apple-ios/native/sanitizers/build/lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_activation.cpp.o' has malformed LC_DYSYMTAB, expected 35 undefined symbols to start at index 51, found 32 undefined symbols starting at index 51
ld: warning: '/Users/runner/work/rust/rust/build/aarch64-apple-ios/native/sanitizers/build/lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_allocator.cpp.o' has malformed LC_DYSYMTAB, expected 68 undefined symbols to start at index 211, found 65 undefined symbols starting at index 211
ld: warning: '/Users/runner/work/rust/rust/build/aarch64-apple-ios/native/sanitizers/build/lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_debugging.cpp.o' has malformed LC_DYSYMTAB, expected 26 undefined symbols to start at index 28, found 23 undefined symbols starting at index 28
ld: warning: '/Users/runner/work/rust/rust/build/aarch64-apple-ios/native/sanitizers/build/lib/asan/CMakeFiles/RTAsan_dynamic.ios.dir/asan_descriptions.cpp.o' has malformed LC_DYSYMTAB, expected 51 undefined symbols to start at index 96, found 48 undefined symbols starting at index 96
---
[36/36] Linking CXX shared library lib/darwin/libclang_rt.tsan_ios_dynamic.dylib
/Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: warning: changes being made to the file will invalidate the code signature in: /Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/aarch64-apple-ios/lib/librustc-nightly_rt.asan.dylib
clang-14: warning: argument unused during compilation: '-static-libstdc++' [-Wunused-command-line-argument]
/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/aarch64-apple-ios/lib/librustc-nightly_rt.asan.dylib: replacing existing signature
-iphoneos_version_min has been renamed to -ios_version_min
 finished in 103.890 seconds
##[endgroup]
/Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: warning: changes being made to the file will invalidate the code signature in: /Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/lib/rustlib/aarch64-apple-ios/lib/librustc-nightly_rt.tsan.dylib
[TIMING] core::build_steps::llvm::Sanitizers { target: aarch64-apple-ios } -- 103.905
---
-- Found assembler: /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - failed
-- Check for working C compiler: /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang
-- Check for working C compiler: /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang - broken
CMake Error at /usr/local/Cellar/cmake/3.28.2/share/cmake/Modules/CMakeTestCCompiler.cmake:67 (message):

    "/Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang"

  is not able to compile a simple test program.
  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: '/Users/runner/work/rust/rust/build/x86_64-apple-ios/native/sanitizers/build/CMakeFiles/CMakeScratch/TryCompile-6V70sm'
    
    Run Build Command(s): /usr/local/bin/ninja -v cmTC_bf26e
    [1/2] /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang --target=x86_64-apple-ios   -fPIC --target=x86_64-apple-ios -m64 -mios-simulator-version-min=7.0 -isysroot /Applications/Xcode_15.0.1.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.0.sdk -fembed-bitcode -fdebug-prefix-map=/Users/runner/work/rust/rust=/rustc/llvm -fembed-bitcode=off -MD -MT CMakeFiles/cmTC_bf26e.dir/testCCompiler.c.o -MF CMakeFiles/cmTC_bf26e.dir/testCCompiler.c.o.d -o CMakeFiles/cmTC_bf26e.dir/testCCompiler.c.o -c /Users/runner/work/rust/rust/build/x86_64-apple-ios/native/sanitizers/build/CMakeFiles/CMakeScratch/TryCompile-6V70sm/testCCompiler.c
    [2/2] : && /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang --target=x86_64-apple-ios -fPIC --target=x86_64-apple-ios -m64 -mios-simulator-version-min=7.0 -isysroot /Applications/Xcode_15.0.1.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.0.sdk -fembed-bitcode -fdebug-prefix-map=/Users/runner/work/rust/rust=/rustc/llvm -fembed-bitcode=off -Wl,-search_paths_first  -static-libstdc++ CMakeFiles/cmTC_bf26e.dir/testCCompiler.c.o -o cmTC_bf26e   && :
    FAILED: cmTC_bf26e 
    : && /Users/runner/work/rust/rust/clang+llvm-14.0.5-x86_64-apple-darwin/bin/clang --target=x86_64-apple-ios -fPIC --target=x86_64-apple-ios -m64 -mios-simulator-version-min=7.0 -isysroot /Applications/Xcode_15.0.1.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.0.sdk -fembed-bitcode -fdebug-prefix-map=/Users/runner/work/rust/rust=/rustc/llvm -fembed-bitcode=off -Wl,-search_paths_first  -static-libstdc++ CMakeFiles/cmTC_bf26e.dir/testCCompiler.c.o -o cmTC_bf26e   && :
    clang-14: warning: argument unused during compilation: '-static-libstdc++' [-Wunused-command-line-argument]
    ld: unknown options: -ios_simulator_version_min 
    clang-14: error: linker command failed with exit code 1 (use -v to see invocation)
    ninja: build stopped: subcommand failed.
    

  


  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:14 (project)


-- Configuring incomplete, errors occurred!
thread 'main' panicked at /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cmake-0.1.48/src/lib.rs:975:5:
command did not execute successfully, got: exit status: 1

build script failed, must exit now
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[bors]

💔 Test failed - checks-actions

[matthiaskrgr]

@bors retry ios_simulator_version_min

[bors]

⌛ Testing commit 3ac0872 with merge 980cf08...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 980cf08 to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#117740	Add some links and minor explanatory comments to std::fmt	35f65626b050716c92383dd4236515fb33a8be08 (link)
#118307	Remove an unneeded helper from the tuple library code	39c9a307cd02fba214a3c8f6ec23f5fe709a80b1 (link)
#119242	Suggest less bug-prone construction of Duration in docs	e250592c72570455750bd151a770b0ad272b68de (link)
#119449	Fix clippy::correctness in the library	a379035bd27128dd46401be8181b2c528d9bc7e2 (link)
#120307	core: add Duration constructors	bdf983aab925e1eb0fed264a6cc6160ed0920409 (link)
#120459	Document various I/O descriptor/handle conversions	bb3c69b256e124067a1c546559d700efdca50b1e (link)
#120729	Update mdbook to 0.4.37	6725632ade0eeb1d53ba0b158a1e138547bfb2da (link)
#120763	Suggest pattern tests when modifying exhaustiveness	923db3a8198c0c6649d1f000f374e4da023193fb (link)
#120906	Remove myself from some review rotations	c0535b9f3209fd4cbd8c481dfc7cc04115b67ff4 (link)
#120916	Subtree update of rust-analyzer	ef7f17568344ee9e97494e6efbaeb585717d65a7 (link)

previous master: 899c895ba4

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (980cf08): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.4%, 0.4%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.7%	[-1.7%, -1.7%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.5%	[1.1%, 5.3%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-11.7%	[-11.7%, -11.7%]	1
Improvements ✅ (secondary)	-3.0%	[-5.0%, -2.1%]	4
All ❌✅ (primary)	-1.1%	[-11.7%, 5.3%]	4

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.2%]	5
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.0%]	8
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.0%	[-0.1%, 0.2%]	13

Bootstrap: 664.861s -> 663.621s (-0.19%)
Artifact size: 308.40 MiB -> 308.42 MiB (0.01%)