Remove `feed_local_def_id` #121089

oli-obk · 2024-02-14T15:44:41Z

best reviewed commit by commit

Basically I returned TyCtxtFeed from create_def and then preserved that in the local caches

based on #121084

r? @petrochenkov

cjgillot · 2024-02-18T18:27:07Z

@bors r+

bors · 2024-02-18T18:27:09Z

📌 Commit a640db5 has been approved by cjgillot

It is now in the queue for this repository.

petrochenkov · 2024-02-18T19:58:34Z

I don't understand what we get from this, to be honest.
What are the additional guarantees from keeping Feeds in node_id_to_def_id tables?

oli-obk · 2024-02-18T20:18:50Z

What are the additional guarantees from keeping Feeds in node_id_to_def_id tables?

that you don't feed from another query but the one that created the DefId. Feed cannot be transferred across query boundaries.

feed_local_def_id is a massive footgun and if anone uses it from anywhere but the resolver it will cause undebuggable incremental ICEs. The reason the resolver is fine is that it is (like the analysis query, an outermost (not called from another query) eval_always query.

Remove `feed_local_def_id` best reviewed commit by commit Basically I returned `TyCtxtFeed` from `create_def` and then preserved that in the local caches based on rust-lang#121084 r? `@petrochenkov`

bors · 2024-02-19T07:46:46Z

⌛ Testing commit a640db5 with merge 5bffa10...

petrochenkov · 2024-02-19T09:06:26Z

What are the additional guarantees from keeping Feeds in node_id_to_def_id tables?

that you don't feed from another query but the one that created the DefId. Feed cannot be transferred across query boundaries.

feed_local_def_id is a massive footgun and if anone uses it from anywhere but the resolver it will cause undebuggable incremental ICEs. The reason the resolver is fine is that it is (like the analysis query, an outermost (not called from another query) eval_always query.

I probably makes sense to put this explanation as a comment on struct Feed.

compiler/rustc_middle/src/ty/context.rs

petrochenkov · 2024-02-19T09:15:01Z

Feed cannot be transferred across query boundaries.

I'm not sure if it's a hard guarantee, or something that we need to keep in mind when writing new code.

For example, what happens if we put Feed into ResolverOutputs?
Then it will be usable from other queries through tcx.resolutions(()).

oli-obk · 2024-02-19T10:52:01Z

I'm not sure if it's a hard guarantee

I'll add a negative impl for the relevant traits

oli-obk · 2024-02-19T17:43:17Z

@bors try @rust-timer queue

bors · 2024-02-19T17:45:27Z

⌛ Trying commit a0aeca0 with merge 9b35aff...

Remove `feed_local_def_id` best reviewed commit by commit Basically I returned `TyCtxtFeed` from `create_def` and then preserved that in the local caches based on rust-lang#121084 r? `@petrochenkov`

oli-obk · 2024-03-05T09:02:00Z

@rustbot ready

petrochenkov · 2024-03-05T09:45:38Z

r=me after updating the failing test.
@rustbot author

oli-obk · 2024-03-05T10:02:53Z

@bors r=petrochenkov

bors · 2024-03-05T10:02:57Z

📌 Commit ef00fae has been approved by petrochenkov

It is now in the queue for this repository.

…enkov Remove `feed_local_def_id` best reviewed commit by commit Basically I returned `TyCtxtFeed` from `create_def` and then preserved that in the local caches based on rust-lang#121084 r? `@petrochenkov`

…enkov Remove `feed_local_def_id` best reviewed commit by commit Basically I returned `TyCtxtFeed` from `create_def` and then preserved that in the local caches based on rust-lang#121084 r? ``@petrochenkov``

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#113518 (bootstrap/libtest: print test name eagerly on failure even with `verbose-tests=false` / `--quiet`) - rust-lang#119888 (Stabilize the `#[diagnostic]` namespace and `#[diagnostic::on_unimplemented]` attribute) - rust-lang#121089 (Remove `feed_local_def_id`) - rust-lang#121926 (`f16` and `f128` step 3: compiler support & feature gate) - rust-lang#121959 (Removing absolute path in proc-macro) - rust-lang#122015 (Add better explanation for `rustc_index::IndexVec`) - rust-lang#122027 (Uplift some feeding out of `associated_type_for_impl_trait_in_impl` and into queries) - rust-lang#122038 (Fix linting paths with qself in `unused_qualifications`) r? `@ghost` `@rustbot` modify labels: rollup

…enkov Remove `feed_local_def_id` best reviewed commit by commit Basically I returned `TyCtxtFeed` from `create_def` and then preserved that in the local caches based on rust-lang#121084 r? ```@petrochenkov```

…kingjubilee Rollup of 13 pull requests Successful merges: - rust-lang#113525 (Dynamically size sigaltstk in std) - rust-lang#114009 (compiler: allow transmute of ZST arrays with generics) - rust-lang#116793 (Allow targets to override default codegen backend) - rust-lang#118623 (Improve std::fs::read_to_string example) - rust-lang#120504 (Vec::try_with_capacity) - rust-lang#121089 (Remove `feed_local_def_id`) - rust-lang#121280 (Implement MaybeUninit::fill{,_with,_from}) - rust-lang#122087 (Add missing background color for top-level rust documentation page and increase contrast by setting text color to black) - rust-lang#122104 (Rust is a proper name: rust → Rust) - rust-lang#122110 (Make `x t miri` respect `MIRI_TEMP`) - rust-lang#122114 (Make not finding core a fatal error) - rust-lang#122115 (Cancel parsing ever made during recovery) - rust-lang#122126 (Fix `tidy --bless` on ̶X̶e̶n̶i̶x̶ Windows) r? `@ghost` `@rustbot` modify labels: rollup

…llaumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#119888 (Stabilize the `#[diagnostic]` namespace and `#[diagnostic::on_unimplemented]` attribute) - rust-lang#121089 (Remove `feed_local_def_id`) - rust-lang#122004 (AST validation: Improve handling of inherent impls nested within functions and anon consts) - rust-lang#122087 (Add missing background color for top-level rust documentation page and increase contrast by setting text color to black) - rust-lang#122136 (Include all library files in artifact summary on CI) - rust-lang#122137 (Don't pass a break scope to `Builder::break_for_else`) - rust-lang#122138 (Record mtime in bootstrap's LLVM linker script) - rust-lang#122141 (sync (try_)instantiate_mir_and_normalize_erasing_regions implementation) - rust-lang#122142 (cleanup rustc_infer) - rust-lang#122147 (Make `std::os::unix::ucred` module private) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#121089 - oli-obk:create_def_feed, r=petrochenkov Remove `feed_local_def_id` best reviewed commit by commit Basically I returned `TyCtxtFeed` from `create_def` and then preserved that in the local caches based on rust-lang#121084 r? ````@petrochenkov````

rustbot assigned petrochenkov Feb 14, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 14, 2024

This comment was marked as resolved.

Sign in to view

oli-obk force-pushed the create_def_feed branch from d6284b0 to 4ae6054 Compare February 14, 2024 16:02

oli-obk mentioned this pull request Feb 14, 2024

Ensure we only feed def ids via create_def or within eval_always queries #121080

Closed

This comment was marked as resolved.

Sign in to view

oli-obk force-pushed the create_def_feed branch from 4ae6054 to a640db5 Compare February 15, 2024 12:32

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2024

petrochenkov reviewed Feb 19, 2024

View reviewed changes

compiler/rustc_middle/src/ty/context.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

This comment was marked as resolved.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 19, 2024

oli-obk force-pushed the create_def_feed branch from a640db5 to a0aeca0 Compare February 19, 2024 17:25

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 19, 2024

Remove a use of feed_local_crate and make it fail if used within queries

c696d4c

oli-obk force-pushed the create_def_feed branch 2 times, most recently from f835818 to 7361780 Compare March 5, 2024 09:01

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 5, 2024

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2024

Avoid using feed_unit_query from within queries

ef00fae

oli-obk force-pushed the create_def_feed branch from 7361780 to ef00fae Compare March 5, 2024 10:02

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 5, 2024

matthiaskrgr mentioned this pull request Mar 6, 2024

Rollup of 9 pull requests #122067

Closed

matthiaskrgr mentioned this pull request Mar 6, 2024

Rollup of 8 pull requests #122068

Closed

workingjubilee mentioned this pull request Mar 7, 2024

Rollup of 13 pull requests #122131

Closed

GuillaumeGomez mentioned this pull request Mar 7, 2024

Rollup of 10 pull requests #122151

Merged

bors merged commit 4de78d2 into rust-lang:master Mar 8, 2024
11 checks passed

rustbot added this to the 1.78.0 milestone Mar 8, 2024

oli-obk deleted the create_def_feed branch March 8, 2024 05:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove `feed_local_def_id` #121089

Remove `feed_local_def_id` #121089

oli-obk commented Feb 14, 2024 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

cjgillot commented Feb 18, 2024

bors commented Feb 18, 2024

petrochenkov commented Feb 18, 2024

oli-obk commented Feb 18, 2024 •

edited

Loading

bors commented Feb 19, 2024

petrochenkov commented Feb 19, 2024

petrochenkov commented Feb 19, 2024

This comment has been minimized.

This comment was marked as resolved.

oli-obk commented Feb 19, 2024

oli-obk commented Feb 19, 2024

This comment has been minimized.

bors commented Feb 19, 2024

oli-obk commented Mar 5, 2024

This comment has been minimized.

petrochenkov commented Mar 5, 2024

oli-obk commented Mar 5, 2024

bors commented Mar 5, 2024

Remove feed_local_def_id #121089

Remove feed_local_def_id #121089

Conversation

oli-obk commented Feb 14, 2024 • edited Loading

This comment was marked as resolved.

This comment was marked as resolved.

cjgillot commented Feb 18, 2024

bors commented Feb 18, 2024

petrochenkov commented Feb 18, 2024

oli-obk commented Feb 18, 2024 • edited Loading

bors commented Feb 19, 2024

petrochenkov commented Feb 19, 2024

petrochenkov commented Feb 19, 2024

This comment has been minimized.

This comment was marked as resolved.

oli-obk commented Feb 19, 2024

oli-obk commented Feb 19, 2024

This comment has been minimized.

bors commented Feb 19, 2024

oli-obk commented Mar 5, 2024

This comment has been minimized.

petrochenkov commented Mar 5, 2024

oli-obk commented Mar 5, 2024

bors commented Mar 5, 2024

Remove `feed_local_def_id` #121089

Remove `feed_local_def_id` #121089

oli-obk commented Feb 14, 2024 •

edited

Loading

oli-obk commented Feb 18, 2024 •

edited

Loading