Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MaybeUninit::fill{,_with,_from} #121280

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Implement MaybeUninit::fill{,_with,_from} #121280

merged 1 commit into from
Mar 9, 2024

Conversation

ajwock
Copy link
Contributor

@ajwock ajwock commented Feb 18, 2024

@rustbot
Copy link
Collaborator

rustbot commented Feb 18, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 18, 2024
@ajwock
Copy link
Contributor Author

ajwock commented Feb 18, 2024

With @jmillikin 's blessing, I am submitting a new PR for:

Tracking issue: #117428

ACP: rust-lang/libs-team#156

Credit to him for letting me use bits of his PR, especially testing.

@ajwock ajwock mentioned this pull request Feb 18, 2024
Open
3 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ajwock
Copy link
Contributor Author

ajwock commented Mar 1, 2024

r? @Amanieu

I understand you've reviewed the previous implementation of this ACP.

@rustbot rustbot assigned Amanieu and unassigned cuviper Mar 1, 2024
@Amanieu
Copy link
Member

Amanieu commented Mar 4, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Mar 4, 2024

📌 Commit 313eb8f has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 5, 2024
@matthiaskrgr
Rollup merge of rust-lang#121280 - ajwock:maybeuninit_fill, r=Amanieu
955a160 
Implement MaybeUninit::fill{,_with,_from}

ACP: rust-lang/libs-team#156
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 5, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2024
@bors
Auto merge of rust-lang#122031 - matthiaskrgr:rollup-mp1ii7n, r=matth…
9caa535 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#121280 (Implement MaybeUninit::fill{,_with,_from})
 - rust-lang#121438 (std support for wasm32 panic=unwind)
 - rust-lang#121658 (Hint user to update nightly on ICEs produced from outdated nightly)
 - rust-lang#121959 (Removing absolute path in proc-macro)
 - rust-lang#121961 (add test for rust-lang#78894 rust-lang#71450)
 - rust-lang#121975 (hir_analysis: enums return `None` in `find_field`)
 - rust-lang#121978 (Fix duplicated path in the "not found dylib" error)
 - rust-lang#121991 (Merge impl_trait_in_assoc_types_defined_by query back into `opaque_types_defined_by`)
 - rust-lang#122016 (will_wake tests fail on Miri and that is expected)
 - rust-lang#122018 (only set noalias on Box with the global allocator)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

@bors r-
#122031 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 5, 2024
@ajwock ajwock force-pushed the maybeuninit_fill branch 2 times, most recently from d92c600 to 96375a0 Compare March 5, 2024 19:49
@ajwock
Implement MaybeUninit::fill{,_with,_from}
0a00749 
ACP: rust-lang/libs-team#156

Signed-off-by: Andrew Wock <ajwock@gmail.com>
@Amanieu
Copy link
Member

Amanieu commented Mar 5, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Mar 5, 2024

📌 Commit 0a00749 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 5, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 7, 2024
@workingjubilee
Rollup merge of rust-lang#121280 - ajwock:maybeuninit_fill, r=Amanieu
ef8b1df 
Implement MaybeUninit::fill{,_with,_from}

ACP: rust-lang/libs-team#156
@workingjubilee workingjubilee mentioned this pull request Mar 7, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2024
@bors
Auto merge of rust-lang#122131 - workingjubilee:rollup-901aab1, r=wor…
18f5391 
…kingjubilee

Rollup of 13 pull requests

Successful merges:

 - rust-lang#113525 (Dynamically size sigaltstk in std)
 - rust-lang#114009 (compiler: allow transmute of ZST arrays with generics)
 - rust-lang#116793 (Allow targets to override default codegen backend)
 - rust-lang#118623 (Improve std::fs::read_to_string example)
 - rust-lang#120504 (Vec::try_with_capacity)
 - rust-lang#121089 (Remove `feed_local_def_id`)
 - rust-lang#121280 (Implement MaybeUninit::fill{,_with,_from})
 - rust-lang#122087 (Add missing background color for top-level rust documentation page and increase contrast by setting text color to black)
 - rust-lang#122104 (Rust is a proper name: rust → Rust)
 - rust-lang#122110 (Make `x t miri` respect `MIRI_TEMP`)
 - rust-lang#122114 (Make not finding core a fatal error)
 - rust-lang#122115 (Cancel parsing ever made during recovery)
 - rust-lang#122126 (Fix `tidy --bless` on  ̶X̶e̶n̶i̶x̶ Windows)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 9, 2024
@jhpratt
Rollup merge of rust-lang#121280 - ajwock:maybeuninit_fill, r=Amanieu
3c6b895 
Implement MaybeUninit::fill{,_with,_from}

ACP: rust-lang/libs-team#156
@jhpratt jhpratt mentioned this pull request Mar 9, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2024
@bors
Auto merge of rust-lang#122229 - jhpratt:rollup-o2dscvq, r=jhpratt
c33ba48 
Rollup of 12 pull requests

Successful merges:

 - rust-lang#99153 (Add Read Impl for &Stdin)
 - rust-lang#112136 (Add std::ffi::c_str module)
 - rust-lang#120504 (Vec::try_with_capacity)
 - rust-lang#121280 (Implement MaybeUninit::fill{,_with,_from})
 - rust-lang#121813 (Misc improvements to non local defs lint implementation)
 - rust-lang#121833 (Suggest correct path in include_bytes!)
 - rust-lang#121860 (Add a tidy check that checks whether the fluent slugs only appear once)
 - rust-lang#122160 (Eagerly translate `HelpUseLatestEdition` in parser diagnostics)
 - rust-lang#122178 (ci: add a runner for vanilla LLVM 18)
 - rust-lang#122186 (Remove a workaround for a bug)
 - rust-lang#122215 (Some tweaks to the parallel query cycle handler)
 - rust-lang#122223 (Fix typo in `VisitorResult`)

r? `@ghost`
`@rustbot` modify labels: rollup
@Nadrieril
Copy link
Member

@bors rollup

@Nadrieril Nadrieril mentioned this pull request Mar 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2024
@bors
Auto merge of rust-lang#122256 - Nadrieril:rollup-rc232xh, r=Nadrieril
2d24fe5 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#99153 (Add Read Impl for &Stdin)
 - rust-lang#114655 (Make `impl<Fd: AsFd>` impl take `?Sized`)
 - rust-lang#120504 (Vec::try_with_capacity)
 - rust-lang#121280 (Implement MaybeUninit::fill{,_with,_from})
 - rust-lang#121403 (impl From<TryReserveError> for io::Error)
 - rust-lang#121526 (on the fly type casting for `build.rustc` and `build.cargo`)
 - rust-lang#121584 (bump itertools to 0.12)
 - rust-lang#121711 (Implement junction_point)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cbd59d0 into rust-lang:master Mar 9, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2024
@rust-timer
Unrolled build for rust-lang#121280
b8f9fdf 
Rollup merge of rust-lang#121280 - ajwock:maybeuninit_fill, r=Amanieu

Implement MaybeUninit::fill{,_with,_from}

ACP: rust-lang/libs-team#156
@jmillikin jmillikin mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
8 participants
@ajwock @rustbot @rust-log-analyzer @Amanieu @bors @matthiaskrgr @Nadrieril @cuviper