Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure std is prepared for cross-targets #122205

Merged
merged 1 commit into from
Mar 28, 2024
Merged

ensure std is prepared for cross-targets #122205

merged 1 commit into from
Mar 28, 2024

Conversation

onur-ozkan
Copy link
Member

@onur-ozkan onur-ozkan commented Mar 8, 2024 •
edited
Loading

Previously, doing x test compiler/* would result in build failures due to missing std. This PR fixes that.

@rustbot
Copy link
Collaborator

rustbot commented Mar 8, 2024

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 8, 2024
@onur-ozkan onur-ozkan mentioned this pull request Mar 8, 2024
Closed
@albertlarsan68
Copy link
Member

Thanks for the PR!
@bors r+

@bors
Copy link
Contributor

bors commented Mar 9, 2024

📌 Commit 0b55b01 has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2024
@matthiaskrgr
Rollup merge of rust-lang#122205 - onur-ozkan:incorrect-sysroot-for-t…
513ec6c 
…arget, r=albertlarsan68

ensure that sysroot is properly set for cross-targets

Previously, doing `x test compiler/*` would result in build failures due to missing libraries. This ensures properly setting up the sysroot for cross targets.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 10, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2024
@bors
Auto merge of rust-lang#122289 - matthiaskrgr:rollup-uik3gaz, r=matth…
a60ff62 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#121573 (unix_sigpipe: Add test for SIGPIPE disposition in child processes)
 - rust-lang#121754 ([bootstrap] Move the `split-debuginfo` setting to the per-target section)
 - rust-lang#122205 (ensure that sysroot is properly set for cross-targets)
 - rust-lang#122257 (mir-opt tests: don't run a different set on --bless; enable --keep-stage-std)
 - rust-lang#122272 (Subtree update of `rust-analyzer`)

Failed merges:

 - rust-lang#122108 (Add `target.*.runner` configuration for targets)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2024
@matthiaskrgr
Rollup merge of rust-lang#122205 - onur-ozkan:incorrect-sysroot-for-t…
a172eb0 
…arget, r=albertlarsan68

ensure that sysroot is properly set for cross-targets

Previously, doing `x test compiler/*` would result in build failures due to missing libraries. This ensures properly setting up the sysroot for cross targets.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 10, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 10, 2024
@bors
Auto merge of rust-lang#122303 - matthiaskrgr:rollup-ieokhnz, r=matth…
ffc7900 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#121754 ([bootstrap] Move the `split-debuginfo` setting to the per-target section)
 - rust-lang#122205 (ensure that sysroot is properly set for cross-targets)
 - rust-lang#122275 (disable OOM test in Miri)
 - rust-lang#122276 (io::Read trait: make it more clear when we are adressing implementations vs callers)
 - rust-lang#122286 (use Instance::expect_resolve() instead of unwraping Instance::resolve())
 - rust-lang#122290 (MIR printing: print the path of uneval'd const)
 - rust-lang#122293 (diagnostics: Do not suggest using `#[unix_sigpipe]` without a value)
 - rust-lang#122297 (bootstrap: document what the triples in 'Build' mean)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

@bors rollup=iffy

@bors
Copy link
Contributor

bors commented Mar 12, 2024

⌛ Testing commit 0b55b01 with merge 09ac3ea...

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2024
@bors
Auto merge of rust-lang#122205 - onur-ozkan:incorrect-sysroot-for-tar…
09ac3ea 
…get, r=albertlarsan68

ensure that sysroot is properly set for cross-targets

Previously, doing `x test compiler/*` would result in build failures due to missing libraries. This ensures properly setting up the sysroot for cross targets.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Mar 12, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 12, 2024
@onur-ozkan onur-ozkan force-pushed the incorrect-sysroot-for-target branch from 0b55b01 to d6fcc88 Compare March 12, 2024 21:57
@onur-ozkan
Copy link
Member Author

@bors r=albertlarsan68

@bors
Copy link
Contributor

bors commented Mar 12, 2024

📌 Commit d6fcc88 has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2024
@bors
Copy link
Contributor

bors commented Mar 12, 2024

⌛ Testing commit d6fcc88 with merge 7ecd864...

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2024
@bors
Auto merge of rust-lang#122205 - onur-ozkan:incorrect-sysroot-for-tar…
7ecd864 
…get, r=albertlarsan68

ensure that sysroot is properly set for cross-targets

Previously, doing `x test compiler/*` would result in build failures due to missing libraries. This ensures properly setting up the sysroot for cross targets.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Mar 13, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 13, 2024
@onur-ozkan onur-ozkan force-pushed the incorrect-sysroot-for-target branch from d6fcc88 to b0d01e7 Compare March 13, 2024 18:41
@onur-ozkan onur-ozkan changed the title ensure that sysroot is properly set for cross-targets ensure std is prepared for cross-targets Mar 13, 2024
@onur-ozkan onur-ozkan force-pushed the incorrect-sysroot-for-target branch from b0d01e7 to e5d52ce Compare March 13, 2024 18:42
@onur-ozkan
Copy link
Member Author

Due to failing target in CI, I did some changes. @albertlarsan68

@onur-ozkan onur-ozkan force-pushed the incorrect-sysroot-for-target branch from e5d52ce to a4aecdc Compare March 13, 2024 18:45
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onur-ozkan onur-ozkan force-pushed the incorrect-sysroot-for-target branch 2 times, most recently from 4da60fd to e493f96 Compare March 13, 2024 19:20
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 13, 2024
@onur-ozkan onur-ozkan force-pushed the incorrect-sysroot-for-target branch from bd9a00c to e493f96 Compare March 13, 2024 21:31
@onur-ozkan onur-ozkan removed A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 13, 2024
@onur-ozkan
Copy link
Member Author

Last attempt successfully fixed the CI problem https://github.com/rust-lang/rust/actions/runs/8271344437/job/22630901673?pr=122205

@onur-ozkan onur-ozkan force-pushed the incorrect-sysroot-for-target branch from e493f96 to 5aece7f Compare March 13, 2024 21:50
@onur-ozkan
ensure std for cross-targets
5aece7f 
Previously, doing `x test compiler/*` would fail the build due to missing std.
This change ensures that it is prepared.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
Copy link
Member Author

reminder ping

cc @albertlarsan68

@albertlarsan68
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 27, 2024

📌 Commit 5aece7f has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2024
@bors
Copy link
Contributor

bors commented Mar 27, 2024

⌛ Testing commit 5aece7f with merge 9d70954...

@bors
Copy link
Contributor

bors commented Mar 28, 2024

☀️ Test successful - checks-actions
Approved by: albertlarsan68
Pushing 9d70954 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 28, 2024
@bors bors merged commit 9d70954 into rust-lang:master Mar 28, 2024
12 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 28, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9d70954): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.5% [-1.8%, -1.3%] 3
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.5% [-1.8%, -1.3%] 3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.6% [0.6%, 0.6%] 1
Regressions ❌
(secondary)		 2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)		 -0.6% [-0.8%, -0.5%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.2% [-0.8%, 0.6%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.049s -> 670.576s (-0.22%)
Artifact size: 315.66 MiB -> 315.77 MiB (0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertlarsan68 albertlarsan68

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
7 participants
@onur-ozkan @rustbot @albertlarsan68 @bors @matthiaskrgr @rust-log-analyzer @rust-timer