Subtree update of `rust-analyzer` #122272

lnicola · 2024-03-10T06:48:59Z

r? ghost

…()` methods

…ponding HIR types

Update rustc_pattern_analysis This should fix rust-lang/rust-analyzer#16656 but I can't check because we don't have a reproducer.

internal: sync from downstream

fix: Add basic support for Native Debug Native Debug doesn't work very well and passing command-line arguments is nasty (rust-lang/rust-analyzer#9815), but I guess it's a start. Closes rust-lang#9815

…ykril fix: autocomplete constants inside format strings Hi! This PR adds autocompletion for constants (including statics) inside format strings and closes rust-lang#16608. I'm not sure about adding the `constants` field to the `CompletionContext`. It kinda makes sense, since it's in line with the `locals` field, and this way everything looks a bit cleaner, but at the same time does it really need to be there? Anyway, let me know if anything should/can be changed. :)

fix: use 4 spaces for indentation in macro expansion Partial fix for rust-lang#16471. In the previous code, the indentation produced by macro expansion was set to 2 spaces. This PR modifies it to 4 spaces for the sake of consistency.

Add more methods for resolving definitions from AST to their corresponding HIR types In order to be able to add these methods with consistent naming I had to also rename two existing methods that would otherwise be conflicting/confusing: `Semantics::to_module_def(&self, file: FileId) -> Option<Module>` (before) `Semantics::file_to_module_def(&self, file: FileId) -> Option<Module>` (after) `Semantics::to_module_defs(&self, file: FileId) -> impl Iterator<Item = Module>` (before) `Semantics::file_to_module_defs(&self, file: FileId) -> impl Iterator<Item = Module>` (after) (the PR is motivated by an outside use of the `ra_ap_hir` crate that would benefit from being able to walk a `hir::Function`'s AST, resolving its exprs/stmts/items to their HIR equivalents)

Avoid some allocations I went on a small `.clone()` hunting tour :D

internal: Clean some stuff up Just a bunch of small refactorings, mainly from browsing through `hir-def`

…m-ra

rustbot · 2024-03-10T06:49:03Z

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

lnicola · 2024-03-10T06:49:09Z

@bors r+ p=1 subtree sync

bors · 2024-03-10T06:49:11Z

📌 Commit 56493e4 has been approved by lnicola

It is now in the queue for this repository.

matthiaskrgr · 2024-03-10T06:57:57Z

@bors r-

lnicola · 2024-03-10T09:42:12Z

@bors r+

bors · 2024-03-10T09:42:15Z

📌 Commit b4e3b2e has been approved by lnicola

It is now in the queue for this repository.

Subtree update of `rust-analyzer` r? ghost

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#121573 (unix_sigpipe: Add test for SIGPIPE disposition in child processes) - rust-lang#121754 ([bootstrap] Move the `split-debuginfo` setting to the per-target section) - rust-lang#122205 (ensure that sysroot is properly set for cross-targets) - rust-lang#122257 (mir-opt tests: don't run a different set on --bless; enable --keep-stage-std) - rust-lang#122272 (Subtree update of `rust-analyzer`) Failed merges: - rust-lang#122108 (Add `target.*.runner` configuration for targets) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-03-10T14:29:08Z

⌛ Testing commit b4e3b2e with merge 9bd88ef...

bors · 2024-03-10T16:25:11Z

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 9bd88ef to master...

rust-timer · 2024-03-10T20:08:50Z

Finished benchmarking commit (9bd88ef): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[1.3%, 4.2%]	13
Improvements ✅ (primary)	-1.0%	[-1.0%, -1.0%]	1
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-1.0%	[-1.0%, -1.0%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 648.121s -> 646.803s (-0.20%)
Artifact size: 309.99 MiB -> 309.98 MiB (-0.00%)

Young-Flash and others added 30 commits February 21, 2024 10:57

feat: add hover display for trait assoc items

dba1675

rebase on lastest master

00358b1

add config item for hover display

35ec595

add HoverDisplayConfig

2e87f31

internal: simplify the process of inserting spaces after mut

ce4ae41

fix: use 4 spaces for indentation in macro expansion

4896626

test: use 4 spaces for indetation in macro expansion

ec5236f

fix: clippy and format

76b86b2

Add prefix file_ to Semantics's to_module_defs()/`to_module_def…

6112ddf

…()` methods

Add a more methods for resolving definitions from AST to their corres…

fac8a14

…ponding HIR types

internal: Move ide-assists codegen tests into an xtask codegen command

03b02e6

Add basic support for Native Debug

a01e4f8

Take a reference instead of cloning

06a883e

Only clone when required

748f57c

Remove unneeded to_owned

4aab2d5

Convert directly into an Arc<str>

9df73c6

Avoid cloning deps

00a049b

fix: autocomplete constants inside format strings

1d28aec

update for review

dba67b4

Update rustc_pattern_analysis

7c6f7b2

Auto merge of rust-lang#16738 - Nadrieril:update-pat-ana, r=lnicola

67f7557

Update rustc_pattern_analysis This should fix rust-lang/rust-analyzer#16656 but I can't check because we don't have a reproducer.

Merge branch 'master' into sync-from-rust

9fafbfa

Auto merge of rust-lang#16740 - lnicola:sync-from-rust, r=lnicola

037924c

internal: sync from downstream

Auto merge of rust-lang#16719 - lnicola:native-debug, r=lnicola

d444acd

fix: Add basic support for Native Debug Native Debug doesn't work very well and passing command-line arguments is nasty (rust-lang/rust-analyzer#9815), but I guess it's a start. Closes rust-lang#9815

Auto merge of rust-lang#16722 - mo8it:allocations, r=Veykril

2074cc2

Avoid some allocations I went on a small `.clone()` hunting tour :D

Cleanup

4303e74

Auto merge of rust-lang#16747 - Veykril:cleanup, r=Veykril

99a1b8f

internal: Clean some stuff up Just a bunch of small refactorings, mainly from browsing through `hir-def`

Merge commit '574e23ec508064613783cba3d1833a95fd9a5080' into sync-fro…

56493e4

…m-ra

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 10, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2024

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 10, 2024

This comment has been minimized.

Sign in to view

Bring back in-rust-tree feature to ide

b4e3b2e

lnicola force-pushed the sync-from-ra branch from 6820d55 to b4e3b2e Compare March 10, 2024 09:08

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 10, 2024

matthiaskrgr mentioned this pull request Mar 10, 2024

Rollup of 5 pull requests #122289

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2024

Rollup merge of rust-lang#122272 - lnicola:sync-from-ra, r=lnicola

3aa6594

Subtree update of `rust-analyzer` r? ghost

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 10, 2024

bors merged commit 9bd88ef into rust-lang:master Mar 10, 2024
12 checks passed

rustbot added this to the 1.78.0 milestone Mar 10, 2024

lnicola deleted the sync-from-ra branch March 10, 2024 16:59

mu001999 mentioned this pull request Mar 11, 2024

Detect unused struct impls pub trait #121752

Merged

davidbarsky mentioned this pull request Mar 14, 2024

rust-analyser hangs at "Fetching", and uses CPU at 100% rust-lang/rust-analyzer#16614

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subtree update of `rust-analyzer` #122272

Subtree update of `rust-analyzer` #122272

lnicola commented Mar 10, 2024

rustbot commented Mar 10, 2024

lnicola commented Mar 10, 2024

bors commented Mar 10, 2024

This comment has been minimized.

matthiaskrgr commented Mar 10, 2024

This comment has been minimized.

lnicola commented Mar 10, 2024

bors commented Mar 10, 2024

bors commented Mar 10, 2024

bors commented Mar 10, 2024

rust-timer commented Mar 10, 2024

Subtree update of rust-analyzer #122272

Subtree update of rust-analyzer #122272

Conversation

lnicola commented Mar 10, 2024

rustbot commented Mar 10, 2024

lnicola commented Mar 10, 2024

bors commented Mar 10, 2024

This comment has been minimized.

matthiaskrgr commented Mar 10, 2024

This comment has been minimized.

lnicola commented Mar 10, 2024

bors commented Mar 10, 2024

bors commented Mar 10, 2024

bors commented Mar 10, 2024

rust-timer commented Mar 10, 2024

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Subtree update of `rust-analyzer` #122272

Subtree update of `rust-analyzer` #122272