Rollup of 9 pull requests #123036
Merged
Rollup of 9 pull requests #123036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user never gave an explicit name
…d: Leaf(0x0000000000000000) }]) is not fully resolved rust-lang#113045 Fixes rust-lang#113045
…sued, expected ReFree to map to ReEarlyBound rust-lang#108580 Fixes rust-lang#108580
…ype, None in compiler/rustc_mir_build/src/build/expr/as_place.rs rust-lang#110453 Fixes rust-lang#110453
…with default method and no impls Fixes rust-lang#109869
Rustc gives a warning when compiling proc macros with panic=abort.
…ister Don't emit an error about failing to produce a file with a specific name if user never gave an explicit name Fixes rust-lang#122509 You can ask `rustc` to produce some intermediate results with `--emit foo`, this operation comes in two flavors: `--emit asm` and `--emit asm=foo.s`. First one produces one or more `.s` files without any name guarantees, second one renames it into `foo.s`. Second version only works when compiler produces a single file - for asm files this means using a single compilation unit for example. In case compilation produced more than a single file `rustc` runs following check to emit some warnings: ```rust if crate_output.outputs.contains_key(&output_type) { // 2) Multiple codegen units, with `--emit foo=some_name`. We have // no good solution for this case, so warn the user. sess.dcx().emit_warn(errors::IgnoringEmitPath { extension }); } else if crate_output.single_output_file.is_some() { // 3) Multiple codegen units, with `-o some_name`. We have // no good solution for this case, so warn the user. sess.dcx().emit_warn(errors::IgnoringOutput { extension }); } else { // 4) Multiple codegen units, but no explicit name. We // just leave the `foo.0.x` files in place. // (We don't have to do any work in this case.) } ``` Comment in the final `else` branch implies that if user didn't ask for a specific name - there's no need to emit warnings. However because of the internal representation of `crate_output.outputs` - this doesn't work as expected: if user asked to produce an asm file without giving it an implicit name it will contain `Some(None)`. To fix the problem new code actually checks if user gave an explicit name. I think this was an original intentional behavior, at least comments imply that.
…trochenkov Delegation: fix ICE on `bound_vars` divergence Fixes rust-lang#122550. Bug was caused by divergence between lowered type and corresponding `bound_vars` in `late_bound_vars_map`. In this patch `bound_vars` calculation for delegation item is moved from `lower_fn_ty` to `resolve_bound_vars` query. r? `@petrochenkov`
…h-pat-only, r=petrochenkov Validate that we're only matching on unit struct for path pattern Resolution doesn't validate that we only really take `CtorKind::Unit` in path patterns, since all it sees is `Res::SelfCtor(def_id)`. Check this instead during pattern typeck. r? petrochenkov Fixes rust-lang#122809
…acrum Use `chunk_by` when building `ReverseSccGraph` With stable `chunk_by` in Rust 1.77, this code doesn't need `Itertools::group_by` anymore.
add even more tests! Fixes rust-lang#109869 Fixes rust-lang#110453 Fixes rust-lang#109020 Fixes rust-lang#108580 Fixes rust-lang#108220 Fixes rust-lang#113045 Fixes rust-lang#113133 Fixes rust-lang#114464 Fixes rust-lang#116599 Fixes rust-lang#119731
…t, r=petrochenkov Fix unpretty UI test when /tmp does not exist On Windows this test fails if e.g. `C:\tmp` is created successfully
Rename `{enter,exit}_lint_attrs` to `check_attributes{,_post}`
Several places in Clippy want to check all the attributes of a node, we end up using `hir().attrs()` from several different `check_` functions (e.g. [in our doc lints](https://github.com/rust-lang/rust-clippy/blob/95c62ffae9bbce793f68a6f1473e3fc24af19bdd/clippy_lints/src/doc/mod.rs#L396)) but this is error prone, we recently found that doc lints weren't triggering on struct fields for example
I went to add a `check_attributes` function but realised `enter_lint_attrs` is already this, the rename is to encourage their use
Also removes `LateContextAndPass::visit_attribute` since it's unused - `visit_attribute` for HIR visitors is only called by `hir().walk_attributes()` which lint passes do not use
…losure, r=bjorn3 Add `async-closures/once.rs` back to cranelift tests This was fixed afaict by rust-lang#120717 r? `@bjorn3`
…rors Add a bunch of needs-unwind annotations to tests To filter out tests that fail with cg_clif due to missing panic=unwind support.
rustbot
added
the
A-testsuite
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=9 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: cb7c63606e In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (60b5ca6): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 670.74s -> 671.366s (0.09%) |
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
bound_varsdivergence #122881 (Delegation: fix ICE onbound_varsdivergence)chunk_bywhen buildingReverseSccGraph#122970 (Usechunk_bywhen buildingReverseSccGraph){enter,exit}_lint_attrstocheck_attributes{,_post}#123001 (Rename{enter,exit}_lint_attrstocheck_attributes{,_post})async-closures/once.rsback to cranelift tests #123022 (Addasync-closures/once.rsback to cranelift tests)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup