Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #123036

Merged
merged 29 commits into from
Mar 25, 2024
Merged

Rollup of 9 pull requests #123036

merged 29 commits into from
Mar 25, 2024

Commits on Mar 22, 2024

  1. Configuration menu
    Copy the full SHA
    d1ba632 View commit details
    Browse the repository at this point in the history
  2. Don't emit an error about failing to produce a file with a specific name

    If user never gave an explicit name
    pacak committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    bf12aa4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b84326e View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Configuration menu
    Copy the full SHA
    08235b1 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. Configuration menu
    Copy the full SHA
    87808e7 View commit details
    Browse the repository at this point in the history
  2. 1 Configuration menu
    Copy the full SHA
    127c36c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    db68dc2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8ed5e67 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cdea6d8 View commit details
    Browse the repository at this point in the history
  6. add test for ICE: min_specialization: Ok(['?0, Const { ty: usize, kin…

    …d: Leaf(0x0000000000000000) }]) is not fully resolved rust-lang#113045
    
    Fixes rust-lang#113045
    matthiaskrgr committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    b151e06 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6203ebe View commit details
    Browse the repository at this point in the history
  8. add test for ICE: no errors encountered even though delay_span_bug is…

    …sued, expected ReFree to map to ReEarlyBound rust-lang#108580
    
    Fixes rust-lang#108580
    matthiaskrgr committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    5e0d8c3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    56ea366 View commit details
    Browse the repository at this point in the history
  10. add tests for ICE in mir building with captured value of unresolved t…

    …ype, None in compiler/rustc_mir_build/src/build/expr/as_place.rs rust-lang#110453
    
    Fixes rust-lang#110453
    matthiaskrgr committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    e800b99 View commit details
    Browse the repository at this point in the history
  11. add tests for ICE: 'broken MIR: bad assignment: NoSolution' on trait …

    …with default method and no impls
    
    Fixes rust-lang#109869
    matthiaskrgr committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    e4d816e View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    4719293 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2cb5347 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    e6918b1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3733dcc View commit details
    Browse the repository at this point in the history
  3. Add needs-unwind for proc macro tests

    Rustc gives a warning when compiling proc macros with panic=abort.
    bjorn3 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    5f5dcae View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#122842 - pacak:explicit_name, r=michaelwoer…

    …ister
    
    Don't emit an error about failing to produce a file with a specific name if user never gave an explicit name
    
    Fixes rust-lang#122509
    
    You can ask `rustc` to produce some intermediate results with `--emit foo`, this operation comes in two flavors: `--emit asm` and `--emit asm=foo.s`. First one produces one or more `.s` files without any name guarantees, second one renames it into `foo.s`. Second version only works when compiler produces a single file - for asm files this means using a single compilation unit for example.
    
    In case compilation produced more than a single file `rustc` runs following check to emit some warnings:
    
    ```rust
                if crate_output.outputs.contains_key(&output_type) {
                    // 2) Multiple codegen units, with `--emit foo=some_name`. We have
                    //    no good solution for this case, so warn the user.
                    sess.dcx().emit_warn(errors::IgnoringEmitPath { extension });
                } else if crate_output.single_output_file.is_some() {
                    // 3) Multiple codegen units, with `-o some_name`. We have
                    //    no good solution for this case, so warn the user.
                    sess.dcx().emit_warn(errors::IgnoringOutput { extension });
                } else {
                    // 4) Multiple codegen units, but no explicit name. We
                    //    just leave the `foo.0.x` files in place.
                    // (We don't have to do any work in this case.)
                }
    ```
    
    Comment in the final `else` branch implies that if user didn't ask for a specific name - there's no need to emit warnings. However because of the internal representation of `crate_output.outputs` - this doesn't work as expected: if user asked to produce an asm file without giving it an implicit name it will contain `Some(None)`.
    
    To fix the problem new code actually checks if user gave an explicit name. I think this was an original intentional behavior, at least comments imply that.
    matthiaskrgr authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    ded16b3 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#122881 - Bryanskiy:delegation-fixes-2, r=pe…

    …trochenkov
    
    Delegation: fix ICE on `bound_vars` divergence
    
    Fixes rust-lang#122550.
    
    Bug was caused by divergence  between lowered type and corresponding `bound_vars` in `late_bound_vars_map`. In this patch `bound_vars` calculation for delegation item is moved from `lower_fn_ty` to `resolve_bound_vars` query.
    
    r? `@petrochenkov`
    matthiaskrgr authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    ccc5310 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#122910 - compiler-errors:unit-struct-in-pat…

    …h-pat-only, r=petrochenkov
    
    Validate that we're only matching on unit struct for path pattern
    
    Resolution doesn't validate that we only really take `CtorKind::Unit` in path patterns, since all it sees is `Res::SelfCtor(def_id)`. Check this instead during pattern typeck.
    
    r? petrochenkov
    
    Fixes rust-lang#122809
    matthiaskrgr authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e9ec442 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#122970 - cuviper:use-chunk_by, r=Mark-Simul…

    …acrum
    
    Use `chunk_by` when building `ReverseSccGraph`
    
    With stable `chunk_by` in Rust 1.77, this code doesn't need `Itertools::group_by` anymore.
    matthiaskrgr authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    9b4ee1b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    877f293 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#122999 - Alexendoo:unpretty-avoid-crash-tes…

    …t, r=petrochenkov
    
    Fix unpretty UI test when /tmp does not exist
    
    On Windows this test fails if e.g. `C:\tmp` is created successfully
    matthiaskrgr authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    657dd0b View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#123001 - Alexendoo:check-attributes, r=oli-obk

    Rename `{enter,exit}_lint_attrs` to `check_attributes{,_post}`
    
    Several places in Clippy want to check all the attributes of a node, we end up using `hir().attrs()` from several different `check_` functions (e.g. [in our doc lints](https://github.com/rust-lang/rust-clippy/blob/95c62ffae9bbce793f68a6f1473e3fc24af19bdd/clippy_lints/src/doc/mod.rs#L396)) but this is error prone, we recently found that doc lints weren't triggering on struct fields for example
    
    I went to add a `check_attributes` function but realised `enter_lint_attrs` is already this, the rename is to encourage their use
    
    Also removes `LateContextAndPass::visit_attribute` since it's unused - `visit_attribute` for HIR visitors is only called by `hir().walk_attributes()` which lint passes do not use
    matthiaskrgr authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    10daf8a View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#123022 - compiler-errors:clif-tests-async-c…

    …losure, r=bjorn3
    
    Add `async-closures/once.rs` back to cranelift tests
    
    This was fixed afaict by rust-lang#120717
    
    r? `@bjorn3`
    matthiaskrgr authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    11f168f View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#123034 - bjorn3:test_ignores, r=compiler-er…

    …rors
    
    Add a bunch of needs-unwind annotations to tests
    
    To filter out tests that fail with cg_clif due to missing panic=unwind support.
    matthiaskrgr authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    4369718 View commit details
    Browse the repository at this point in the history