Rollup of 7 pull requests #123725

GuillaumeGomez · 2024-04-10T14:15:26Z

Successful merges:

Add REDUNDANT_LIFETIMES lint to detect lifetimes which are semantically redundant #118391 (Add REDUNDANT_LIFETIMES lint to detect lifetimes which are semantically redundant)
Windows: set main thread name without re-encoding #123534 (Windows: set main thread name without re-encoding)
Add support to intrinsics fallback body #123659 (Add support to intrinsics fallback body)
Add const generics support for pattern types #123689 (Add const generics support for pattern types)
Only assert for child/parent projection compatibility AFTER checking that theyre coming from the same place #123701 (Only assert for child/parent projection compatibility AFTER checking that theyre coming from the same place)
Further cleanup cfgs in the UI test suite #123702 (Further cleanup cfgs in the UI test suite)
rustdoc: reduce per-page HTML overhead #123706 (rustdoc: reduce per-page HTML overhead)

r? @ghost
@rustbot modify labels: rollup

Before this fix, the call to `body()` would crash, since `has_body()` would return true, but we would try to retrieve the body of an intrinsic which is not allowed. Instead, the `Instance::body()` function will now convert an Intrinsic into an Item before retrieving its body.

`wide_str!` creates a null terminated UTF-16 string whereas `utf16!` just creates a UTF-16 string without adding a null.

This commit does three things: 1. replaces (the last remaining) never true cfgs by the FALSE cfg 2. fix derive-helper-configured.rs (typo in directive) 3. and comment some current unused #[cfg_attr] (missing revisions)

This cuts the HTML overhead for a page by about 1KiB, significantly reducing the overall size of the docs bundle.

According to <https://caniuse.com/?search=svg%20favicon>, SVG favicons are supported in everything but Safari. When I actually try it in Safari, it's downloading all three favicons, and nothing looks different when I disable the 16x16 one. <https://dev.to/masakudamatsu/favicon-nightmare-how-to-maintain-sanity-3al7>, which is linked from caniuse above, recommends an ico. However, the reason they recommend it is the apps that only support /favicon.ico exactly, and rustdoc can't assume it will be installed to the site root, so it's unfortunately up to the webmaster to make sure it's set up.

…that theyre coming from the same place

Add `REDUNDANT_LIFETIMES` lint to detect lifetimes which are semantically redundant There already is a `UNUSED_LIFETIMES` lint which is fired when we detect where clause bounds like `where 'a: 'static`, however, it doesn't use the full power of lexical region resolution to detect failures. Right now `UNUSED_LIFETIMES` is an `Allow` lint, though presumably we could bump it to warn? I can (somewhat) easily implement a structured suggestion so this can be rustfix'd automatically, since we can just walk through the HIR body, replacing instances of the redundant lifetime. Fixes rust-lang#118376 r? lcnr

Windows: set main thread name without re-encoding As a minor optimization, we can skip the runtime UTF-8 to UTF-16 conversion.

…-obk Add support to intrinsics fallback body Before this fix, the call to `body()` would crash, since `has_body()` would return true, but we would try to retrieve the body of an intrinsic which is not allowed. Instead, the `Instance::body()` function will now convert an Intrinsic into an Item before retrieving its body. Note: I also changed how we monomorphize the instance body. Unfortunately, the call still ICE for some shims. r? `@oli-obk`

…erics, r=oli-obk Add const generics support for pattern types r? `@oli-obk`

…checking, r=WaffleLapkin Only assert for child/parent projection compatibility AFTER checking that theyre coming from the same place This assertion doesn't make sense until we check that these captures are actually equivalent. Fixes rust-lang#123697 <sub>Some days I wonder how I even write code that works...</sub>

…eck-cfg-2, r=jieyouxu Further cleanup cfgs in the UI test suite This PR does more cleanup of cfgs in our UI test suite, in preparation for adding automatic always on check-cfg (but is IMO worth landing even without that follow up). To be more specific this PR: - replaces (the last remaining) never true cfgs by the `FALSE` cfg - fix `proc-macro/derive-helper-configured.rs` *(typo in directive)* - and comment some current unused `#[cfg_attr]` *(missing revisions)* Follow-up to rust-lang#123577.

…r=GuillaumeGomez rustdoc: reduce per-page HTML overhead r? `@GuillaumeGomez`

GuillaumeGomez · 2024-04-10T14:15:36Z

@bors r+ p=5 rollup=never

bors · 2024-04-10T14:15:38Z

📌 Commit 96628f4 has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2024-04-10T14:28:56Z

⌛ Testing commit 96628f4 with merge 5974fe8...

bors · 2024-04-10T16:31:34Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 5974fe8 to master...

bors · 2024-04-10T16:31:34Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 5974fe8 to master...

rust-timer · 2024-04-10T16:33:32Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#118391	Add `REDUNDANT_LIFETIMES` lint to detect lifetimes which ar…	`fc1fbd71580f22f62861d5f1400c3afec12a845b` (link)
#123534	Windows: set main thread name without re-encoding	`585f0e718f00dd021b53ab608df79ce1def94b56` (link)
#123659	Add support to intrinsics fallback body	`8260255d65feae6c36fca696a96e81c4d40eb123` (link)
#123689	Add const generics support for pattern types	`e026c18bc47b56820e6a46605d3be206538e90dc` (link)
#123701	Only assert for child/parent projection compatibility AFTER…	`8e43695bd471980baa9435a5fa7f61d00e8383cb` (link)
#123702	Further cleanup cfgs in the UI test suite	`010b52de3bb0ce874f045c6d2d1c35bd52f198c3` (link)
#123706	rustdoc: reduce per-page HTML overhead	`8843443cb17b69da0ce9784b77b3105dd6b29cb9` (link)

previous master: e908cfd125

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-04-10T19:15:17Z

Finished benchmarking commit (5974fe8): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	2
Regressions ❌ (secondary)	0.9%	[0.2%, 2.6%]	7
Improvements ✅ (primary)	-0.4%	[-0.6%, -0.2%]	2
Improvements ✅ (secondary)	-0.6%	[-0.6%, -0.6%]	1
All ❌✅ (primary)	-0.1%	[-0.6%, 0.2%]	4

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.464s -> 675.526s (0.46%)
Artifact size: 318.41 MiB -> 318.49 MiB (0.03%)

Kobzol · 2024-04-16T07:42:15Z

The two largest regressions were noise. The rest is small enough that I don't think we need to delve into this further.

@rustbot label: +perf-regression-triaged

celinval and others added 29 commits April 8, 2024 17:07

Add redundant_lifetime_args lint

03c901f

Actually, just reuse the UNUSED_LIFETIMES lint

8940949

Add comments

535151e

Fix stage 2

ceff692

Move check to wfcheck

2d81354

Lint redundant lifetimes in impl header

ee78eab

Split back out unused_lifetimes -> redundant_lifetimes

a9e262a

Clarifying comment

da2b714

Add const generics failing test for pattern types

a2bdb99

rustdoc: clean up type alias code

5f84f4b

Handle const generic pattern types

30c546a

Add const UTF-8 to UTF-16 conversion macros

b48e7e5

`wide_str!` creates a null terminated UTF-16 string whereas `utf16!` just creates a UTF-16 string without adding a null.

Windows: set main thread name without reencoding

952d432

Add comment on UTF-16 surrogates

19f04a7

Further cleanup cfgs in the UI test suite

0c3f5cc

This commit does three things: 1. replaces (the last remaining) never true cfgs by the FALSE cfg 2. fix derive-helper-configured.rs (typo in directive) 3. and comment some current unused #[cfg_attr] (missing revisions)

rustdoc: reduce size of <head> with preload loop

dac788f

rustdoc: load icons from css instead of inline

13235dc

This cuts the HTML overhead for a page by about 1KiB, significantly reducing the overall size of the docs bundle.

rustdoc: update test cases

3a007db

Only avoid anon consts during instantiation

1cbe927

Only assert for child/parent projection compatibility AFTER checking …

69b690f

…that theyre coming from the same place

Rollup merge of rust-lang#123534 - ChrisDenton:name, r=workingjubilee

38af5f9

Windows: set main thread name without re-encoding As a minor optimization, we can skip the runtime UTF-8 to UTF-16 conversion.

Rollup merge of rust-lang#123689 - spastorino:pattern_types_const_gen…

3f7ae68

…erics, r=oli-obk Add const generics support for pattern types r? `@oli-obk`

Rollup merge of rust-lang#123706 - notriddle:notriddle/html-cleanup, …

96628f4

…r=GuillaumeGomez rustdoc: reduce per-page HTML overhead r? `@GuillaumeGomez`

rustbot added the O-windows Operating system: Windows label Apr 10, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 10, 2024

bors merged commit 5974fe8 into rust-lang:master Apr 10, 2024
12 checks passed

rustbot added this to the 1.79.0 milestone Apr 10, 2024

bors mentioned this pull request Apr 10, 2024

rustdoc: add three-column layout for large desktops #120818

Open

GuillaumeGomez deleted the rollup-gk2bbrg branch April 10, 2024 17:03

This was referenced Apr 10, 2024

[rustdoc] Detect and resolve ambiguities in fn parameters type names #122872

Closed

Make the computation of coroutine_captures_by_ref_ty more sophisticated #123660

Merged

rustbot added the perf-regression Performance regression. label Apr 10, 2024

rustbot added the perf-regression-triaged The performance regression has been triaged. label Apr 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 7 pull requests #123725

Rollup of 7 pull requests #123725

GuillaumeGomez commented Apr 10, 2024

GuillaumeGomez commented Apr 10, 2024

bors commented Apr 10, 2024

bors commented Apr 10, 2024

bors commented Apr 10, 2024

bors commented Apr 10, 2024

rust-timer commented Apr 10, 2024

rust-timer commented Apr 10, 2024

Kobzol commented Apr 16, 2024

Rollup of 7 pull requests #123725

Rollup of 7 pull requests #123725

Conversation

GuillaumeGomez commented Apr 10, 2024

GuillaumeGomez commented Apr 10, 2024

bors commented Apr 10, 2024

bors commented Apr 10, 2024

bors commented Apr 10, 2024

bors commented Apr 10, 2024

rust-timer commented Apr 10, 2024

rust-timer commented Apr 10, 2024

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Kobzol commented Apr 16, 2024