Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #123725

Merged
merged 29 commits into from
Apr 10, 2024
Merged

Rollup of 7 pull requests #123725

merged 29 commits into from
Apr 10, 2024

Commits on Apr 9, 2024

  1. Add support to intrinsics fallback body

    Before this fix, the call to `body()` would crash, since `has_body()`
    would return true, but we would try to retrieve the body of an intrinsic
    which is not allowed.
    
    Instead, the `Instance::body()` function will now convert an Intrinsic
    into an Item before retrieving its body.
    celinval committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    1512d06 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    03c901f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8940949 View commit details
    Browse the repository at this point in the history
  4. Add comments

    compiler-errors committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    535151e View commit details
    Browse the repository at this point in the history
  5. Fix stage 2

    compiler-errors committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    ceff692 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2d81354 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ee78eab View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a9e262a View commit details
    Browse the repository at this point in the history
  9. Clarifying comment

    compiler-errors committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    da2b714 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a2bdb99 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    5f84f4b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    30c546a View commit details
    Browse the repository at this point in the history
  13. Add const UTF-8 to UTF-16 conversion macros

    `wide_str!` creates a null terminated UTF-16 string whereas `utf16!` just creates a UTF-16 string without adding a null.
    ChrisDenton committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    b48e7e5 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    952d432 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    19f04a7 View commit details
    Browse the repository at this point in the history
  16. Further cleanup cfgs in the UI test suite

    This commit does three things:
     1. replaces (the last remaining) never true cfgs by the FALSE cfg
     2. fix derive-helper-configured.rs (typo in directive)
     3. and comment some current unused #[cfg_attr] (missing revisions)
    Urgau committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    0c3f5cc View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    dac788f View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. rustdoc: load icons from css instead of inline

    This cuts the HTML overhead for a page by about 1KiB,
    significantly reducing the overall size of the docs bundle.
    notriddle committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    13235dc View commit details
    Browse the repository at this point in the history
  2. rustdoc: remove unused 16x16 favicon

    According to <https://caniuse.com/?search=svg%20favicon>,
    SVG favicons are supported in everything but Safari.
    
    When I actually try it in Safari, it's downloading all
    three favicons, and nothing looks different when I disable
    the 16x16 one.
    
    <https://dev.to/masakudamatsu/favicon-nightmare-how-to-maintain-sanity-3al7>,
    which is linked from caniuse above, recommends an ico.
    However, the reason they recommend it is the apps that
    only support /favicon.ico exactly, and rustdoc can't assume
    it will be installed to the site root, so it's unfortunately
    up to the webmaster to make sure it's set up.
    notriddle committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    87faa21 View commit details
    Browse the repository at this point in the history
  3. rustdoc: update test cases

    notriddle committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    3a007db View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1cbe927 View commit details
    Browse the repository at this point in the history
  5. Only assert for child/parent projection compatibility AFTER checking …

    …that theyre coming from the same place
    compiler-errors committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    69b690f View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#118391 - compiler-errors:lifetimes-eq, r=lcnr

    Add `REDUNDANT_LIFETIMES` lint to detect lifetimes which are semantically redundant
    
    There already is a `UNUSED_LIFETIMES` lint which is fired when we detect where clause bounds like `where 'a: 'static`, however, it doesn't use the full power of lexical region resolution to detect failures.
    
    Right now `UNUSED_LIFETIMES` is an `Allow` lint, though presumably we could bump it to warn? I can (somewhat) easily implement a structured suggestion so this can be rustfix'd automatically, since we can just walk through the HIR body, replacing instances of the redundant lifetime.
    
    Fixes rust-lang#118376
    r? lcnr
    GuillaumeGomez authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    fa696a3 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#123534 - ChrisDenton:name, r=workingjubilee

    Windows: set main thread name without re-encoding
    
    As a minor optimization, we can skip the runtime UTF-8 to UTF-16 conversion.
    GuillaumeGomez authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    38af5f9 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#123659 - celinval:smir-fix-intrinsic, r=oli…

    …-obk
    
    Add support to intrinsics fallback body
    
    Before this fix, the call to `body()` would crash, since `has_body()` would return true, but we would try to retrieve the body of an intrinsic which is not allowed.
    
    Instead, the `Instance::body()` function will now convert an Intrinsic into an Item before retrieving its body.
    
    Note: I also changed how we monomorphize the instance body. Unfortunately, the call still ICE for some shims.
    
    r? `@oli-obk`
    GuillaumeGomez authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2b4c581 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#123689 - spastorino:pattern_types_const_gen…

    …erics, r=oli-obk
    
    Add const generics support for pattern types
    
    r? `@oli-obk`
    GuillaumeGomez authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    3f7ae68 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#123701 - compiler-errors:only-assert-after-…

    …checking, r=WaffleLapkin
    
    Only assert for child/parent projection compatibility AFTER checking that theyre coming from the same place
    
    This assertion doesn't make sense until we check that these captures are actually equivalent.
    
    Fixes rust-lang#123697
    
    <sub>Some days I wonder how I even write code that works...</sub>
    GuillaumeGomez authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1002c65 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#123702 - Urgau:prep-work-for-compiletest-ch…

    …eck-cfg-2, r=jieyouxu
    
    Further cleanup cfgs in the UI test suite
    
    This PR does more cleanup of cfgs in our UI test suite, in preparation for adding automatic always on check-cfg (but is IMO worth landing even without that follow up).
    
    To be more specific this PR:
     - replaces (the last remaining) never true cfgs by the `FALSE` cfg
     - fix `proc-macro/derive-helper-configured.rs` *(typo in directive)*
     - and comment some current unused `#[cfg_attr]` *(missing revisions)*
    
    Follow-up to rust-lang#123577.
    GuillaumeGomez authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    7a29d39 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#123706 - notriddle:notriddle/html-cleanup, …

    …r=GuillaumeGomez
    
    rustdoc: reduce per-page HTML overhead
    
    r? `@GuillaumeGomez`
    GuillaumeGomez authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    96628f4 View commit details
    Browse the repository at this point in the history