linker: Remove laziness and caching from native search directory walks

[petrochenkov]

It shouldn't be necessary for performance now.

Follow up to #123827.

[rustbot]

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[petrochenkov]

@bors try @rust-timer queue

[bors]

⌛ Trying commit ed62b57 with merge 06bbc9f...

[lqd]

good cleanup, r=me if perf comes back clean

[bors]

☀️ Try build successful - checks-actions
Build commit: 06bbc9f (06bbc9fae04d9d7b5089f56c0aa435a1eb8ef20b)

[rust-timer]

Finished benchmarking commit (06bbc9f): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.5%	[-3.5%, -3.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.5%	[-3.5%, -3.5%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.5%, 2.3%]	3
Regressions ❌ (secondary)	2.8%	[2.1%, 3.7%]	14
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.9%	[1.5%, 2.3%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 677.095s -> 676.162s (-0.14%)
Artifact size: 316.00 MiB -> 315.98 MiB (-0.00%)

[petrochenkov]

@bors r=lqd rollup=maybe

[bors]

📌 Commit ed62b57 has been approved by lqd

It is now in the queue for this repository.

[bors]

⌛ Testing commit ed62b57 with merge 3a0db6c...

[bors]

☀️ Test successful - checks-actions
Approved by: lqd
Pushing 3a0db6c to master...

[rust-timer]

Finished benchmarking commit (3a0db6c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-5.0%	[-5.0%, -5.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-5.0%	[-5.0%, -5.0%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 677.551s -> 674.888s (-0.39%)
Artifact size: 316.04 MiB -> 316.04 MiB (-0.00%)