Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linker: Avoid some allocations in search directory iteration #123827

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

petrochenkov
Copy link
Contributor

This is more a cleanup than actual optimization.

@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2024

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 11, 2024
@Nadrieril
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 11, 2024

📌 Commit 4ded0b8 has been approved by Nadrieril

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#123599 (remove some things that do not need to be)
 - rust-lang#123763 (Set the host library path in run-make v2)
 - rust-lang#123775 (Make `PlaceRef` and `OperandValue::Ref` share a common `PlaceValue` type)
 - rust-lang#123789 (move QueryKeyStringCache from rustc_middle to rustc_query_impl, where it actually used)
 - rust-lang#123826 (Move rare overflow error to a cold function)
 - rust-lang#123827 (linker: Avoid some allocations in search directory iteration)
 - rust-lang#123829 (Fix revisions syntax in cfg(ub_checks) test)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7f11183 into rust-lang:master Apr 12, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 12, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2024
Rollup merge of rust-lang#123827 - petrochenkov:searchdirs, r=Nadrieril

linker: Avoid some allocations in search directory iteration

This is more a cleanup than actual optimization.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2024
linker: Remove laziness and caching from native search directory walks

It shouldn't be necessary for performance now.

Follow up to rust-lang#123827.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 13, 2024
linker: Remove laziness and caching from native search directory walks

It shouldn't be necessary for performance now.

Follow up to rust-lang#123827.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants