remove some things that do not need to be #123599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiaskrgr
added
the
C-cleanup
rustbot
added
A-query-system
|
HIR ty lowering was modified cc @fmease |
jieyouxu
reviewed
Apr 7, 2024
Comment on lines
501
to
504
| let file_note = file.as_ref().map(|file| format!( | ||
| "the full trait has been written to '{}'", | ||
| file.display(), | ||
| )); |
There was a problem hiding this comment.
Hmm, do we lose a diagnostic for where the trait has been written to if we remove this?
There was a problem hiding this comment.
aaaah I'll double check.
It looks like we don't have any tests here actually.
|
@rustbot author |
rustbot
added
S-waiting-on-author
jieyouxu
reviewed
Apr 7, 2024
| @@ -625,7 +621,6 @@ impl<'tcx> TypeErrCtxt<'_, 'tcx> { | |||
| return err.emit(); | |||
| } | |||
|
|
|||
| file_note.map(|note| err.note(note)); | |||
There was a problem hiding this comment.
Also here, I think we might lose a file note here
matthiaskrgr
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#123599 (remove some things that do not need to be) - rust-lang#123763 (Set the host library path in run-make v2) - rust-lang#123775 (Make `PlaceRef` and `OperandValue::Ref` share a common `PlaceValue` type) - rust-lang#123789 (move QueryKeyStringCache from rustc_middle to rustc_query_impl, where it actually used) - rust-lang#123826 (Move rare overflow error to a cold function) - rust-lang#123827 (linker: Avoid some allocations in search directory iteration) - rust-lang#123829 (Fix revisions syntax in cfg(ub_checks) test) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2024
Rollup merge of rust-lang#123599 - matthiaskrgr:rm, r=cjgillot remove some things that do not need to be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.