Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #125938

Closed
wants to merge 25 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

pacak and others added 25 commits April 19, 2024 08:31
Signed-off-by: Andrew Wock <ajwock@gmail.com>
Show files produced by `--emit foo` in json artifact notifications

Right now it is possible to ask `rustc` to save some intermediate representation into one or more files with `--emit=foo`, but figuring out what exactly was produced is difficult. This pull request adds information about `llvm_ir` and `asm` intermediate files into notifications produced by `--json=artifacts`.

Related discussion: https://internals.rust-lang.org/t/easier-access-to-files-generated-by-emit-foo/20477

Motivation - `cargo-show-asm` parses those intermediate files and presents them in a user friendly way, but right now I have to apply some dirty hacks. Hacks make behavior confusing: hintron/computer-enhance#35

This pull request introduces a new behavior: now `rustc` will emit a new artifact notification for every artifact type user asked to `--emit`, for example for `--emit asm` those will include all the `.s` files.

Most users won't notice this behavior, to be affected by it all of the following must hold:
- user must use `rustc` binary directly (when `cargo` invokes `rustc` - it consumes artifact notifications and doesn't emit anything)
- user must specify both `--emit xxx` and `--json artifacts`
- user must refuse to handle unknown artifact types
- user must disable incremental compilation (or deal with it better than cargo does, or use a workaround like `save-temps`) in order not to hit rust-lang#88829 / rust-lang#89149
…, r=ehuss

Add tracking issue and unstable book page for `"vectorcall"` ABI

Originally added in 2015 by rust-lang#30567, the Windows `"vectorcall"` ABI didn't have a tracking issue until now.

Tracking issue: rust-lang#124485
…huss

ARM Target Docs Update

Updates the ARM target docs, drawing more attention to the `arm-none-eabi` target group by placing all targets *within* that group as a sub-list in the Table of Contents.

Also updates the `armv4t-none-eabi` page (maintainer signoff: I'm that target's maintainer) to clarify that the page covers the arm version and the thumb version of the target, but that the target group page has the full info because there's nothing really specific to say for those targets.
…ee1-dead

Fix ICE caused by ignoring EffectVars in type inference

Fixes rust-lang#119830
​r? ``@matthiaskrgr``
Handle all GVN binops in a single place.

<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r​? <reviewer name>
-->

Addresses https://github.com/rust-lang/rust/pull/125359/files#r1608185319
r? ```@oli-obk```
…ket-impls, r=GuillaumeGomez

rustdoc: add a regression test for a former blanket impl synthesis ICE

Fixes rust-lang#119792 (also passes in rust-lang#125907 in case you were wondering).

r? rustdoc
…r-errors

Revert: create const block bodies in typeck via query feeding

as per the discussion in rust-lang#125806 (comment)

It was a mistake to try to shoehorn const blocks and some specific anon consts into the same box and feed them during typeck. It turned out not simplifying anything (my hope was that we could feed `type_of` to start avoiding the huge HIR matcher, but that didn't work out), but instead making a few things more fragile.

reverts the const-block-specific parts of rust-lang#124650

``@bors`` rollup=never had a small perf impact previously

fixes rust-lang#125846

r? ``@compiler-errors``
…pietroalbini

Ignore `vec_deque_alloc_error::test_shrink_to_unwind` test on non-unwind targets

rust-lang#123803 added this test which requires unwinding to succeed. This conditionally ignores the test on non-unwind targets (as is the case with other tests using `catch_unwind`).
@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 3, 2024
@rustbot rustbot added the rollup A PR which is a rollup label Jun 3, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=9

@bors
Copy link
Contributor

bors commented Jun 3, 2024

📌 Commit 198b58b has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2024
@bors
Copy link
Contributor

bors commented Jun 3, 2024

⌛ Testing commit 198b58b with merge c2d9e06...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 3, 2024
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#122597 (Show files produced by `--emit foo` in json artifact notifications)
 - rust-lang#124486 (Add tracking issue and unstable book page for `"vectorcall"` ABI)
 - rust-lang#125690 (ARM Target Docs Update)
 - rust-lang#125865 (Fix ICE caused by ignoring EffectVars in type inference)
 - rust-lang#125893 (Handle all GVN binops in a single place.)
 - rust-lang#125909 (rustdoc: add a regression test for a former blanket impl synthesis ICE)
 - rust-lang#125918 (Revert: create const block bodies in typeck via query feeding)
 - rust-lang#125919 (Remove stray "this")
 - rust-lang#125927 (Ignore `vec_deque_alloc_error::test_shrink_to_unwind` test on non-unwind targets)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-18 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
failures:

---- [codegen] tests/codegen/sanitizer/cfi/emit-type-metadata-id-itanium-cxx-abi-paths.rs stdout ----

error: verification with 'FileCheck' failed
status: exit status: 1
command: "/usr/lib/llvm-18/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/sanitizer/cfi/emit-type-metadata-id-itanium-cxx-abi-paths/emit-type-metadata-id-itanium-cxx-abi-paths.ll" "/checkout/tests/codegen/sanitizer/cfi/emit-type-metadata-id-itanium-cxx-abi-paths.rs" "--check-prefix=CHECK" "--check-prefix" "NONMSVC" "--allow-unused-prefixes" "--dump-input-context" "100"
--- stderr -------------------------------
/checkout/tests/codegen/sanitizer/cfi/emit-type-metadata-id-itanium-cxx-abi-paths.rs:85:11: error: CHECK: expected string not found in input
/checkout/tests/codegen/sanitizer/cfi/emit-type-metadata-id-itanium-cxx-abi-paths.rs:85:11: error: CHECK: expected string not found in input
// CHECK: ![[TYPE7]] = !{i64 0, !"_ZTSFvu3refIu{{[0-9]+}}NtNvC{{[[:print:]]+}}_{{[[:print:]]+}}3foo3FooEE"}
          ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/sanitizer/cfi/emit-type-metadata-id-itanium-cxx-abi-paths/emit-type-metadata-id-itanium-cxx-abi-paths.ll:136:129: note: scanning from here
!27 = !{i64 0, !"_ZTSFvu3refIu86NtNCNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo11{{closure}}3FooES0_S0_E"}
                                                                                                                                ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/sanitizer/cfi/emit-type-metadata-id-itanium-cxx-abi-paths/emit-type-metadata-id-itanium-cxx-abi-paths.ll:136:129: note: with "TYPE7" equal to "29"
!27 = !{i64 0, !"_ZTSFvu3refIu86NtNCNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo11{{closure}}3FooES0_S0_E"}
                                                                                                                                ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/sanitizer/cfi/emit-type-metadata-id-itanium-cxx-abi-paths/emit-type-metadata-id-itanium-cxx-abi-paths.ll:137:1: note: possible intended match here
!28 = !{i64 0, !"_ZTSFvu3refIu86NtNCNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo11{{closure}}3FooES0_S0_E.normalized"}

Input file: /checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/sanitizer/cfi/emit-type-metadata-id-itanium-cxx-abi-paths/emit-type-metadata-id-itanium-cxx-abi-paths.ll
Check file: /checkout/tests/codegen/sanitizer/cfi/emit-type-metadata-id-itanium-cxx-abi-paths.rs


-dump-input=help explains the following input dump.
Input was:
<<<<<<
            .
            .
            .
            .
           36: define void @_ZN43emit_type_metadata_id_itanium_cxx_abi_paths4foo317h161ec30c3224f38fE(ptr align 1 %_1, ptr align 1 %_2, ptr align 1 %_3) unnamed_addr #0 !type !19 !type !20 !type !21 !type !22 { 
           38:  ret void 
           39: } 
           40:  
           40:  
           41: ; emit_type_metadata_id_itanium_cxx_abi_paths::foo4 
           42: ; Function Attrs: nonlazybind uwtable 
           43: define void @_ZN43emit_type_metadata_id_itanium_cxx_abi_paths4foo417hd8a10710d70f0cb9E(ptr align 1 %_1) unnamed_addr #0 !type !23 !type !10 !type !24 !type !12 { 
           45:  ret void 
           46: } 
           47:  
           47:  
           48: ; emit_type_metadata_id_itanium_cxx_abi_paths::foo5 
           49: ; Function Attrs: nonlazybind uwtable 
           50: define void @_ZN43emit_type_metadata_id_itanium_cxx_abi_paths4foo517h61e1868ce2c26bacE(ptr align 1 %_1, ptr align 1 %_2) unnamed_addr #0 !type !25 !type !16 !type !26 !type !18 { 
           52:  ret void 
           53: } 
           54:  
           54:  
           55: ; emit_type_metadata_id_itanium_cxx_abi_paths::foo6 
           56: ; Function Attrs: nonlazybind uwtable 
           57: define void @_ZN43emit_type_metadata_id_itanium_cxx_abi_paths4foo617h6298d32060cff637E(ptr align 1 %_1, ptr align 1 %_2, ptr align 1 %_3) unnamed_addr #0 !type !27 !type !20 !type !28 !type !22 { 
           59:  ret void 
           60: } 
           61:  
           61:  
           62: ; emit_type_metadata_id_itanium_cxx_abi_paths::foo7 
           63: ; Function Attrs: nonlazybind uwtable 
           64: define void @_ZN43emit_type_metadata_id_itanium_cxx_abi_paths4foo717hf0cfe952b1aa5b1fE(ptr align 1 %_1) unnamed_addr #0 !type !29 !type !10 !type !30 !type !12 { 
           66:  ret void 
           67: } 
           68:  
           68:  
           69: ; emit_type_metadata_id_itanium_cxx_abi_paths::foo8 
           70: ; Function Attrs: nonlazybind uwtable 
           71: define void @_ZN43emit_type_metadata_id_itanium_cxx_abi_paths4foo817ha05ccd0aba9dd80bE(ptr align 1 %_1, ptr align 1 %_2) unnamed_addr #0 !type !31 !type !16 !type !32 !type !18 { 
           73:  ret void 
           74: } 
           75:  
           75:  
           76: ; emit_type_metadata_id_itanium_cxx_abi_paths::foo9 
           77: ; Function Attrs: nonlazybind uwtable 
           78: define void @_ZN43emit_type_metadata_id_itanium_cxx_abi_paths4foo917hea4e2b39bc504580E(ptr align 1 %_1, ptr align 1 %_2, ptr align 1 %_3) unnamed_addr #0 !type !33 !type !20 !type !34 !type !22 { 
           80:  ret void 
           81: } 
           82:  
           82:  
           83: ; emit_type_metadata_id_itanium_cxx_abi_paths::foo10 
           84: ; Function Attrs: nonlazybind uwtable 
           85: define void @_ZN43emit_type_metadata_id_itanium_cxx_abi_paths5foo1017hb3768edbeb1e1e4cE(ptr align 1 %_1) unnamed_addr #0 !type !35 !type !10 !type !36 !type !12 { 
           87:  ret void 
           88: } 
           89:  
           89:  
           90: ; emit_type_metadata_id_itanium_cxx_abi_paths::foo11 
           91: ; Function Attrs: nonlazybind uwtable 
           92: define void @_ZN43emit_type_metadata_id_itanium_cxx_abi_paths5foo1117h8b28ee5ec774eddeE(ptr align 1 %_1, ptr align 1 %_2) unnamed_addr #0 !type !37 !type !16 !type !38 !type !18 { 
           94:  ret void 
           95: } 
           96:  
           96:  
           97: ; emit_type_metadata_id_itanium_cxx_abi_paths::foo12 
           98: ; Function Attrs: nonlazybind uwtable 
           99: define void @_ZN43emit_type_metadata_id_itanium_cxx_abi_paths5foo1217he74d74a10033f162E(ptr align 1 %_1, ptr align 1 %_2, ptr align 1 %_3) unnamed_addr #0 !type !39 !type !20 !type !40 !type !22 { 
          101:  ret void 
          102: } 
          103:  
          103:  
          104: attributes #0 = { nonlazybind uwtable "probe-stack"="inline-asm" "target-cpu"="x86-64" } 
          105:  
          106: !llvm.module.flags = !{!0, !1, !2, !3} 
          107: !llvm.ident = !{!4} 
          108:  
          109: !0 = !{i32 8, !"PIC Level", i32 2} 
          110: !1 = !{i32 2, !"RtLibUseGOT", i32 1} 
          111: !2 = !{i32 4, !"CFI Canonical Jump Tables", i32 1} 
          112: !3 = !{i32 4, !"EnableSplitLTOUnit", i32 1} 
          113: !4 = !{!"rustc version 1.80.0-nightly (c2d9e0651 2024-06-03)"} 
          114: !5 = !{i64 0, !"_ZTSFvvE"} 
          115: !6 = !{i64 0, !"_ZTSFvvE.generalized"} 
          116: !7 = !{i64 0, !"_ZTSFvvE.normalized"} 
          117: !8 = !{i64 0, !"_ZTSFvvE.normalized.generalized"} 
          118: !9 = !{i64 0, !"_ZTSFvu3refIu71NtNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo3FooEE"} 
          119: !10 = !{i64 0, !"_ZTSFvu3refIvEE.generalized"} 
          120: !11 = !{i64 0, !"_ZTSFvu3refIu71NtNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo3FooEE.normalized"} 
          121: !12 = !{i64 0, !"_ZTSFvu3refIvEE.normalized.generalized"} 
          122: !13 = !{i64 0, !"_ZTSFvu3refIu85NvNFNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo10{{extern}}3barEE"} 
          123: !14 = !{i64 0, !"_ZTSFvu3refIu85NvNFNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo10{{extern}}3barEE.normalized"} 
          124: !15 = !{i64 0, !"_ZTSFvu3refIu85NvNFNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo10{{extern}}3barES0_E"} 
          125: !16 = !{i64 0, !"_ZTSFvu3refIvES_E.generalized"} 
          126: !17 = !{i64 0, !"_ZTSFvu3refIu85NvNFNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo10{{extern}}3barES0_E.normalized"} 
          127: !18 = !{i64 0, !"_ZTSFvu3refIvES_E.normalized.generalized"} 
          128: !19 = !{i64 0, !"_ZTSFvu3refIu85NvNFNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo10{{extern}}3barES0_S0_E"} 
          129: !20 = !{i64 0, !"_ZTSFvu3refIvES_S_E.generalized"} 
          130: !21 = !{i64 0, !"_ZTSFvu3refIu85NvNFNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo10{{extern}}3barES0_S0_E.normalized"} 
          131: !22 = !{i64 0, !"_ZTSFvu3refIvES_S_E.normalized.generalized"} 
          132: !23 = !{i64 0, !"_ZTSFvu3refIu86NtNCNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo11{{closure}}3FooEE"} 
          133: !24 = !{i64 0, !"_ZTSFvu3refIu86NtNCNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo11{{closure}}3FooEE.normalized"} 
          134: !25 = !{i64 0, !"_ZTSFvu3refIu86NtNCNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo11{{closure}}3FooES0_E"} 
          135: !26 = !{i64 0, !"_ZTSFvu3refIu86NtNCNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo11{{closure}}3FooES0_E.normalized"} 
          136: !27 = !{i64 0, !"_ZTSFvu3refIu86NtNCNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo11{{closure}}3FooES0_S0_E"} 
check:85'0                                                                                                                                     X error: no match found
check:85'1                                                                                                                                       with "TYPE7" equal to "29"
          137: !28 = !{i64 0, !"_ZTSFvu3refIu86NtNCNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo11{{closure}}3FooES0_S0_E.normalized"} 
check:85'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:85'2     ?                                                                                                                                            possible intended match
          138: !29 = !{i64 0, !"_ZTSFvu3refIu87NtNkNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo12{{constant}}3FooEE"} 
check:85'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          139: !30 = !{i64 0, !"_ZTSFvu3refIu87NtNkNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo12{{constant}}3FooEE.normalized"} 
check:85'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          140: !31 = !{i64 0, !"_ZTSFvu3refIu87NtNkNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo12{{constant}}3FooES0_E"} 
check:85'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          141: !32 = !{i64 0, !"_ZTSFvu3refIu87NtNkNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo12{{constant}}3FooES0_E.normalized"} 
check:85'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          142: !33 = !{i64 0, !"_ZTSFvu3refIu87NtNkNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo12{{constant}}3FooES0_S0_E"} 
check:85'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          143: !34 = !{i64 0, !"_ZTSFvu3refIu87NtNkNvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo12{{constant}}3FooES0_S0_E.normalized"} 
check:85'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          144: !35 = !{i64 0, !"_ZTSFvu3refIu82NvNINvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo8{{impl}}3barEE"} 
check:85'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          145: !36 = !{i64 0, !"_ZTSFvu3refIu82NvNINvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo8{{impl}}3barEE.normalized"} 
check:85'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          146: !37 = !{i64 0, !"_ZTSFvu3refIu82NvNINvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo8{{impl}}3barES0_E"} 
check:85'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          147: !38 = !{i64 0, !"_ZTSFvu3refIu82NvNINvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo8{{impl}}3barES0_E.normalized"} 
check:85'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          148: !39 = !{i64 0, !"_ZTSFvu3refIu82NvNINvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo8{{impl}}3barES0_S0_E"} 
check:85'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          149: !40 = !{i64 0, !"_ZTSFvu3refIu82NvNINvCs3RXtr2flWni_43emit_type_metadata_id_itanium_cxx_abi_paths3foo8{{impl}}3barES0_S0_E.normalized"} 
check:85'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
------------------------------------------



@bors
Copy link
Contributor

bors commented Jun 3, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 3, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Jun 3, 2024

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Jun 3, 2024

Where does this codegen change come from :ferrisClueless:

@lqd lqd closed this Jun 4, 2024
@matthiaskrgr matthiaskrgr deleted the rollup-nufugmb branch September 1, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix Operating system: Unix-like rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.