Check that alias-relate terms are WF if reporting an error in alias-relate #126404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
compiler-errors
commented
Jun 13, 2024
| if let Some(ty::PredicateKind::AliasRelate(lhs, rhs, _)) = pred_kind.no_bound_vars() { | ||
| if let Some(obligation) = goal | ||
| .infcx() | ||
| .visit_proof_tree( |
There was a problem hiding this comment.
This is jank and incorrect -- we're not inheriting a depth, so we can potentially stack overflow here.
Any ideas on a first-class way to create a custom nested obligation even though we don't have one in the proof tree? Should I just expose a constructor on InspectGoal?
There was a problem hiding this comment.
yeah, alternatively visit_proof_tree_at_depth or sth? Not sure, I don't 100% like the current proof tree API
There was a problem hiding this comment.
I'll do that for now. It shouldn't be difficult to change.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 15, 2024
…llaumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#126229 (Bump windows-bindgen to 0.57) - rust-lang#126404 (Check that alias-relate terms are WF if reporting an error in alias-relate) - rust-lang#126410 (smir: merge identical Constant and ConstOperand types) - rust-lang#126478 (Migrate `run-make/codegen-options-parsing` to `rmake.rs`) - rust-lang#126496 (Make proof tree probing and `Candidate`/`CandidateSource` generic over interner) - rust-lang#126508 (Make uninitialized_error_reported a set of locals) - rust-lang#126517 (Migrate `run-make/dep-graph` to `rmake.rs`) - rust-lang#126525 (trait_selection: remove extra words) - rust-lang#126526 (tests/ui/lint: Move 19 tests to new `non-snake-case` subdir) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 15, 2024
Rollup merge of rust-lang#126404 - compiler-errors:alias-relate-terms, r=lcnr Check that alias-relate terms are WF if reporting an error in alias-relate Check that each of the left/right term is WF when deriving a best error obligation for an alias-relate goal. This will make sure that given `<i32 as NotImplemented>::Assoc = ()` will drill down into `i32: NotImplemented` since we currently treat the projection as rigid. r? lcnr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that each of the left/right term is WF when deriving a best error obligation for an alias-relate goal. This will make sure that given
<i32 as NotImplemented>::Assoc = ()will drill down intoi32: NotImplementedsince we currently treat the projection as rigid.r? lcnr