Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/ui/lint: Move 19 tests to new non-snake-case subdir #126526

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Jun 15, 2024

Mainly so that it is easier to only run all non_snake_case-lint-specific tests with:

./x test tests/ui/lint/non-snake-case

But also to reduce the size of the large tests/ui/lint directory. And rename some tests to pass tidy, and remove them from src/tools/tidy/src/issues.txt.

@rustbot
Copy link
Collaborator

rustbot commented Jun 15, 2024

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 15, 2024
Mainly so that it is easier to only run all `non-snake-case`-specific
tests but no other tests with:

    ./x test tests/ui/lint/non-snake-case

But also to reduce the size of the large `tests/ui/lint` directory. And
rename some tests to pass tidy, and remove them from
`src/tools/tidy/src/issues.txt`.
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reorganization

@jieyouxu
Copy link
Member

r? jieyouxu
@bors r+

@bors
Copy link
Contributor

bors commented Jun 15, 2024

📌 Commit b717aa1 has been approved by jieyouxu

It is now in the queue for this repository.

@rustbot rustbot assigned jieyouxu and unassigned wesleywiser Jun 15, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2024
@jieyouxu
Copy link
Member

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 15, 2024
…llaumeGomez

Rollup of 9 pull requests

Successful merges:

 - rust-lang#126229 (Bump windows-bindgen to 0.57)
 - rust-lang#126404 (Check that alias-relate terms are WF if reporting an error in alias-relate)
 - rust-lang#126410 (smir: merge identical Constant and ConstOperand types)
 - rust-lang#126478 (Migrate `run-make/codegen-options-parsing` to `rmake.rs`)
 - rust-lang#126496 (Make proof tree probing and `Candidate`/`CandidateSource` generic over interner)
 - rust-lang#126508 (Make uninitialized_error_reported a set of locals)
 - rust-lang#126517 (Migrate `run-make/dep-graph` to `rmake.rs`)
 - rust-lang#126525 (trait_selection: remove extra words)
 - rust-lang#126526 (tests/ui/lint: Move 19 tests to new `non-snake-case` subdir)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f788ea4 into rust-lang:master Jun 15, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 15, 2024
Rollup merge of rust-lang#126526 - Enselic:non-snake-case, r=jieyouxu

tests/ui/lint: Move 19 tests to new `non-snake-case` subdir

Mainly so that it is easier to only run all `non_snake_case`-lint-specific tests with:

    ./x test tests/ui/lint/non-snake-case

But also to reduce the size of the large `tests/ui/lint` directory. And rename some tests to pass tidy, and remove them from `src/tools/tidy/src/issues.txt`.
@rustbot rustbot added this to the 1.81.0 milestone Jun 15, 2024
@Enselic Enselic deleted the non-snake-case branch June 15, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants