-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #127014
Rollup of 6 pull requests #127014
Commits on Jun 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for aa30dd4 - Browse repository at this point
Copy the full SHA aa30dd4View commit details
Commits on Jun 25, 2024
-
Extend
tests/ui/macros/nonterminal-matching.rs
.To involve `macro_rules!` macros, and also a mix of fragment specifiers, some of which feature the forwaring limitation and some of which don't.
Configuration menu - View commit details
-
Copy full SHA for bca5cd3 - Browse repository at this point
Copy the full SHA bca5cd3View commit details -
Just some extra sanity checking, making explicit some values not possible in code working with token trees -- we shouldn't be seeing explicit delimiter tokens, because they should be represented as `TokenTree::Delimited`.
Configuration menu - View commit details
-
Copy full SHA for 2e4d547 - Browse repository at this point
Copy the full SHA 2e4d547View commit details -
This was added (with a different name) to improve an error message. It is no longer needed -- removing it changes the error message, but overall I think the new message is no worse: - the mention of `#` in the first line is a little worse, - but the extra context makes it very clear what the problem is, perhaps even clearer than the old message, - and the removal of the note about the `expr` fragment (an internal detail of `__rust_force_expr`) is an improvement. Overall I think the error is quite clear and still far better than the old message that prompted rust-lang#61933, which didn't even mention patterns. The motivation for this is rust-lang#124141, which will cause pasted metavariables to be tokenized and reparsed instead of the AST node being cached. This change in behaviour occasionally has a non-zero perf cost, and `__rust_force_expr` causes the tokenize/reparse step to occur twice. Removing `__rust_force_expr` greatly reduces the extra overhead for the `deep-vector` benchmark.
Configuration menu - View commit details
-
Copy full SHA for 9828e96 - Browse repository at this point
Copy the full SHA 9828e96View commit details -
Inline and remove
maybe_whole_expr!
.And remove the `NtPath` and `NtBlock` cases in `parse_literal_maybe_minus`, because they are unnecessary.
Configuration menu - View commit details
-
Copy full SHA for 379b761 - Browse repository at this point
Copy the full SHA 379b761View commit details
Commits on Jun 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 457fda1 - Browse repository at this point
Copy the full SHA 457fda1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3262611 - Browse repository at this point
Copy the full SHA 3262611View commit details -
coverage: Allow
#[coverage(..)]
onimpl
andmod
These attributes apply to all enclosed functions/methods/closures, unless explicitly overridden by another coverage attribute.
Configuration menu - View commit details
-
Copy full SHA for 7f37f8a - Browse repository at this point
Copy the full SHA 7f37f8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5167fe - Browse repository at this point
Copy the full SHA e5167feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5aac249 - Browse repository at this point
Copy the full SHA 5aac249View commit details -
Configuration menu - View commit details
-
Copy full SHA for 518b74e - Browse repository at this point
Copy the full SHA 518b74eView commit details
Commits on Jun 27, 2024
-
Rollup merge of rust-lang#126571 - nnethercote:less-maybe_whole-expr-…
…2, r=petrochenkov Less `maybe_whole_expr`, take 2 I first tried this in rust-lang#107550. I now think it's worth doing again, as a precursor to rust-lang#124141. r? ```@petrochenkov```
Configuration menu - View commit details
-
Copy full SHA for 5ec93b8 - Browse repository at this point
Copy the full SHA 5ec93b8View commit details -
Rollup merge of rust-lang#126721 - Zalathar:nested-cov-attr, r=oli-obk
coverage: Make `#[coverage(..)]` apply recursively to nested functions This PR makes the (currently-unstable) `#[coverage(off)]` and `#[coverage(on)]` attributes apply recursively to all nested functions/closures, instead of just the function they are directly attached to. Those attributes can now also be applied to modules and to impl/impl-trait blocks, where they have no direct effect, but will be inherited by all enclosed functions/closures/methods that don't override the inherited value. --- Fixes rust-lang#126625.
Configuration menu - View commit details
-
Copy full SHA for 70b69a2 - Browse repository at this point
Copy the full SHA 70b69a2View commit details -
Rollup merge of rust-lang#126928 - nnethercote:124141-pre, r=oli-obk
Some `Nonterminal` removal precursors Small things to prepare for rust-lang#124141, more or less. r? ```@oli-obk```
Configuration menu - View commit details
-
Copy full SHA for b1f4397 - Browse repository at this point
Copy the full SHA b1f4397View commit details -
Rollup merge of rust-lang#126929 - nnethercote:rm-__rust_force_expr, …
…r=oli-obk Remove `__rust_force_expr`. This was added (with a different name) to improve an error message. It is no longer needed -- removing it changes the error message, but overall I think the new message is no worse: - the mention of `#` in the first line is a little worse, - but the extra context makes it very clear what the problem is, perhaps even clearer than the old message, - and the removal of the note about the `expr` fragment (an internal detail of `__rust_force_expr`) is an improvement. Overall I think the error is quite clear and still far better than the old message that prompted rust-lang#61933, which didn't even mention patterns. The motivation for this is rust-lang#124141, which will cause pasted metavariables to be tokenized and reparsed instead of the AST node being cached. This change in behaviour occasionally has a non-zero perf cost, and `__rust_force_expr` causes the tokenize/reparse step to occur twice. Removing `__rust_force_expr` greatly reduces the extra overhead for the `deep-vector` benchmark. r? ```@oli-obk```
Configuration menu - View commit details
-
Copy full SHA for d3debc0 - Browse repository at this point
Copy the full SHA d3debc0View commit details -
Rollup merge of rust-lang#126980 - Borgerr:fix-extendfromslice-check,…
… r=workingjubilee set self.is_known_utf8 to false in extend_from_slice try-job: x86_64-msvc closes rust-lang#126977 Related to rust-lang#126885, rust-lang#126333, and [this conversation](<rust-lang@aa46a33#r143539097>)
Configuration menu - View commit details
-
Copy full SHA for 8905be5 - Browse repository at this point
Copy the full SHA 8905be5View commit details -
Rollup merge of rust-lang#126983 - tgross35:f16-f128-smir, r=celinval
Remove `f16` and `f128` ICE paths from smir Just chasing down some possible ICE paths. ```@compiler-errors``` mentioned in rust-lang#121728 (comment) that it is okay not to support these in smir, but this change seems pretty trivial? r? ```@celinval``` since you reviewed rust-lang#114607 (review)
Configuration menu - View commit details
-
Copy full SHA for 73016dc - Browse repository at this point
Copy the full SHA 73016dcView commit details