Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #127519

Closed
wants to merge 23 commits into from

Commits on Jun 27, 2024

  1. Add test

    Nadrieril committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    5df6f72 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    834f043 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Configuration menu
    Copy the full SHA
    90cbd0b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d9ed923 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    de14f1f View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. fix interleaved panic output

    previously, we only held a lock for printing the backtrace itself. since all threads were printing to the same file descriptor, that meant random output in the default panic hook would be interleaved with the backtrace. now, we hold the lock for the full duration of the hook, and the output is ordered.
    jyn514 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    875b730 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ab56dfd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    321eba5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ec662e7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    96a7916 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Configuration menu
    Copy the full SHA
    7097dbc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e38109d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fd9a925 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    aece064 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dd175fe View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#127028 - Nadrieril:fix-or-pat-expansion, r=…

    …matthewjasper
    
    Fix regression in the MIR lowering of or-patterns
    
    In rust-lang#126553 I made a silly indexing mistake and regressed the MIR lowering of or-patterns. This fixes it.
    
    r? `@compiler-errors` because I'd like this to be merged quickly 🙏
    matthiaskrgr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    64bebff View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#127091 - Sky9x:fused-error-sources-iter, r=…

    …dtolnay
    
    impl FusedIterator and a size hint for the error sources iter
    
    cc tracking issue rust-lang#58520
    matthiaskrgr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d591c2b View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#127358 - oli-obk:taint_itemctxt, r=fmease

    Automatically taint when reporting errors from ItemCtxt
    
    This isn't very robust yet, as you need to use `itemctxt.dcx()` instead of `tcx.dcx()` for it to take effect, but it's at least more convenient than sprinkling `set_tainted_by_errors` calls in individual places.
    
    based on rust-lang#127357
    
    r? `@fmease`
    matthiaskrgr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    a557e18 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#127382 - estebank:const-let, r=compiler-errors

    Use verbose style when suggesting changing `const` with `let`
    matthiaskrgr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2fea2c7 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#127397 - jyn514:multi-thread-panic-hook, r=…

    …workingjubilee
    
    fix interleaved output in the default panic hook when multiple threads panic simultaneously
    
    previously, we only held a lock for printing the backtrace itself. since all threads were printing to the same file descriptor, that meant random output in the default panic hook from one thread would be interleaved with the backtrace from another. now, we hold the lock for the full duration of the hook, and the output is ordered.
    
    ---
    
    i noticed some odd things while working on this you may or may not already be aware of.
    
    - libbacktrace is included as a submodule instead of a normal rustc crate, and as a result uses `cfg(backtrace_in_std)` instead of a more normal `cfg(feature = "rustc-dep-of-std")`. probably this is left over from before rust used a cargo-based build system?
    - the default panic handler uses `trace_unsynchronized`, etc, in `sys::backtrace::print`. as a result, the lock only applies to concurrent *panic handlers*, not concurrent *threads*.  in other words, if another, non-panicking, thread tried to print a backtrace at the same time as the panic handler, we may have UB, especially on windows.
        - we have the option of changing backtrace to enable locking when `backtrace_in_std` is set so we can reuse their lock instead of trying to add our own.
    matthiaskrgr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d2220e3 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#127484 - ShE3py:rustdoc-doc-alias-whitespac…

    …e-doc, r=fmease
    
    `#[doc(alias)]`'s doc: say that ASCII spaces are allowed
    
    PR rust-lang#77570 allowed ASCII spaces in doc aliases, but the documentation wasn't updated to say so.
    
    The code checking the aliases:
    https://github.com/rust-lang/rust/blob/7fdefb804ec300fb605039522a7c0dfc9e7dc366/compiler/rustc_passes/src/check_attr.rs#L693-L704
    
    `@rustbot` label +A-docs
    matthiaskrgr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    5b84462 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#127496 - tgross35:f16-f128-pattern-fixme, r…

    …=Nadrieril
    
    Update `f16`/`f128` FIXMEs that needed `(NEG_)INFINITY`
    
    Just a small fix to the pattern matching tests now that we can. Also contains a small unrelated comment tweak.
    matthiaskrgr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    4f6ede1 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#127508 - lcnr:search-graph-prep, r=compiler…

    …-errors
    
    small search graph refactor
    
    small improvements which shouldn't impact behavior.
    
    r? `@compiler-errors`
    matthiaskrgr committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    9a1c4cb View commit details
    Browse the repository at this point in the history