Rollup of 8 pull requests #127865

matthiaskrgr · 2024-07-17T14:22:34Z

Successful merges:

Use ordinal number in argument error #125042 (Use ordinal number in argument error)
rustdoc: click target for sidebar items flush left #127229 (rustdoc: click target for sidebar items flush left)
Move a few intrinsics to Rust abi #127337 (Move a few intrinsics to Rust abi)
MIR building: Stop using unpack! for BlockAnd<()> #127472 (MIR building: Stop using unpack! for BlockAnd<()>)
Solve a error .clone() suggestion when moving a mutable reference #127579 (Solve a error .clone() suggestion when moving a mutable reference)
Don't use implicit features in Cargo.toml in compiler/ #127769 (Don't use implicit features in Cargo.toml in compiler/)
Remove invalid further restricting suggestion for type bound #127844 (Remove invalid further restricting suggestion for type bound)
Add myself to review rotation #127855 (Add myself to review rotation)

r? @ghost
@rustbot modify labels: rollup

Move a few more intrinsic functions to the convention added in rust-lang#121192 where they have Rust abi but are tagged with `rustc_intrinsic`.

This kind of unpacking can be expressed as an ordinary method on `BlockAnd<()>`.

Fix error message Fix tests Format

…on and it's type is a generic param, it can be reborrowed to avoid moving. for example: ```rust struct Y(u32); // x's type is '& mut Y' and it is used in `fn generic<T>(x: T) {}`. fn generic<T>(x: T) {} ``` fixes rust-lang#127285

…utside, r=fmease Use ordinal number in argument error Add an ordinal number to two argument errors ("unexpected" and "missing") for ease of understanding error. ``` error[E0061]: this function takes 3 arguments but 2 arguments were supplied --> test.rs:11:5 | 11 | f(42, 'a'); | ^ --- 2nd argument of type `f32` is missing | (snip) error[E0061]: this function takes 3 arguments but 4 arguments were supplied --> test.rs:12:5 | 12 | f(42, 42, 1.0, 'a'); | ^ ---- | | | | | unexpected 2nd argument of type `{integer}` | help: remove the extra argument ``` To get an ordinal number, I copied `ordinalize` from other crate `rustc_resolve` because I think it is too much to link `rustc_resolve` for this small function. Please let me know if there is a better way.

… r=GuillaumeGomez rustdoc: click target for sidebar items flush left This change adjusts the clickable area of sidebar links to touch the leftmost edge of the canvas, making them [much easier](https://www.nngroup.com/articles/fitts-law/) to click (when the browser window is maximized or tiled left, but those cases are common enough to matter). [Screencast from 2024-07-15 15-31-07.webm](https://github.com/user-attachments/assets/1e952d3a-e9e7-476b-b211-44a17c190b38) <details><summary>old screencast</summary> [Screencast from 2024-07-01 17-23-34.webm](https://github.com/rust-lang/rust/assets/1593513/dc6f9c2e-5904-403d-b353-d233e6e1afbc) </details>

…i-obk Move a few intrinsics to Rust abi Move a few more intrinsic functions to the convention added in rust-lang#121192. In the second commit, I added documentation about their safety requirements. Let me know if you would like me to move the second commit to a different PR. Note: I kept the same signature of `pref_align_of`, but I was wondering why this function is considered unsafe?

MIR building: Stop using `unpack!` for `BlockAnd<()>` This is a subset of rust-lang#127416, containing only the parts related to `BlockAnd<()>`. The first patch removes the non-assigning form of the `unpack!` macro, because it is frustratingly inconsistent with the main form. We can replace it with an ordinary method that discards the `()` and returns the block. The second patch then finds all of the remaining code that was using `unpack!` with `BlockAnd<()>`, and updates it to use that new method instead. --- Changes since original review of rust-lang#127416: - Renamed `fn unpack_block` → `fn into_block` - Removed `fn unpack_discard`, replacing it with `let _: BlockAnd<()> = ...` (2 occurrences) - Tweaked `arm_end_blocks` to unpack earlier and build `Vec<BasicBlock>` instead of `Vec<BlockAnd<()>>`

Solve a error `.clone()` suggestion when moving a mutable reference If the moved value is a mut reference, it is used in a generic function and it's type is a generic param, suggest it can be reborrowed to avoid moving. for example: ```rust struct Y(u32); // x's type is '& mut Y' and it is used in `fn generic<T>(x: T) {}`. fn generic<T>(x: T) {} ``` fixes rust-lang#127285

…-obk Don't use implicit features in `Cargo.toml` in `compiler/` Fixes compiler crates to stop using implicit features (rust-lang/cargo#12826) which are denied in in edition 2024.

…27555, r=jieyouxu Remove invalid further restricting suggestion for type bound This PR partially addresses rust-lang#127555, it will remove the obvious error suggestion: ```console | ^^^^ required by this bound in `<Baz as Foo>::bar` help: consider further restricting this bound | 12 | F: FnMut() + Send + std::marker::Send, | +++++++++++++++++++ ``` I may create another PR to get a better diagnostic for `impl has stricter requirements than trait` scenario.

…=jieyouxu Add myself to review rotation r? `@wesleywiser`

rust-log-analyzer · 2024-07-17T15:54:45Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125042 (Use ordinal number in argument error) - rust-lang#127229 (rustdoc: click target for sidebar items flush left) - rust-lang#127337 (Move a few intrinsics to Rust abi) - rust-lang#127472 (MIR building: Stop using `unpack!` for `BlockAnd<()>`) - rust-lang#127579 (Solve a error `.clone()` suggestion when moving a mutable reference) - rust-lang#127769 (Don't use implicit features in `Cargo.toml` in `compiler/`) - rust-lang#127844 (Remove invalid further restricting suggestion for type bound) - rust-lang#127855 (Add myself to review rotation) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-07-17T18:19:14Z

⌛ Testing commit 2ea21cf with merge 798d1eb...

rust-log-analyzer · 2024-07-17T19:26:21Z

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2024-07-17T19:27:16Z

💔 Test failed - checks-actions

matthiaskrgr · 2024-07-17T19:33:09Z

@bors retry

bors · 2024-07-17T21:52:33Z

⌛ Testing commit 2ea21cf with merge e35364a...

bors · 2024-07-18T00:14:02Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e35364a to master...

rust-timer · 2024-07-18T00:16:19Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#125042	Use ordinal number in argument error	`53ced6fb2a74f591ea8abb3e48760493449fdbf0` (link)
#127229	rustdoc: click target for sidebar items flush left	`4729e3049772fa849566e0c20314785e8b3983f2` (link)
#127337	Move a few intrinsics to Rust abi	`79a0584bef403b14cd1d8049e1053e789e373237` (link)
#127472	MIR building: Stop using `unpack!` for `BlockAnd<()>`	`3efbe8345cca2b464d08efd242f3c00194adfb06` (link)
#127579	Solve a error `.clone()` suggestion when moving a mutable r…	`87c8e794cf8048435b9edc8628ece9c1f4c9af93` (link)
#127769	Don't use implicit features in `Cargo.toml` in `compiler/`	`a4dbb0ad9160902735ed241e011d7c7aea49af15` (link)
#127844	Remove invalid further restricting suggestion for type bound	`0f2251c57783232681dd0131354adcad942c7aaa` (link)
#127855	Add myself to review rotation	`c05fcaafc4d0c313a903168b0b830ef91482a1d8` (link)

previous master: fcc325f1bc

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-07-18T01:30:50Z

Finished benchmarking commit (e35364a): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.4%, 0.7%]	4
Regressions ❌ (secondary)	1.1%	[0.6%, 2.1%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.4%, 0.7%]	4

Max RSS (memory usage)

Results (primary 2.7%, secondary 2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	7.8%	[7.8%, 7.8%]	1
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	1
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.7%	[-2.4%, 7.8%]	2

Cycles

Results (primary 0.7%, secondary -0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.9%	[-0.9%, -0.9%]	1
All ❌✅ (primary)	0.7%	[0.7%, 0.7%]	1

Binary size

Results (primary 0.4%, secondary 3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.0%, 1.2%]	51
Regressions ❌ (secondary)	3.1%	[2.4%, 3.3%]	4
Improvements ✅ (primary)	-0.1%	[-0.2%, -0.0%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[-0.2%, 1.2%]	53

Bootstrap: 769.435s -> 768.708s (-0.09%)
Artifact size: 328.71 MiB -> 328.63 MiB (-0.02%)

Mark-Simulacrum · 2024-07-22T00:16:54Z

@rust-timer build 79a0584

Mark-Simulacrum · 2024-07-22T00:17:24Z

@rust-timer build 87c8e79

rust-timer · 2024-07-22T01:34:29Z

Finished benchmarking commit (79a0584): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.3%, 0.7%]	4
Regressions ❌ (secondary)	1.0%	[0.1%, 1.9%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.3%, 0.7%]	4

Max RSS (memory usage)

Results (primary 3.1%, secondary 3.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	8.0%	[8.0%, 8.0%]	1
Regressions ❌ (secondary)	3.4%	[3.4%, 3.4%]	1
Improvements ✅ (primary)	-1.8%	[-1.8%, -1.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.1%	[-1.8%, 8.0%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary 0.4%, secondary 3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.0%, 1.2%]	51
Regressions ❌ (secondary)	3.1%	[2.4%, 3.3%]	4
Improvements ✅ (primary)	-0.1%	[-0.2%, -0.0%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[-0.2%, 1.2%]	53

Bootstrap: 769.435s -> 769.443s (0.00%)
Artifact size: 328.71 MiB -> 328.61 MiB (-0.03%)

9cc3bc6 custom MIR: add support for tail calls 5674d1c Auto merge of rust-lang#128673 - matthiaskrgr:rollup-gtvpkm7, r=matthiaskrgr deb1d75 Rollup merge of rust-lang#128619 - glandium:last_chunk, r=scottmcm 6449537 Rollup merge of rust-lang#128609 - swenson:smaller-faster-dragon, r=Amanieu acb2c30 Rollup merge of rust-lang#128026 - devnexen:available_parallelism_vxworks, r=Mark-Simulacrum 89fe6df Rollup merge of rust-lang#128309 - kmicklas:btreeset-cursor, r=Amanieu 313484b Correct the const stabilization of `<[T]>::last_chunk` 22e026b Auto merge of rust-lang#128534 - bjorn3:split_stdlib_workspace, r=Mark-Simulacrum 1813603 Rollup merge of rust-lang#128526 - tshepang:patch-1, r=Amanieu e8a1a41 Auto merge of rust-lang#128466 - sayantn:stdarch-update, r=tgross35 2adf9da Update stdarch dc85bdb Chore: add `x86_amx_intrinsics` feature flag to `core/lib.rs` and remove `issue-120720-reduce-nan.rs` e88b04d Rollup merge of rust-lang#128551 - Konippi:refactor-backtrace-style-in-panic, r=tgross35 43a1e93 Rollup merge of rust-lang#128530 - scottmcm:repeat-n-unchecked, r=joboet 47df194 Remove unnecessary constants from flt2dec dragon 0b5f1b8 Auto merge of rust-lang#128404 - compiler-errors:revert-dead-code-changes, r=pnkfelix 35cd95f Suppress new false-negatives that were masked by dead code analysis changes 9eb9fa6 Revert "Rollup merge of rust-lang#127107 - mu001999-contrib:dead/enhance-2, r=pnkfelix" 975dc19 Rollup merge of rust-lang#128368 - nnethercote:rustfmt-tweaks, r=cuviper 0ee09fe Rollup merge of rust-lang#128303 - NobodyXu:specialise-for-pipe, r=cuviper 1967a12 Rollup merge of rust-lang#127586 - zachs18:more-must-use, r=cuviper fc53324 Rollup merge of rust-lang#126704 - sayantn:sha, r=Amanieu 74dd96f chore: refactor backtrace style in panic 0e4358d Auto merge of rust-lang#128528 - workingjubilee:you-dont-need-to-see-this-cpuid-move-along, r=Amanieu 9fa74ab Move the standard library to a separate workspace e13d132 Auto merge of rust-lang#128254 - Amanieu:orig-binary-search, r=tgross35 05d8d7c Implement `UncheckedIterator` directly for `RepeatN` a5fa13e Rollup merge of rust-lang#128491 - c410-f3r:unlock-rfc-2011, r=workingjubilee 28e4d22 Rollup merge of rust-lang#128453 - RalfJung:raw_eq, r=saethlin db770c6 std: Remove has_cpuid 39aad04 time.rs: remove "Basic usage text" 7df583c Dogfood cb11051 Add the `sha512`, `sm3` and `sm4` target features 86ea79f Fix mutability in doc tests for `BTreeSet` cursors c7be27f Introduce `Cursor`/`CursorMut`/`CursorMutKey` thrichotomy for `BTreeSet` like map API 8835b0f Fix some uses of "map" instead of "set" in `BTreeSet` cursor API docs 07f64a8 Share `UnorderedKeyError` with `BTReeMap` for set API f859e54 Rollup merge of rust-lang#128499 - Konippi:refactor-backtrace-formatting, r=tgross35 fb966d2 Rollup merge of rust-lang#128497 - Bryanskiy:fix-dropck-doc, r=lcnr ab00ae6 Rollup merge of rust-lang#128433 - hermit-os:hermit-unsafe_op_in_unsafe_fn, r=joboet 2614bd2 chore: refactor backtrace formatting a8a4659 fix dropck documentation for `[T;0]` special-case 589c0a0 fix(os/hermit): `deny(unsafe_op_in_unsafe_fn)` 0260e47 fix(pal/hermit): `deny(unsafe_op_in_unsafe_fn)` 7bd6b11 refactor(pal/hermit): make `ENV` a non-mutable static 32894e2 Rollup merge of rust-lang#128416 - maurer:remove-android-hack, r=tgross35 beb76c3 Auto merge of rust-lang#128461 - matthiaskrgr:rollup-3dpp11g, r=matthiaskrgr 1e3976b Rollup merge of rust-lang#128162 - ChrisDenton:cleanup, r=joboet cde45b0 Rollup merge of rust-lang#127567 - joboet:once_wait, r=Amanieu 0607642 Fix docs for OnceLock::get_mut_or_init da48417 raw_eq: using it on bytes with provenance is not UB (outside const-eval) cc6f37f std: fix busy-waiting in `Once::wait_force`, add more tests 6fd82f1 std: implement the `once_wait` feature 0c56873 Remove unneeded `pub(crate)` 787a1f7 Rollup merge of rust-lang#128388 - beetrees:f16-f128-slightly-improve-windows-abi, r=tgross35 e3a4ed3 Rollup merge of rust-lang#128387 - liigo:patch-14, r=tgross35 8b7f4ee refactor(pal/hermit): use default impl of `GlobalAlloc::alloc_zeroed` c337019 refactor(pal/hermit): return `!` to satisfy rust-analyzer 7aafdcf android: Remove libstd hacks for unsupported Android APIs ba65c6c Move Windows implementation of anon pipe 176508c Match LLVM ABI in `extern "C"` functions for `f128` on Windows 85e4ba0 Cleanup sys module to match house style ddff2b6 Auto merge of rust-lang#128083 - Mark-Simulacrum:bump-bootstrap, r=albertlarsan68 e4b0e6d Rewrite binary search implementation 556dc60 More detailed note to deprecate ONCE_INIT 440ec83 Auto merge of rust-lang#128378 - matthiaskrgr:rollup-i3qz9uo, r=matthiaskrgr a50fe57 Auto merge of rust-lang#128250 - Amanieu:select_unpredictable, r=nikic 47f9d61 Rollup merge of rust-lang#128315 - zetanumbers:psvita-unsafe-in-unsafe, r=workingjubilee f70ce7f Auto merge of rust-lang#128234 - jcsp:retain-empty-case, r=tgross35 93b2f7c Insert some blank lines. db0222e Move a comment. cc96f3e Stabilize offset_of_nested 618fdd5 Auto merge of rust-lang#128334 - matthiaskrgr:rollup-nhxdt0c, r=matthiaskrgr e088cb1 Rollup merge of rust-lang#128333 - RalfJung:miri-sync, r=RalfJung 1ea0493 Rollup merge of rust-lang#128307 - ojeda:unescaped_backticks, r=GuillaumeGomez 5d51099 Optimize empty case in Vec::retain f2bcbec Auto merge of rust-lang#125016 - nicholasbishop:bishop-cb-112, r=tgross35 7a43feb Rollup merge of rust-lang#128310 - kmicklas:btree-map-peek-next-docs, r=tgross35 03e5078 Rollup merge of rust-lang#128055 - workingjubilee:deny-unsafe-ops-in-sys-personality-dwarf-eh, r=Amanieu f9befad Rollup merge of rust-lang#109174 - soerenmeier:cursor_fns, r=dtolnay ed7d02f Update compiler_builtins to 0.1.114 80254cd Warn on `rustdoc::unescaped_backticks` for `core/alloc/std/test/proc_macro` c8db8ea Remove spurious backticks detected by `rustdoc::unescaped_backticks` d1d4fb3 Reformat `use` declarations. 3ec244f Replace `io::Cursor::{remaining_slice, is_empty}` with `io::Cursor::{split, split_mut}` abc611f step cfg(bootstrap) 78cd779 Update CURRENT_RUSTC_VERSION 70927dc Add forbid(unsafe_op_in_unsafe_fn) 06a22c9 Rollup merge of rust-lang#128240 - mbrubeck:patch-3, r=joboet 604d618 Rollup merge of rust-lang#128228 - slanterns:const_waker, r=dtolnay,oli-obk 2a70839 Rollup merge of rust-lang#128103 - folkertdev:unsigned-int-is-multiple-of, r=Amanieu 058f1d3 Rollup merge of rust-lang#127765 - bitfield:fix_stdlib_doc_nits, r=dtolnay 9a6c84e fix: psvita's std code 5119266 Force LLVM to use CMOV for binary search d6b6e63 stabilize const_waker 8e4f58a Add missing periods on `BTreeMap` cursor `peek_next` docs 458b9b0 Implement cursors for `BTreeSet` 02bf0de Enable `std::io::copy` specialisation for `std::pipe::{PipeReader, PipeWriter}` 1f83bf3 Rollup merge of rust-lang#128282 - pitaj:nonzero_bitwise, r=workingjubilee 357ff7a Rollup merge of rust-lang#128279 - slanterns:is_sorted, r=dtolnay fcbdcae stabilize `is_sorted` c47f8bd bitwise and bytewise methods on `NonZero` 4ea98d7 Rollup merge of rust-lang#128259 - sunshowers:msg-nosignal, r=Mark-Simulacrum d6f970a Rollup merge of rust-lang#125897 - RalfJung:from-ref, r=Amanieu 339f756 Auto merge of rust-lang#128255 - stepancheg:doc-shl, r=scottmcm 0d6a7dd Merge from rustc a66bc79 Auto merge of rust-lang#127946 - tgross35:fmt-builders-set-result, r=cuviper 2986bfe [illumos/solaris] set MSG_NOSIGNAL while writing to sockets 3e85493 Document int.checked_shl(BITS - 1) 59f3fef Rollup merge of rust-lang#128235 - harryscholes:fix-iterator-filter-docs, r=tgross35 a2dbfd3 Rollup merge of rust-lang#124941 - Skgland:stabilize-const-int-from-str, r=dtolnay 5b78bae Add links from `assert_eq!` docs to `debug_assert_eq!`, etc. a0f135d Always set `result` during `finish()` in debug builders bd11b3d Fix docs 22ce603 Auto merge of rust-lang#128165 - saethlin:optimize-clone-shims, r=compiler-errors fb7d2a8 Fix doc nits a152820 Rollup merge of rust-lang#128170 - saethlin:clone-fn, r=compiler-errors 0d63614 Merge from rustc cb8f69b Rollup merge of rust-lang#128211 - juliusl:pr/align-change-time, r=tgross35 ba0582b Rollup merge of rust-lang#128150 - BoxyUwU:std_only_sized_const_params, r=workingjubilee 30cfde4 Rollup merge of rust-lang#127950 - nnethercote:rustfmt-skip-on-use-decls, r=cuviper 8488ae6 Make Clone::clone a lang item 1342ef1 fix: compilation issue w/ refactored type 92c0ad7 Let InstCombine remove Clone shims inside Clone shims c788415 Stop using `unsized_const_parameters` in core/std ef4d4a0 Auto merge of rust-lang#128195 - matthiaskrgr:rollup-195dfdf, r=matthiaskrgr 5b6c1e1 Rollup merge of rust-lang#128137 - GrigorenkoPV:cstr-derive, r=dtolnay aaeac06 Rollup merge of rust-lang#127999 - ChrisDenton:arm32, r=Amanieu ea3a99f Rollup merge of rust-lang#128158 - workingjubilee:unsafe-wrap-personality-gcc, r=ChrisDenton 886fe5b Rollup merge of rust-lang#127300 - biabbas:fix_connect_timeout, r=tgross35 b889a1d CStr: derive PartialEq, Eq; add test for Ord 3a18110 In connect timeout, read readiness of socket for vxworks. Check pollhup or pollerr for refused connections in linux c4ee91f Merge from rustc 244d843 std: update comments on gcc personality fn d252b6b std: unsafe-wrap gcc::rust_eh_personality and impl 09bda4f Rollup merge of rust-lang#128135 - joboet:reduplicate_tls, r=tgross35 a4c88bc Rollup merge of rust-lang#128046 - GrigorenkoPV:90435, r=tgross35 2614d86 Rollup merge of rust-lang#126548 - rik86189:issue-88264-fix, r=tgross35 75a178f Rollup merge of rust-lang#126042 - davidzeng0:master, r=Amanieu 1e118ae Rollup merge of rust-lang#128131 - ChrisDenton:stuff, r=workingjubilee cea2ca9 Rollup merge of rust-lang#128120 - compiler-errors:async-fn-name, r=oli-obk 92e3688 Rollup merge of rust-lang#127733 - GrigorenkoPV:don't-forget, r=Amanieu 9b1cffd Rollup merge of rust-lang#127480 - biabbas:vxworks, r=workingjubilee 2632261 Rollup merge of rust-lang#127252 - fitzgen:edge-cases-for-bitwise-operations, r=m-ou-se b0d7414 Rollup merge of rust-lang#126152 - RalfJung:size_of_val_raw, r=saethlin 6d0b714 Improved clarity of documentation for std::fs::create_dir_all eb79e09 std: use duplicate thread local state in tests 8456a97 Forbid unsafe_op_in_unsafe_fn in sys/pal/windows 5a9fb1f Import `core::ffi::c_void` in more places 16450f7 Merge from rustc 697c717 Add chroot unsupported implementation for VxWorks 6242470 Rollup merge of rust-lang#128106 - hallfox:patch-1, r=ChrisDenton de086ea Rollup merge of rust-lang#128092 - ChrisDenton:wrappers, r=workingjubilee ccba33c Rollup merge of rust-lang#128043 - safinaskar:primitive, r=workingjubilee a069998 Rollup merge of rust-lang#127481 - a1phyr:pattern_gat, r=Amanieu bc7345c Rollup merge of rust-lang#126770 - wr7:master, r=Amanieu 21f6b65 Rollup merge of rust-lang#125962 - Coekjan:const-binary-heap, r=Amanieu eee5bba Auto merge of rust-lang#127153 - NobodyXu:pipe, r=ChrisDenton fd3a45f Gate AsyncFn* under async_closure feature 0374ea2 Add elem_offset and related methods 2b3eacb library/core/src/primitive.rs: small doc fix 45f80e6 Fix return type of FileAttr methods on AIX target 6cabb65 add `is_multiple_of` for unsigned integer types 4c4a93a Initial implementation of anonymous_pipe 63d2997 Update process vxworks, set default stack size of 256 Kib for vxworks. User can set the stack size using RUST_MIN_STACK, with min size of libc::PTHREAD_STACK_MIN(4kib) ee86041 Rollup merge of rust-lang#128089 - workingjubilee:commonly-wrapped-to-make-safe, r=ChrisDenton ad9a52d Rollup merge of rust-lang#125834 - workingjubilee:weaken-thir-unsafeck-for-addr-of-static-mut, r=compiler-errors 642c69b Remove wrapper functions from c.rs de2a037 std: Unsafe-wrap backtrace code held in-common 155aef9 std: Unsafe-wrap alloc code held in-common bee0155 Cfg disable on_broken_pipe_flag_used() for vxworks 227b5af Disable dirfd for vxworks, Return unsupported error from set_times and lchown for vxworks 22a6797 Allow unused unsafe for vxworks in read_at and write at 8be45a9 Docs for core::primitive: mention that "core" can be shadowed, too, so we should write "::core" c039ee8 library: vary unsafety in bootstrapping for SEH 6765b97 std: unsafe-wrap personality::dwarf::eh 7ae76f0 Rollup merge of rust-lang#128008 - weiznich:fix/121521, r=lcnr 323e962 Rollup merge of rust-lang#127996 - ian-h-chamberlain:fix/horizon-warnings-unsafe-in-unsafe, r=tgross35 ae6187f Rollup merge of rust-lang#127415 - AljoschaMeyer:master, r=dtolnay d6a36f5 Use given allocator instad of Global d0bc9a0 Start using `#[diagnostic::do_not_recommend]` in the standard library ba43261 Rollup merge of rust-lang#127583 - Nilstrieb:invalid-utf8, r=joboet 0727e53 Fix warnings when checking armv6k-nintendo-3ds bbe4da8 Fix some `#[cfg_attr(not(doc), repr(..))]` 321dbf8 Deal with invalid UTF-8 from `gai_strerror` 6aa00e1 std::thread: available_parallelism implementation for vxWorks proposal. 2fff48d Auto merge of rust-lang#127722 - BoxyUwU:new_adt_const_params_limitations, r=compiler-errors d7770e9 Rollup merge of rust-lang#128005 - ChrisDenton:msvc-include, r=joboet 8fdee23 Rollup merge of rust-lang#127734 - ChrisDenton:netc, r=Mark-Simulacrum 3b2536e Remove _tls_used hack 07dbb38 Rollup merge of rust-lang#127873 - workingjubilee:forbid-unsafe-ops-for-kmc-solid, r=Amanieu bd26295 Rollup merge of rust-lang#127843 - workingjubilee:break-up-big-ass-stack-overflow-fn, r=joboet 00b4f61 Inject win arm32 shims into metadata generation 2b62867 Rollup merge of rust-lang#127918 - ChrisDenton:thread-name-string, r=joboet a077eb1 Rollup merge of rust-lang#123196 - Ayush1325:uefi-process, r=joboet eb09be4 std: forbid unwrapped unsafe in unsupported_backslash dcb9854 kmc-solid: forbid(unsafe_op_in_unsafe_fn) 845a2f7 Auto merge of rust-lang#127982 - matthiaskrgr:rollup-nzyvphj, r=matthiaskrgr 00d6fc4 Rollup merge of rust-lang#127978 - nyurik:lib-refs, r=workingjubilee 4d8afcd Avoid ref when using format! for perf 9f20a0f Rollup merge of rust-lang#126199 - ivan-shrimp:nonzero_isqrt, r=tgross35 f06530c Rollup merge of rust-lang#112328 - juliusl:pr/windows-add-change-time, r=ChrisDenton 8d5cf50 uefi: process: Fixes from PR c6cb67c uefi: process: Final Touchups afe1ef0 uefi: process: Add CommandArgs support ef6b173 uefi: process: Add support for args 1991fe3 uefi: process Implement inherit 24a9582 uefi: process: Add null protocol 36a0e1e uefi: process: Add stderr support b712e74 uefi: process: Add support to capture stdout e6eeb4e uefi: Add process f3b1c8a improve safety comment 9348998 add `NonZero<uN>::isqrt` edc4cdc Use `#[rustfmt::skip]` on some `use` groups to prevent reordering. 489f1ef unix: acquire-load NEED_ALTSTACK 9e11e01 unix: Unsafe-wrap stack_overflow::{drop,make}_handler 72c7444 unix: Unsafe-wrap stack_overflow::cleanup 33a32f2 unix: lift init of sigaltstack before sigaction 9fb6e49 unix: Unsafe-wrap stack_overflow::signal_handler c99ebd4 Rollup merge of rust-lang#127594 - c6c7:fuchsia-status-code-match-arm, r=tmandry 8378261 Move ThreadName conversions to &cstr/&str 68e2391 Style change 16bce8a Make `Thread::new_inner` a safe function d1d9893 Rollup merge of rust-lang#127748 - scottmcm:option_len, r=joboet b0c85ba Rollup merge of rust-lang#124881 - Sp00ph:reentrant_lock_tid, r=joboet 7e21850 Update `ReentrantLock` implementation, add `CURRENT_ID` thread local. c10a929 Safely enforce thread name requirements cc4ed95 Rollup merge of rust-lang#127077 - tbu-:pr_doc_fd_to_owned, r=workingjubilee 37d7bff Rollup merge of rust-lang#127861 - Kriskras99:patch-1, r=tgross35 3d50720 Rollup merge of rust-lang#127859 - RalfJung:ptr-dyn-metadata, r=scottmcm 1f3311b Rollup merge of rust-lang#127845 - workingjubilee:actually-break-up-big-ass-stack-overflow-fn, r=joboet 5578593 Auto merge of rust-lang#127865 - matthiaskrgr:rollup-8m49dlg, r=matthiaskrgr 54728b1 feat: adding ext that returns change_time for Windows b164bab Auto merge of rust-lang#125942 - timokroeger:windows-once-futex, r=ChrisDenton 0eda3a3 Rollup merge of rust-lang#127337 - celinval:intrinsics-fallback, r=oli-obk ed3c6d1 Mention how you can go from `BorrowedFd` to `OwnedFd` and back 455bd57 Make language around `ToOwned` for `BorrowedFd` more precise ab7a0d4 Document the column numbers for the dbg! macro 89cd225 ptr::metadata: update comment on vtable_ptr work-around 51e54a4 ptr::metadata: avoid references to extern types be0c06b Split part of `adt_const_params` into `unsized_const_params` 857ed93 Forbid `!Sized` types and references aedc16c unix: unsafe-wrap install_main_guard_default 4db3aa1 unix: clean up install_main_guard_freebsd d167f00 unix: stack_start_aligned is a safe fn 27b79e6 unix: split stack_overflow::install_main_guard by os d50143f Update name of Windows abort constant to match platform documentation cbaa831 Add match arm for Fuchsia status code upon an abort in a test f15715f lib: replace some `mem::forget`'s with `ManuallyDrop` 9bbf09d Windows: move BSD socket shims to netc d76c965 Remove generic lifetime parameter of trait `Pattern` ad3db57 Use Option's discriminant as its size hint 3b86ae3 Explicitly ignore `into_raw_handle()` using `let _ =` in sys/pal/windows. 1cb5354 Add `must_use` to IntoRawFd/IntoRawSocket/IntoRawHandle's methods. 697377a Clarify/add `must_use` messages for more `into_raw*` functions of `alloc` types. a7bec56 size_of_val_raw: for length 0 this is safe to call 39c4daa Reset sigpipe not supported for vxworks ca537d2 Fix them doc examples some more be23cef Fix doc examples 8d01996 Run formatter on alloc/src/boxed.rs c3b602a Add missing try_new_uninit_slice_in and try_new_zeroed_slice_in 5487574 Document safety of a few intrinsics 87fcd2f Move a few intrinsics to use Rust abi 6b549ba mark `can_not_overflow` as `#[rustc_const_stable(...)]` 259c058 stabilize `const_int_from_str` 538fe81 Add edge-case examples to `{count,leading,trailing}_{ones,zeros}` methods 5fc66dd Implement `unsigned_signed_diff` dbbb4ab less garbage, more examples 4952644 update tracking issue for `const_binary_heap_new_in` 33389b0 more explicitly state the basic rules of working with the obtained raw pointers 395ad9f Windows: Use futex implementation for `Once` 7953644 from_ref, from_mut: clarify domain of quantification git-subtree-dir: library git-subtree-split: 9cc3bc6

notriddle and others added 23 commits July 1, 2024 18:03

rustdoc: click target for sidebar items flush left

5fc30b8

Move a few intrinsics to use Rust abi

52fb17a

Move a few more intrinsic functions to the convention added in rust-lang#121192 where they have Rust abi but are tagged with `rustc_intrinsic`.

Document safety of a few intrinsics

f27023a

Fix tests after intrinsic Abi change

b096c08

Remove the non-assigning form of unpack!

4fe8dd0

This kind of unpacking can be expressed as an ordinary method on `BlockAnd<()>`.

Stop using unpack! for BlockAnd<()>

1cf4eb2

Use ordinal number in argument error

332b41d

Fix error message Fix tests Format

Use dep: for crate dependencies

247ad33

Fix feature gating on rustc_index to not use implicit features

324d2e5

The rustc crate feature is called jemalloc

7e1c4af

rustdoc: make sidebar highlight cover whole click target

3924493

rustdoc: add test cases for mile wide bar

5514906

Remove invalid further restricting for type bound

40e07a3

add chenyukang to review rotation

2c2ef6c

Rollup merge of rust-lang#127769 - compiler-errors:ed-2024-dep, r=oli…

9db57bf

…-obk Don't use implicit features in `Cargo.toml` in `compiler/` Fixes compiler crates to stop using implicit features (rust-lang/cargo#12826) which are denied in in edition 2024.

Rollup merge of rust-lang#127855 - chenyukang:yukang-add-triagebot, r…

2ea21cf

…=jieyouxu Add myself to review rotation r? `@wesleywiser`

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 17, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 18, 2024

bors merged commit e35364a into rust-lang:master Jul 18, 2024
7 checks passed

rustbot added this to the 1.81.0 milestone Jul 18, 2024

This was referenced Jul 18, 2024

rustdoc: add header map to the table of contents #120736

Merged

[rustdoc] Add copy code feature #125779

Merged

Stop using the unpack! macro in MIR building #127416

Closed

Add a macro for defining intrinsics with the Rust ABI #127885

Closed

rustbot added the perf-regression Performance regression. label Jul 18, 2024

This comment has been minimized.

Sign in to view

matthiaskrgr deleted the rollup-8m49dlg branch September 1, 2024 17:35

jieyouxu added the CI-spurious-fail-msvc CI spurious failure: target env msvc label Oct 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #127865

Rollup of 8 pull requests #127865

matthiaskrgr commented Jul 17, 2024

rust-log-analyzer commented Jul 17, 2024

bors commented Jul 17, 2024

rust-log-analyzer commented Jul 17, 2024

bors commented Jul 17, 2024

matthiaskrgr commented Jul 17, 2024

bors commented Jul 17, 2024

bors commented Jul 18, 2024

rust-timer commented Jul 18, 2024

rust-timer commented Jul 18, 2024

Mark-Simulacrum commented Jul 22, 2024

This comment has been minimized.

Mark-Simulacrum commented Jul 22, 2024

rust-timer commented Jul 22, 2024

Rollup of 8 pull requests #127865

Rollup of 8 pull requests #127865

Conversation

matthiaskrgr commented Jul 17, 2024

rust-log-analyzer commented Jul 17, 2024

bors commented Jul 17, 2024

rust-log-analyzer commented Jul 17, 2024

bors commented Jul 17, 2024

matthiaskrgr commented Jul 17, 2024

bors commented Jul 17, 2024

bors commented Jul 18, 2024

rust-timer commented Jul 18, 2024

rust-timer commented Jul 18, 2024

Overall result: ❌ regressions - ACTION NEEDED

Mark-Simulacrum commented Jul 22, 2024

This comment has been minimized.

Mark-Simulacrum commented Jul 22, 2024

rust-timer commented Jul 22, 2024

Overall result: ❌ regressions - ACTION NEEDED