Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake #128356

Oneirical · 2024-07-29T18:13:56Z

Part of #121876 and the associated Google Summer of Code project.

This has the same problem outlined by #126180, where the tests do not actually run as no test-running CI enviroment has RUSTBUILD_FORCE_CLANG_BASED_TESTS set.

However, I still find it interesting to turn the Makefiles into the rmake format until the Clang issue is fixed.

This should technically be tested on MSVC... if MSVC actually ran Clang tests.

try-job: x86_64-gnu-debug

rustbot · 2024-07-29T18:14:04Z

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-07-29T18:14:06Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

The run-make-support library was changed

cc @jieyouxu

jieyouxu

Thanks for the PR. I'm not comfortable removing the old Makefile tests without them actually being tested in a CI job. I think what we can do is rename Makefile -> _Makefile so rmake.rs gets picked up if it is ever ran in a CI job, and put a FIXME in _Makefile to "remove me once rmake.rs version is tested in CI". It's also easy to revert if it ever causes a CI failure once a suitable CI does exercise it. I know it's technically present in commit history or git blame, but having the Makefile around seems useful considering we don't know if either version works...

jieyouxu · 2024-07-30T14:19:23Z

@rustbot author

Oneirical · 2024-07-30T15:32:19Z

Makefiles restored in inactivated format. @rustbot review

jieyouxu · 2024-07-30T16:16:51Z

@bors r+ rollup (this isnt tested in ci anyway)

bors · 2024-07-30T16:16:54Z

📌 Commit b7e90fe has been approved by jieyouxu

It is now in the queue for this repository.

…ieyouxu Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This has the same problem outlined by rust-lang#126180, where the tests do not actually run as no test-running CI enviroment has `RUSTBUILD_FORCE_CLANG_BASED_TESTS` set. However, I still find it interesting to turn the Makefiles into the rmake format until the Clang issue is fixed. This should technically be tested on MSVC... if MSVC actually ran Clang tests.

Rollup of 8 pull requests Successful merges: - rust-lang#125048 (PinCoerceUnsized trait into core) - rust-lang#127681 (derive(SmartPointer): rewrite bounds in where and generic bounds) - rust-lang#127830 (When an archive fails to build, print the path) - rust-lang#128147 (migrate fmt-write-bloat to rmake) - rust-lang#128356 (Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake) - rust-lang#128387 (More detailed note to deprecate ONCE_INIT) - rust-lang#128388 (Match LLVM ABI in `extern "C"` functions for `f128` on Windows) - rust-lang#128412 (Remove `crate_level_only` from `ELIDED_LIFETIMES_IN_PATHS`) r? `@ghost` `@rustbot` modify labels: rollup

…ieyouxu Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This has the same problem outlined by rust-lang#126180, where the tests do not actually run as no test-running CI enviroment has `RUSTBUILD_FORCE_CLANG_BASED_TESTS` set. However, I still find it interesting to turn the Makefiles into the rmake format until the Clang issue is fixed. This should technically be tested on MSVC... if MSVC actually ran Clang tests.

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#127681 (derive(SmartPointer): rewrite bounds in where and generic bounds) - rust-lang#127830 (When an archive fails to build, print the path) - rust-lang#128356 (Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake) - rust-lang#128387 (More detailed note to deprecate ONCE_INIT) - rust-lang#128388 (Match LLVM ABI in `extern "C"` functions for `f128` on Windows) - rust-lang#128412 (Remove `crate_level_only` from `ELIDED_LIFETIMES_IN_PATHS`) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2024-07-31T13:34:02Z

@bors r-

#128427 (comment)

Oneirical · 2024-08-02T15:54:36Z

Needed a rebase.

@bors try

bors · 2024-08-02T15:55:46Z

⌛ Trying commit 290a260 with merge 6cf9310...

Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This has the same problem outlined by rust-lang#126180, where the tests do not actually run as no test-running CI enviroment has `RUSTBUILD_FORCE_CLANG_BASED_TESTS` set. However, I still find it interesting to turn the Makefiles into the rmake format until the Clang issue is fixed. This should technically be tested on MSVC... if MSVC actually ran Clang tests. try-job: x86_64-gnu-debug

bors · 2024-08-02T17:34:56Z

☀️ Try build successful - checks-actions
Build commit: 6cf9310 (6cf9310627069f9a4556e53498d02c2f31d42f0f)

Oneirical · 2024-08-02T18:47:28Z

@rustbot ready

jieyouxu · 2024-08-02T21:59:54Z

Thanks!
@bors r+ rollup=iffy

bors · 2024-08-02T21:59:57Z

📌 Commit 290a260 has been approved by jieyouxu

It is now in the queue for this repository.

…ieyouxu Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This has the same problem outlined by rust-lang#126180, where the tests do not actually run as no test-running CI enviroment has `RUSTBUILD_FORCE_CLANG_BASED_TESTS` set. However, I still find it interesting to turn the Makefiles into the rmake format until the Clang issue is fixed. This should technically be tested on MSVC... if MSVC actually ran Clang tests. try-job: x86_64-gnu-debug

Rollup of 9 pull requests Successful merges: - rust-lang#126704 (Added SHA512, SM3, SM4 target-features and `sha512_sm_x86` feature gate) - rust-lang#127095 (Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake) - rust-lang#128107 (Migrate `raw-dylib-alt-calling-convention`, `raw-dylib-c` and `redundant-libs` `run-make` tests to rmake) - rust-lang#128161 (nested aux-build in tests/rustdoc/ tests) - rust-lang#128356 (Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake) - rust-lang#128404 (Revert recent changes to dead code analysis) - rust-lang#128483 (Still more `cfg` cleanups) - rust-lang#128528 (Finish removing `has_cpuid`) - rust-lang#128557 (chore: use shorthand initializer) r? `@ghost` `@rustbot` modify labels: rollup

…ieyouxu Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This has the same problem outlined by rust-lang#126180, where the tests do not actually run as no test-running CI enviroment has `RUSTBUILD_FORCE_CLANG_BASED_TESTS` set. However, I still find it interesting to turn the Makefiles into the rmake format until the Clang issue is fixed. This should technically be tested on MSVC... if MSVC actually ran Clang tests. try-job: x86_64-gnu-debug

Rollup of 10 pull requests Successful merges: - rust-lang#126704 (Added SHA512, SM3, SM4 target-features and `sha512_sm_x86` feature gate) - rust-lang#127095 (Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake) - rust-lang#127586 (Add `#[must_use]` to some `into_raw*` functions.) - rust-lang#128161 (nested aux-build in tests/rustdoc/ tests) - rust-lang#128303 (Enable `std::io::copy` specialisation for `std::pipe::{PipeReader, PipeWriter}`) - rust-lang#128356 (Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake) - rust-lang#128368 (Formatting tweaks) - rust-lang#128404 (Revert recent changes to dead code analysis) - rust-lang#128483 (Still more `cfg` cleanups) - rust-lang#128557 (chore: use shorthand initializer) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-08-03T08:07:03Z

⌛ Testing commit 290a260 with merge a604303...

bors · 2024-08-03T10:39:29Z

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing a604303 to master...

rust-timer · 2024-08-03T11:55:52Z

Finished benchmarking commit (a604303): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 758.6s -> 758.214s (-0.05%)
Artifact size: 336.80 MiB -> 336.79 MiB (-0.00%)

rustbot assigned jieyouxu Jul 29, 2024

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2024

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 29, 2024

Kobzol mentioned this pull request Jul 29, 2024

Tracking Issue for porting run-make tests to use Rust #121876

Open

jieyouxu approved these changes Jul 30, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2024

Oneirical force-pushed the real-estate-reaLTOr branch 2 times, most recently from 77afd3f to b7e90fe Compare July 30, 2024 15:31

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 30, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2024

tgross35 mentioned this pull request Jul 31, 2024

Rollup of 8 pull requests #128418

Closed

matthiaskrgr mentioned this pull request Jul 31, 2024

Rollup of 6 pull requests #128427

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 31, 2024

Oneirical added 2 commits August 2, 2024 11:53

rewrite cross-lang-lto-pgo-smoketest to rmake

560e86d

run cross-lang-lto-pgo-smoketest in CI by renaming it

290a260

Oneirical force-pushed the real-estate-reaLTOr branch from b61292f to 290a260 Compare August 2, 2024 15:54

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 2, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2024

jieyouxu mentioned this pull request Aug 2, 2024

Rollup of 10 pull requests #128574

Closed

jieyouxu mentioned this pull request Aug 2, 2024

Rollup of 9 pull requests #128575

Closed

jieyouxu mentioned this pull request Aug 3, 2024

Rollup of 10 pull requests #128577

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 3, 2024

bors merged commit a604303 into rust-lang:master Aug 3, 2024
7 checks passed

rustbot added this to the 1.82.0 milestone Aug 3, 2024

bors mentioned this pull request Aug 3, 2024

Migrate cdylib-dylib-linkage run-make test to rmake #128245

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake #128356

Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake #128356

Oneirical commented Jul 29, 2024 •

edited by jieyouxu

Loading

rustbot commented Jul 29, 2024

rustbot commented Jul 29, 2024

jieyouxu left a comment

jieyouxu commented Jul 30, 2024

Oneirical commented Jul 30, 2024

jieyouxu commented Jul 30, 2024

bors commented Jul 30, 2024

matthiaskrgr commented Jul 31, 2024

Oneirical commented Aug 2, 2024

bors commented Aug 2, 2024

bors commented Aug 2, 2024

Oneirical commented Aug 2, 2024

jieyouxu commented Aug 2, 2024

bors commented Aug 2, 2024

bors commented Aug 3, 2024

bors commented Aug 3, 2024

rust-timer commented Aug 3, 2024

Migrate cross-lang-lto-clang and cross-lang-lto-pgo-smoketest run-make tests to rmake #128356

Migrate cross-lang-lto-clang and cross-lang-lto-pgo-smoketest run-make tests to rmake #128356

Conversation

Oneirical commented Jul 29, 2024 • edited by jieyouxu Loading

rustbot commented Jul 29, 2024

rustbot commented Jul 29, 2024

jieyouxu left a comment

Choose a reason for hiding this comment

jieyouxu commented Jul 30, 2024

Oneirical commented Jul 30, 2024

jieyouxu commented Jul 30, 2024

bors commented Jul 30, 2024

matthiaskrgr commented Jul 31, 2024

Oneirical commented Aug 2, 2024

bors commented Aug 2, 2024

bors commented Aug 2, 2024

Oneirical commented Aug 2, 2024

jieyouxu commented Aug 2, 2024

bors commented Aug 2, 2024

bors commented Aug 3, 2024

bors commented Aug 3, 2024

rust-timer commented Aug 3, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake #128356

Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake #128356

Oneirical commented Jul 29, 2024 •

edited by jieyouxu

Loading