Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert recent changes to dead code analysis (this time, stable) #128618

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Aug 3, 2024

Hi -- I'd also like to backport the relevant changes from #128606 onto stable if possible, given that it's likely we're making a point release.

I'll open a zulip thread on T-release: #128618 for 1.80.1.

This would fix #128617, which is a 1.79->1.80 regression.

…9, r=petrochenkov"

This reverts commit 977c5fd, reversing
changes made to 24c94f0.
…nce, r=pnkfelix"

This reverts commit 13314df, reversing
changes made to 6e534c7.
@compiler-errors compiler-errors added the stable-nominated Nominated for backporting to the compiler in the stable channel. label Aug 3, 2024
@rustbot
Copy link
Collaborator

rustbot commented Aug 3, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 3, 2024
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
  LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.4/x64/lib
##[endgroup]
fatal: unknown commit origin/master
fatal: unknown commit origin/beta
All commits in `HEAD` are present in `master`
All commits in `HEAD` are present in `beta`
src/ci/scripts/verify-stable-version-number.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@pietroalbini pietroalbini added stable-accepted Accepted for backporting to the compiler in the stable channel. and removed stable-nominated Nominated for backporting to the compiler in the stable channel. labels Aug 6, 2024
@pietroalbini
Copy link
Member

Included in #128635.

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 6, 2024
Prepare Rust 1.80.1 point release

The point release is scheduled to include:

* rust-lang#128271
* rust-lang#128618
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 6, 2024
Prepare Rust 1.80.1 point release

The point release is scheduled to include:

* rust-lang#128271
* rust-lang#128618
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 6, 2024
Prepare Rust 1.80.1 point release

The point release is scheduled to include:

* rust-lang#128271
* rust-lang#128618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. stable-accepted Accepted for backporting to the compiler in the stable channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants