-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert recent changes to dead code analysis (this time, stable) #128618
Closed
compiler-errors
wants to merge
2
commits into
rust-lang:stable
from
compiler-errors:revert-dead-code-changes-stable
Closed
Revert recent changes to dead code analysis (this time, stable) #128618
compiler-errors
wants to merge
2
commits into
rust-lang:stable
from
compiler-errors:revert-dead-code-changes-stable
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compiler-errors
added
the
stable-nominated
Nominated for backporting to the compiler in the stable channel.
label
Aug 3, 2024
|
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Aug 3, 2024
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot)
|
wesleywiser
approved these changes
Aug 5, 2024
pietroalbini
added
stable-accepted
Accepted for backporting to the compiler in the stable channel.
and removed
stable-nominated
Nominated for backporting to the compiler in the stable channel.
labels
Aug 6, 2024
Included in #128635. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 6, 2024
Prepare Rust 1.80.1 point release The point release is scheduled to include: * rust-lang#128271 * rust-lang#128618
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 6, 2024
Prepare Rust 1.80.1 point release The point release is scheduled to include: * rust-lang#128271 * rust-lang#128618
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 6, 2024
Prepare Rust 1.80.1 point release The point release is scheduled to include: * rust-lang#128271 * rust-lang#128618
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
stable-accepted
Accepted for backporting to the compiler in the stable channel.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi -- I'd also like to backport the relevant changes from #128606 onto stable if possible, given that it's likely we're making a point release.
I'll open a zulip thread on T-release:
#128618 for 1.80.1
.This would fix #128617, which is a 1.79->1.80 regression.