Update Windows platform support #115141

ChrisDenton · 2023-08-23T17:56:34Z

This should not be merged until Rust 1.76 but I'm told this may need an fcp in addition to MCP 651.

cc @rust-lang/compiler @rust-lang/release

rustbot · 2023-08-23T17:56:40Z

(rustbot has picked a reviewer for you, use r? to override)

compiler-errors · 2023-08-23T18:12:40Z

Similarly to #104385 (comment), should this be a T-libs + T-compiler FCP, rather than T-compiler + T-release? I don't actually think we have a policy around bumping minimum support.

ChrisDenton · 2023-08-23T18:20:27Z

I have no idea. I'd really love to have some clarity on the procedure.

cuviper · 2023-08-23T18:25:08Z

The current target policy says:

Raising the baseline expectations of a tier 1 target (such as the minimum CPU features or OS version required) requires the approval of the compiler and release teams, and should be widely communicated as well, but does not necessarily require a full RFC.

(I'm not opposed to including T-libs, just quoting what we have.)

ehuss · 2023-09-10T17:13:41Z

I'm not sure who to assign.

r? @compiler-errors

bors · 2023-09-24T04:38:54Z

☔ The latest upstream changes (presumably #104385) made this pull request unmergeable. Please resolve the merge conflicts.

compiler-errors · 2023-09-28T22:38:38Z

Sure let's do an FCP. See MCP for details.

@rfcbot fcp merge

rfcbot · 2023-09-28T22:38:39Z

petrochenkov · 2023-10-04T08:52:25Z

@rfcbot concern needs-blog-post

molecula451 · 2023-10-04T08:55:05Z

is this in part a deprecation of Windows 7 official support?

ChrisDenton · 2023-10-04T13:22:03Z

needs-blog-post

Just to note, the intent to update Windows compatibility was announced in the Rust 1.72.0 blog post, which was a light release so there was some discussion.

slanterns · 2024-02-05T12:44:07Z

I think this PR should be merged with (and backport to) the 1.76 release this week to avoid confusion like the MIPS demotion.
(edit: since there's actually no concrete change and the target can still work on Windows 7, waiting for the next release seems also fine.)

ChrisDenton · 2024-02-09T16:27:13Z

A blog post is being prepared if anyone has any final comments. I don't know if anyone has any thoughts on post date for the blog. I'm thinking soon.

ChrisDenton · 2024-02-26T22:08:15Z

As noted by @dpaoliello, we don't officially support XP even at tier 3 so I've also removed that. Of course no_std XP may work but it's not special in that regard. People have managed to compile Rust programs for old Windows versions at least as far back as Win95, which is great but not something that the Rust project currently supports in an official capacity.

rfcbot · 2024-03-10T15:24:50Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

rustbot · 2024-03-10T15:36:12Z

These commits modify compiler targets.
(See the Target Tier Policy.)

ChrisDenton · 2024-03-10T15:37:10Z

Rebased.

bors · 2024-03-11T14:59:11Z

☔ The latest upstream changes (presumably #122305) made this pull request unmergeable. Please resolve the merge conflicts.

dpaoliello · 2024-03-11T17:54:44Z

FYI, I used the Windows targets as examples when filling out the description field in the targets, so you'll need to update the text there to: d6b597b

ChrisDenton · 2024-03-11T18:00:10Z

I think I sneaked that in before your comment, no?

dpaoliello · 2024-03-11T18:41:59Z

I think I sneaked that in before your comment, no?

Ah, you did, my bad for not checking the files...

ChrisDenton · 2024-03-11T18:43:19Z

I probably should have made a new commit. But I am a fan of having a clean commit history 😁

wesleywiser · 2024-03-11T19:54:40Z

The FCP has concluded, therefore:

@bors r+ rollup

bors · 2024-03-11T19:54:43Z

📌 Commit 779ac69 has been approved by wesleywiser

It is now in the queue for this repository.

…leywiser Update Windows platform support This should not be merged until Rust 1.76 but I'm told this may need an fcp in addition to [MCP 651](rust-lang/compiler-team#651). cc `@rust-lang/compiler` `@rust-lang/release`

…leywiser Update Windows platform support This should not be merged until Rust 1.76 but I'm told this may need an fcp in addition to [MCP 651](rust-lang/compiler-team#651). cc ``@rust-lang/compiler`` ``@rust-lang/release``

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#115141 (Update Windows platform support) - rust-lang#121865 (Add FileCheck annotations to MIR-opt unnamed-fields tests) - rust-lang#122000 (Fix 32-bit overflows in LLVM composite constants) - rust-lang#122194 (Enable creating backtraces via -Ztreat-err-as-bug when stashing errors) - rust-lang#122319 (Don't ICE when non-self part of trait goal is constrained in new solver) - rust-lang#122339 (Update books) - rust-lang#122342 (Update /NODEFAUTLIB comment for msvc) - rust-lang#122343 (Remove some unnecessary `allow(incomplete_features)` in the test suite) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#115141 - ChrisDenton:windows-support, r=wesleywiser Update Windows platform support This should not be merged until Rust 1.76 but I'm told this may need an fcp in addition to [MCP 651](rust-lang/compiler-team#651). cc ```@rust-lang/compiler``` ```@rust-lang/release```

Pkgsrc changes: * Adapt checksums and patches, some have beene intregrated upstream. Upstream chnages: Version 1.78.0 (2024-05-02) =========================== Language -------- - [Stabilize `#[cfg(target_abi = ...)]`] (rust-lang/rust#119590) - [Stabilize the `#[diagnostic]` namespace and `#[diagnostic::on_unimplemented]` attribute] (rust-lang/rust#119888) - [Make async-fn-in-trait implementable with concrete signatures] (rust-lang/rust#120103) - [Make matching on NaN a hard error, and remove the rest of `illegal_floating_point_literal_pattern`] (rust-lang/rust#116284) - [static mut: allow mutable reference to arbitrary types, not just slices and arrays] (rust-lang/rust#117614) - [Extend `invalid_reference_casting` to include references casting to bigger memory layout] (rust-lang/rust#118983) - [Add `non_contiguous_range_endpoints` lint for singleton gaps after exclusive ranges] (rust-lang/rust#118879) - [Add `wasm_c_abi` lint for use of older wasm-bindgen versions] (rust-lang/rust#117918) This lint currently only works when using Cargo. - [Update `indirect_structural_match` and `pointer_structural_match` lints to match RFC] (rust-lang/rust#120423) - [Make non-`PartialEq`-typed consts as patterns a hard error] (rust-lang/rust#120805) - [Split `refining_impl_trait` lint into `_reachable`, `_internal` variants] (rust-lang/rust#121720) - [Remove unnecessary type inference when using associated types inside of higher ranked `where`-bounds] (rust-lang/rust#119849) - [Weaken eager detection of cyclic types during type inference] (rust-lang/rust#119989) - [`trait Trait: Auto {}`: allow upcasting from `dyn Trait` to `dyn Auto`] (rust-lang/rust#119338) Compiler -------- - [Made `INVALID_DOC_ATTRIBUTES` lint deny by default] (rust-lang/rust#111505) - [Increase accuracy of redundant `use` checking] (rust-lang/rust#117772) - [Suggest moving definition if non-found macro_rules! is defined later] (rust-lang/rust#121130) - [Lower transmutes from int to pointer type as gep on null] (rust-lang/rust#121282) Target changes: - [Windows tier 1 targets now require at least Windows 10] (rust-lang/rust#115141) - [Enable CMPXCHG16B, SSE3, SAHF/LAHF and 128-bit Atomics in tier 1 Windows] (rust-lang/rust#120820) - [Add `wasm32-wasip1` tier 2 (without host tools) target] (rust-lang/rust#120468) - [Add `wasm32-wasip2` tier 3 target] (rust-lang/rust#119616) - [Rename `wasm32-wasi-preview1-threads` to `wasm32-wasip1-threads`] (rust-lang/rust#122170) - [Add `arm64ec-pc-windows-msvc` tier 3 target] (rust-lang/rust#119199) - [Add `armv8r-none-eabihf` tier 3 target for the Cortex-R52] (rust-lang/rust#110482) - [Add `loongarch64-unknown-linux-musl` tier 3 target] (rust-lang/rust#121832) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Bump Unicode to version 15.1.0, regenerate tables] (rust-lang/rust#120777) - [Make align_offset, align_to well-behaved in all cases] (rust-lang/rust#121201) - [PartialEq, PartialOrd: document expectations for transitive chains] (rust-lang/rust#115386) - [Optimize away poison guards when std is built with panic=abort] (rust-lang/rust#100603) - [Replace pthread `RwLock` with custom implementation] (rust-lang/rust#110211) - [Implement unwind safety for Condvar on all platforms] (rust-lang/rust#121768) - [Add ASCII fast-path for `char::is_grapheme_extended`] (rust-lang/rust#121138) Stabilized APIs --------------- - [`impl Read for &Stdin`] (https://doc.rust-lang.org/stable/std/io/struct.Stdin.html#impl-Read-for-%26Stdin) - [Accept non `'static` lifetimes for several `std::error::Error` related implementations] (rust-lang/rust#113833) - [Make `impl<Fd: AsFd>` impl take `?Sized`] (rust-lang/rust#114655) - [`impl From<TryReserveError> for io::Error`] (https://doc.rust-lang.org/stable/std/io/struct.Error.html#impl-From%3CTryReserveError%3E-for-Error) These APIs are now stable in const contexts: - [`Barrier::new()`] (https://doc.rust-lang.org/stable/std/sync/struct.Barrier.html#method.new) Cargo ----- - [Stabilize lockfile v4](rust-lang/cargo#12852) - [Respect `rust-version` when generating lockfile] (rust-lang/cargo#12861) - [Control `--charset` via auto-detecting config value] (rust-lang/cargo#13337) - [Support `target.<triple>.rustdocflags` officially] (rust-lang/cargo#13197) - [Stabilize global cache data tracking] (rust-lang/cargo#13492) Misc ---- - [rustdoc: add `--test-builder-wrapper` arg to support wrappers such as RUSTC_WRAPPER when building doctests] (rust-lang/rust#114651) Compatibility Notes ------------------- - [Many unsafe precondition checks now run for user code with debug assertions enabled] (rust-lang/rust#120594) This change helps users catch undefined behavior in their code, though the details of how much is checked are generally not stable. - [riscv only supports split_debuginfo=off for now] (rust-lang/rust#120518) - [Consistently check bounds on hidden types of `impl Trait`] (rust-lang/rust#121679) - [Change equality of higher ranked types to not rely on subtyping] (rust-lang/rust#118247) - [When called, additionally check bounds on normalized function return type] (rust-lang/rust#118882) - [Expand coverage for `arithmetic_overflow` lint] (rust-lang/rust#119432) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Update to LLVM 18](rust-lang/rust#120055) - [Build `rustc` with 1CGU on `x86_64-pc-windows-msvc`] (rust-lang/rust#112267) - [Build `rustc` with 1CGU on `x86_64-apple-darwin`] (rust-lang/rust#112268) - [Introduce `run-make` V2 infrastructure, a `run_make_support` library and port over 2 tests as example] (rust-lang/rust#113026) - [Windows: Implement condvar, mutex and rwlock using futex] (rust-lang/rust#121956)

rustbot assigned ehuss Aug 23, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 23, 2023

rustbot assigned compiler-errors and unassigned ehuss Sep 10, 2023

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Sep 28, 2023

compiler-errors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2023

slanterns mentioned this pull request Feb 5, 2024

Release notes for 1.76 #120004

Merged

ChrisDenton mentioned this pull request Feb 26, 2024

Update platform support docs for new Windows support policy #121645

Closed

ChrisDenton force-pushed the windows-support branch 2 times, most recently from e4b75da to b711bb2 Compare February 26, 2024 22:04

rfcbot added the to-announce Announce this issue on triage meeting label Mar 10, 2024

ChrisDenton force-pushed the windows-support branch from b711bb2 to d7045ea Compare March 10, 2024 15:36

Update Windows platform support

779ac69

ChrisDenton force-pushed the windows-support branch from d7045ea to 779ac69 Compare March 11, 2024 17:51

wesleywiser approved these changes Mar 11, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 11, 2024

matthiaskrgr mentioned this pull request Mar 11, 2024

Rollup of 8 pull requests #122350

Closed

workingjubilee mentioned this pull request Mar 11, 2024

Rollup of 1 pull requests #122351

Closed

matthiaskrgr mentioned this pull request Mar 12, 2024

Rollup of 8 pull requests #122365

Merged

bors merged commit 60ab300 into rust-lang:master Mar 12, 2024
11 checks passed

rustbot added this to the 1.78.0 milestone Mar 12, 2024

wesleywiser added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 12, 2024

apiraino removed the to-announce Announce this issue on triage meeting label Mar 14, 2024

bunnie mentioned this pull request May 11, 2024

Window always renders white on Windows 11 in release build. emoon/rust_minifb#351

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Windows platform support #115141

Update Windows platform support #115141

ChrisDenton commented Aug 23, 2023

rustbot commented Aug 23, 2023

compiler-errors commented Aug 23, 2023

ChrisDenton commented Aug 23, 2023

cuviper commented Aug 23, 2023 •

edited

Loading

ehuss commented Sep 10, 2023

bors commented Sep 24, 2023

compiler-errors commented Sep 28, 2023

rfcbot commented Sep 28, 2023 •

edited by Aaron1011

Loading

petrochenkov commented Oct 4, 2023

molecula451 commented Oct 4, 2023

ChrisDenton commented Oct 4, 2023

slanterns commented Feb 5, 2024 •

edited

Loading

ChrisDenton commented Feb 9, 2024

ChrisDenton commented Feb 26, 2024 •

edited

Loading

rfcbot commented Mar 10, 2024

rustbot commented Mar 10, 2024

ChrisDenton commented Mar 10, 2024

bors commented Mar 11, 2024

dpaoliello commented Mar 11, 2024

ChrisDenton commented Mar 11, 2024

dpaoliello commented Mar 11, 2024

ChrisDenton commented Mar 11, 2024

wesleywiser commented Mar 11, 2024

bors commented Mar 11, 2024

Update Windows platform support #115141

Update Windows platform support #115141

Conversation

ChrisDenton commented Aug 23, 2023

rustbot commented Aug 23, 2023

compiler-errors commented Aug 23, 2023

ChrisDenton commented Aug 23, 2023

cuviper commented Aug 23, 2023 • edited Loading

ehuss commented Sep 10, 2023

bors commented Sep 24, 2023

compiler-errors commented Sep 28, 2023

rfcbot commented Sep 28, 2023 • edited by Aaron1011 Loading

petrochenkov commented Oct 4, 2023

molecula451 commented Oct 4, 2023

ChrisDenton commented Oct 4, 2023

slanterns commented Feb 5, 2024 • edited Loading

ChrisDenton commented Feb 9, 2024

ChrisDenton commented Feb 26, 2024 • edited Loading

rfcbot commented Mar 10, 2024

rustbot commented Mar 10, 2024

ChrisDenton commented Mar 10, 2024

bors commented Mar 11, 2024

dpaoliello commented Mar 11, 2024

ChrisDenton commented Mar 11, 2024

dpaoliello commented Mar 11, 2024

ChrisDenton commented Mar 11, 2024

wesleywiser commented Mar 11, 2024

bors commented Mar 11, 2024

cuviper commented Aug 23, 2023 •

edited

Loading

rfcbot commented Sep 28, 2023 •

edited by Aaron1011

Loading

slanterns commented Feb 5, 2024 •

edited

Loading

ChrisDenton commented Feb 26, 2024 •

edited

Loading