Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FileCheck annotations to MIR-opt unnamed-fields tests #121865

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Add FileCheck annotations to MIR-opt unnamed-fields tests #121865

merged 3 commits into from
Mar 12, 2024

Conversation

Kirandevraj
Copy link
Contributor

Part of #116971
Adds filecheck annotations to unnamed-fields mir-opt tests in tests/mir-opt/unnamed-fields

@rustbot
Copy link
Collaborator

rustbot commented Mar 1, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2024
@Kirandevraj
Copy link
Contributor Author

Can you share pointers/resources to improve the CHECK commands for filechecks in test cases.

@Mark-Simulacrum
Copy link
Member

r? mir-opt

I don't have the knowledge to effectively review the added test conditions, though it looks reasonable enough to me.

Can you share pointers/resources to improve the CHECK commands for filechecks in test cases.

I'm not sure I understand the question. Do you mean docs on the filecheck syntax? Or something else?

@rustbot rustbot assigned oli-obk and unassigned Mark-Simulacrum Mar 9, 2024
@Kirandevraj
Copy link
Contributor Author

I'm not sure I understand the question. Do you mean docs on the filecheck syntax? Or something else?

Yes, for filecheck syntax.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 11, 2024

Yes, for filecheck syntax.

the closest we have is https://github.com/rust-lang/rust/blob/master/tests/mir-opt/README.md#filecheck-directives, which is very sparse, so if you figure out something useful, don't hesitate to add it to that file

@oli-obk
Copy link
Contributor

oli-obk commented Mar 11, 2024

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 11, 2024

📌 Commit ba70528 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 11, 2024
@matthiaskrgr
Rollup merge of rust-lang#121865 - Kirandevraj:unnamed-fields-fileche…
8fb5cda 
…ck, r=oli-obk

Add FileCheck annotations to MIR-opt unnamed-fields tests

Part of rust-lang#116971
Adds filecheck annotations to unnamed-fields mir-opt tests in `tests/mir-opt/unnamed-fields`
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 11, 2024
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 11, 2024
@workingjubilee
Rollup merge of rust-lang#121865 - Kirandevraj:unnamed-fields-fileche…
beff7e4 
…ck, r=oli-obk

Add FileCheck annotations to MIR-opt unnamed-fields tests

Part of rust-lang#116971
Adds filecheck annotations to unnamed-fields mir-opt tests in `tests/mir-opt/unnamed-fields`
@workingjubilee workingjubilee mentioned this pull request Mar 11, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 12, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2024
@bors
Auto merge of rust-lang#122365 - matthiaskrgr:rollup-4i350h6, r=matth…
b0170b6 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#115141 (Update Windows platform support)
 - rust-lang#121865 (Add FileCheck annotations to MIR-opt unnamed-fields tests)
 - rust-lang#122000 (Fix 32-bit overflows in LLVM composite constants)
 - rust-lang#122194 (Enable creating backtraces via -Ztreat-err-as-bug when stashing errors)
 - rust-lang#122319 (Don't ICE when non-self part of trait goal is constrained in new solver)
 - rust-lang#122339 (Update books)
 - rust-lang#122342 (Update /NODEFAUTLIB comment for msvc)
 - rust-lang#122343 (Remove some unnecessary `allow(incomplete_features)` in the test suite)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b4cbc88 into rust-lang:master Mar 12, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 12, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 12, 2024
@rust-timer
Unrolled build for rust-lang#121865
479e8aa 
Rollup merge of rust-lang#121865 - Kirandevraj:unnamed-fields-filecheck, r=oli-obk

Add FileCheck annotations to MIR-opt unnamed-fields tests

Part of rust-lang#116971
Adds filecheck annotations to unnamed-fields mir-opt tests in `tests/mir-opt/unnamed-fields`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Kirandevraj @rustbot @Mark-Simulacrum @oli-obk @bors @cjgillot