Enable creating backtraces via -Ztreat-err-as-bug when stashing errors #122194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
nnethercote
reviewed
Mar 8, 2024
| #[allow(deprecated)] | ||
| Some(ErrorGuaranteed::unchecked_error_guaranteed()) | ||
| } | ||
| Error => Some(self.span_delayed_bug(span, "stashing {key:?}")), |
There was a problem hiding this comment.
Stashed diagnostics, argh, such a PITA.
Having to create a delayed bug for every single one is unfortunate. Is it possible to only do that when -Ztreat-err-as-bug is enabled? You haven't described the debugging much so I'm only guessing at what you're doing. Also a brief comment here explaining why a delayed bug is preferable to an unchecked ErrorGuarantee would be useful.
There was a problem hiding this comment.
I actually like the use of span_delayed_bug over unchecked_error_guaranteed, and it's not like it's a perf issue
oli-obk
force-pushed
the
stash_delay_bug
branch
from
5126465
to
cfbc1b9
Compare
|
Eh, fine. @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 12, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#115141 (Update Windows platform support) - rust-lang#121865 (Add FileCheck annotations to MIR-opt unnamed-fields tests) - rust-lang#122000 (Fix 32-bit overflows in LLVM composite constants) - rust-lang#122194 (Enable creating backtraces via -Ztreat-err-as-bug when stashing errors) - rust-lang#122319 (Don't ICE when non-self part of trait goal is constrained in new solver) - rust-lang#122339 (Update books) - rust-lang#122342 (Update /NODEFAUTLIB comment for msvc) - rust-lang#122343 (Remove some unnecessary `allow(incomplete_features)` in the test suite) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 12, 2024
Rollup merge of rust-lang#122194 - oli-obk:stash_delay_bug, r=nnethercote Enable creating backtraces via -Ztreat-err-as-bug when stashing errors r? `@nnethercote` Otherwise I can't debug stashed errors because I can't find their source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nnethercote
Otherwise I can't debug stashed errors because I can't find their source