Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update platform support docs for new Windows support policy #121645

Closed
wants to merge 1 commit into from

Conversation

dpaoliello
Copy link
Contributor

rust-lang/compiler-team#651 established that Rust version 1.76+ will only support Windows 10+ as a tier 1 target and introduces new win7 targets for older versions of Windows.

This change updates the platform support docs to reflect that decision, and removes entries for the "Windows XP" targets which appeared to just be the normal Windows targets?

@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2024

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 26, 2024
@dpaoliello
Copy link
Contributor Author

r? @ChrisDenton

@ChrisDenton
Copy link
Member

ChrisDenton commented Feb 26, 2024

I also have a PR but that's blocked on having a blog post, which I wrote, but that is blocked on, I think, someone deciding when to publish. It was also decided to push this change back to 1.78 so that there wouldn't be a need to backport documentation.

Good call on the XP thing though. It doesn't really make sense to have it as a tier 3 target when there's no support (though of course no_std can still be made to work).

@dpaoliello
Copy link
Contributor Author

@ChrisDenton might be worth adding a note to https://blog.rust-lang.org/2023/08/24/Rust-1.72.0.html#future-windows-compatibility to say that the plan has been changed.

Do you want me to keep this PR for Windows XP, or will you merge that into yours?

@ChrisDenton
Copy link
Member

It's probably easier if I update my PR rather than having two.

might be worth adding a note to https://blog.rust-lang.org/2023/08/24/Rust-1.72.0.html#future-windows-compatibility to say that the plan has been changed.

I don't know if we usually update old blog posts, cc @wesleywiser

@dpaoliello
Copy link
Contributor Author

Closing in favor of #115141

@dpaoliello dpaoliello closed this Feb 26, 2024
@wesleywiser
Copy link
Member

It's probably easier if I update my PR rather than having two.

might be worth adding a note to https://blog.rust-lang.org/2023/08/24/Rust-1.72.0.html#future-windows-compatibility to say that the plan has been changed.

I don't know if we usually update old blog posts, cc @wesleywiser

I think updating old blog posts for the purpose of reducing confusion is good, we should just be careful to make it obvious that the post was edited after the fact, rather than always containing the new information.

@dpaoliello dpaoliello deleted the win10 branch February 26, 2024 22:02
@ChrisDenton
Copy link
Member

I wrote a short update to the original announcement rust-lang/blog.rust-lang.org#1262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants