run-make: enable msvc for `link-dedup` #128638

ChrisDenton · 2024-08-04T11:11:44Z

This is just a case of differing style of linker arguments.

I also cleaned up a bit where we were running the same command three times in a row. Instead I reused the output.

One thing that confused me is why we were testing for the same lib three times in a row but not two. After figuring that out I added a note to hopefully save future readers some confusion.

try-job: x86_64-msvc
try-job: i686-msvc

rustbot · 2024-08-04T11:11:50Z

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-08-04T11:11:52Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

ChrisDenton · 2024-08-04T11:14:43Z

@bors try

run-make: enable msvc for `link-dedup` This is just a case of differing style of linker arguments. I also cleaned up a bit where we were running the same command three times in a row. Instead I reused the output. One thing that confused me is why we were testing for the same lib three times in a row but not two. After figuring that out I added a note to hopefully save future readers some confusion. try-job: x86_64-msvc try-job: i686-msvc

bors · 2024-08-04T11:15:53Z

⌛ Trying commit 74c9235 with merge f6220e2...

jieyouxu

Thanks! I just have some questions, but r=me if the try jobs come back green.

tests/run-make/link-dedup/rmake.rs

bors · 2024-08-04T11:23:46Z

💔 Test failed - checks-actions

jieyouxu · 2024-08-04T11:24:04Z

(Apparently that try job requires tidy to pass 😅 )

ChrisDenton · 2024-08-04T11:24:34Z

I was only a little over the line length limit 😔

ChrisDenton · 2024-08-04T11:35:02Z

@bors try

run-make: enable msvc for `link-dedup` This is just a case of differing style of linker arguments. I also cleaned up a bit where we were running the same command three times in a row. Instead I reused the output. One thing that confused me is why we were testing for the same lib three times in a row but not two. After figuring that out I added a note to hopefully save future readers some confusion. try-job: x86_64-msvc try-job: i686-msvc

bors · 2024-08-04T11:36:13Z

⌛ Trying commit d8c2b76 with merge 2839873...

bors · 2024-08-04T13:25:52Z

☀️ Try build successful - checks-actions
Build commit: 2839873 (28398730e8046da3408574fa3b9ed11f802b1977)

ChrisDenton · 2024-08-04T13:48:35Z

@bors r=jieyouxu rollup

bors · 2024-08-04T13:48:37Z

📌 Commit d8c2b76 has been approved by jieyouxu

It is now in the queue for this repository.

run-make: enable msvc for `link-dedup` This is just a case of differing style of linker arguments. I also cleaned up a bit where we were running the same command three times in a row. Instead I reused the output. One thing that confused me is why we were testing for the same lib three times in a row but not two. After figuring that out I added a note to hopefully save future readers some confusion. try-job: x86_64-msvc try-job: i686-msvc

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#127655 (turn `invalid_type_param_default` into a `FutureReleaseErrorReportInDeps`) - rust-lang#127974 (force compiling std from source if modified) - rust-lang#128026 (std::thread: available_parallelism implementation for vxWorks proposal.) - rust-lang#128362 (add test for symbol visibility of `#[naked]` functions) - rust-lang#128500 (Add test for updating enum discriminant through pointer) - rust-lang#128630 (docs(resolve): more explain about `target`) - rust-lang#128638 (run-make: enable msvc for `link-dedup`) r? `@ghost` `@rustbot` modify labels: rollup

run-make: enable msvc for `link-dedup` This is just a case of differing style of linker arguments. I also cleaned up a bit where we were running the same command three times in a row. Instead I reused the output. One thing that confused me is why we were testing for the same lib three times in a row but not two. After figuring that out I added a note to hopefully save future readers some confusion. try-job: x86_64-msvc try-job: i686-msvc

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#127655 (turn `invalid_type_param_default` into a `FutureReleaseErrorReportInDeps`) - rust-lang#127974 (force compiling std from source if modified) - rust-lang#128026 (std::thread: available_parallelism implementation for vxWorks proposal.) - rust-lang#128309 (Implement cursors for `BTreeSet`) - rust-lang#128500 (Add test for updating enum discriminant through pointer) - rust-lang#128630 (docs(resolve): more explain about `target`) - rust-lang#128631 (handle crates when they are not specified for std docs) - rust-lang#128638 (run-make: enable msvc for `link-dedup`) r? `@ghost` `@rustbot` modify labels: rollup

run-make: enable msvc for `link-dedup` This is just a case of differing style of linker arguments. I also cleaned up a bit where we were running the same command three times in a row. Instead I reused the output. One thing that confused me is why we were testing for the same lib three times in a row but not two. After figuring that out I added a note to hopefully save future readers some confusion. try-job: x86_64-msvc try-job: i686-msvc

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#127655 (turn `invalid_type_param_default` into a `FutureReleaseErrorReportInDeps`) - rust-lang#127974 (force compiling std from source if modified) - rust-lang#128026 (std::thread: available_parallelism implementation for vxWorks proposal.) - rust-lang#128309 (Implement cursors for `BTreeSet`) - rust-lang#128500 (Add test for updating enum discriminant through pointer) - rust-lang#128630 (docs(resolve): more explain about `target`) - rust-lang#128638 (run-make: enable msvc for `link-dedup`) r? `@ghost` `@rustbot` modify labels: rollup

run-make: enable msvc for `link-dedup` This is just a case of differing style of linker arguments. I also cleaned up a bit where we were running the same command three times in a row. Instead I reused the output. One thing that confused me is why we were testing for the same lib three times in a row but not two. After figuring that out I added a note to hopefully save future readers some confusion. try-job: x86_64-msvc try-job: i686-msvc

…enton Rollup of 11 pull requests Successful merges: - rust-lang#128026 (std::thread: available_parallelism implementation for vxWorks proposal.) - rust-lang#128471 (rustdoc: Fix handling of `Self` type in search index and refactor its representation) - rust-lang#128607 (Use `object` in `run-make/symbols-visibility`) - rust-lang#128609 (Remove unnecessary constants from flt2dec dragon) - rust-lang#128611 (run-make: Remove cygpath) - rust-lang#128630 (docs(resolve): more explain about `target`) - rust-lang#128638 (run-make: enable msvc for `link-dedup`) - rust-lang#128647 (Enable msvc for link-args-order) - rust-lang#128649 (run-make: Enable msvc for `no-duplicate-libs` and `zero-extend-abi-param-passing`) - rust-lang#128656 (Enable msvc for run-make/rust-lld) - rust-lang#128660 (tests: more crashes) r? `@ghost` `@rustbot` modify labels: rollup

run-make: enable msvc for `link-dedup` This is just a case of differing style of linker arguments. I also cleaned up a bit where we were running the same command three times in a row. Instead I reused the output. One thing that confused me is why we were testing for the same lib three times in a row but not two. After figuring that out I added a note to hopefully save future readers some confusion. try-job: x86_64-msvc try-job: i686-msvc

Rollup of 8 pull requests Successful merges: - rust-lang#122049 (Promote riscv64gc-unknown-linux-musl to tier 2) - rust-lang#125558 (Tweak type inference for `const` operands in inline asm) - rust-lang#128638 (run-make: enable msvc for `link-dedup`) - rust-lang#128647 (Enable msvc for link-args-order) - rust-lang#128649 (run-make: Enable msvc for `no-duplicate-libs` and `zero-extend-abi-param-passing`) - rust-lang#128656 (Enable msvc for run-make/rust-lld) - rust-lang#128688 (custom MIR: add support for tail calls) - rust-lang#128691 (Update `compiler-builtins` to 0.1.115) r? `@ghost` `@rustbot` modify labels: rollup

run-make: enable msvc for `link-dedup` This is just a case of differing style of linker arguments. I also cleaned up a bit where we were running the same command three times in a row. Instead I reused the output. One thing that confused me is why we were testing for the same lib three times in a row but not two. After figuring that out I added a note to hopefully save future readers some confusion. try-job: x86_64-msvc try-job: i686-msvc

Rollup of 7 pull requests Successful merges: - rust-lang#128107 (Migrate `raw-dylib-alt-calling-convention`, `raw-dylib-c` and `redundant-libs` `run-make` tests to rmake) - rust-lang#128362 (add test for symbol visibility of `#[naked]` functions) - rust-lang#128417 (Add `f16` and `f128` math functions) - rust-lang#128638 (run-make: enable msvc for `link-dedup`) - rust-lang#128647 (Enable msvc for link-args-order) - rust-lang#128649 (run-make: Enable msvc for `no-duplicate-libs` and `zero-extend-abi-param-passing`) - rust-lang#128766 (Trivial grammar fix in const keyword docs) r? `@ghost` `@rustbot` modify labels: rollup

run-make: enable msvc for `link-dedup` This is just a case of differing style of linker arguments. I also cleaned up a bit where we were running the same command three times in a row. Instead I reused the output. One thing that confused me is why we were testing for the same lib three times in a row but not two. After figuring that out I added a note to hopefully save future readers some confusion. try-job: x86_64-msvc try-job: i686-msvc

Rollup merge of rust-lang#128638 - ChrisDenton:link-dedup, r=jieyouxu run-make: enable msvc for `link-dedup` This is just a case of differing style of linker arguments. I also cleaned up a bit where we were running the same command three times in a row. Instead I reused the output. One thing that confused me is why we were testing for the same lib three times in a row but not two. After figuring that out I added a note to hopefully save future readers some confusion. try-job: x86_64-msvc try-job: i686-msvc

rustbot assigned jieyouxu Aug 4, 2024

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2024

This comment has been minimized.

Sign in to view

jieyouxu approved these changes Aug 4, 2024

View reviewed changes

tests/run-make/link-dedup/rmake.rs Outdated Show resolved Hide resolved

tests/run-make/link-dedup/rmake.rs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2024

run-make: enable msvc for link-dedup

d8c2b76

ChrisDenton force-pushed the link-dedup branch from 74c9235 to d8c2b76 Compare August 4, 2024 11:25

ChrisDenton mentioned this pull request Aug 4, 2024

run-make: audit the ignore-{windows,msvc,windows-msvc} tests #128602

Open

28 tasks

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2024

matthiaskrgr mentioned this pull request Aug 4, 2024

Rollup of 7 pull requests #128645

Closed

matthiaskrgr mentioned this pull request Aug 4, 2024

Rollup of 7 pull requests #128650

Closed

matthiaskrgr mentioned this pull request Aug 4, 2024

Rollup of 8 pull requests #128658

Closed

matthiaskrgr mentioned this pull request Aug 4, 2024

Rollup of 7 pull requests #128665

Closed

ChrisDenton mentioned this pull request Aug 5, 2024

Rollup of 11 pull requests #128668

Closed

tgross35 mentioned this pull request Aug 5, 2024

Rollup of 8 pull requests #128698

Closed

This was referenced Aug 7, 2024

Rollup of 9 pull requests #128767

Closed

Rollup of 7 pull requests #128768

Merged

tgross35 mentioned this pull request Aug 7, 2024

Rollup of 8 pull requests #128770

Closed

bors merged commit cc42e34 into rust-lang:master Aug 7, 2024
7 checks passed

rustbot added this to the 1.82.0 milestone Aug 7, 2024

ChrisDenton deleted the link-dedup branch August 7, 2024 08:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

run-make: enable msvc for `link-dedup` #128638

run-make: enable msvc for `link-dedup` #128638

ChrisDenton commented Aug 4, 2024 •

edited

Loading

rustbot commented Aug 4, 2024

rustbot commented Aug 4, 2024

ChrisDenton commented Aug 4, 2024

bors commented Aug 4, 2024

This comment has been minimized.

jieyouxu left a comment

This comment has been minimized.

bors commented Aug 4, 2024

jieyouxu commented Aug 4, 2024

ChrisDenton commented Aug 4, 2024

ChrisDenton commented Aug 4, 2024

bors commented Aug 4, 2024

bors commented Aug 4, 2024

ChrisDenton commented Aug 4, 2024

bors commented Aug 4, 2024

run-make: enable msvc for link-dedup #128638

run-make: enable msvc for link-dedup #128638

Conversation

ChrisDenton commented Aug 4, 2024 • edited Loading

rustbot commented Aug 4, 2024

rustbot commented Aug 4, 2024

ChrisDenton commented Aug 4, 2024

bors commented Aug 4, 2024

This comment has been minimized.

jieyouxu left a comment

Choose a reason for hiding this comment

This comment has been minimized.

bors commented Aug 4, 2024

jieyouxu commented Aug 4, 2024

ChrisDenton commented Aug 4, 2024

ChrisDenton commented Aug 4, 2024

bors commented Aug 4, 2024

bors commented Aug 4, 2024

ChrisDenton commented Aug 4, 2024

bors commented Aug 4, 2024

run-make: enable msvc for `link-dedup` #128638

run-make: enable msvc for `link-dedup` #128638

ChrisDenton commented Aug 4, 2024 •

edited

Loading