Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom MIR: add support for tail calls #128688

Merged
merged 1 commit into from
Aug 6, 2024
Merged

custom MIR: add support for tail calls #128688

merged 1 commit into from
Aug 6, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Aug 5, 2024 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented Aug 5, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 5, 2024
@RalfJung RalfJung mentioned this pull request Aug 5, 2024
Closed
@compiler-errors
Copy link
Member

r=me when green

@compiler-errors
Copy link
Member

green enough

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 5, 2024

📌 Commit 212417b has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2024
WaffleLapkin
WaffleLapkin approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@WaffleLapkin WaffleLapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

tgross35 added a commit to tgross35/rust that referenced this pull request Aug 5, 2024
@tgross35
Rollup merge of rust-lang#128688 - RalfJung:custom-mir-tail-calls, r=…
bb3157a 
…compiler-errors

custom MIR: add support for tail calls

Cc `@WaffleLapkin`
@tgross35 tgross35 mentioned this pull request Aug 5, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 5, 2024
@bors
Auto merge of rust-lang#128698 - tgross35:rollup-oan6ari, r=tgross35
4c6e809 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#122049 (Promote riscv64gc-unknown-linux-musl to tier 2)
 - rust-lang#125558 (Tweak type inference for `const` operands in inline asm)
 - rust-lang#128638 (run-make: enable msvc for `link-dedup`)
 - rust-lang#128647 (Enable msvc for link-args-order)
 - rust-lang#128649 (run-make: Enable msvc for `no-duplicate-libs` and `zero-extend-abi-param-passing`)
 - rust-lang#128656 (Enable msvc for run-make/rust-lld)
 - rust-lang#128688 (custom MIR: add support for tail calls)
 - rust-lang#128691 (Update `compiler-builtins` to 0.1.115)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 5, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 5, 2024
@bors
Auto merge of rust-lang#128707 - matthiaskrgr:rollup-63klywk, r=matth…
b586701 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#122049 (Promote riscv64gc-unknown-linux-musl to tier 2)
 - rust-lang#128580 (Use `ParamEnv::reveal_all` in CFI)
 - rust-lang#128688 (custom MIR: add support for tail calls)
 - rust-lang#128694 (Normalize when equating `dyn` tails in MIR borrowck)
 - rust-lang#128697 (interpret: move nullary-op evaluation into operator.rs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 83155b3 into rust-lang:master Aug 6, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 6, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 6, 2024
@rust-timer
Unrolled build for rust-lang#128688
0cd1477 
Rollup merge of rust-lang#128688 - RalfJung:custom-mir-tail-calls, r=compiler-errors

custom MIR: add support for tail calls

Cc ``@WaffleLapkin``
@RalfJung RalfJung deleted the custom-mir-tail-calls branch August 6, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
6 participants
@RalfJung @rustbot @compiler-errors @bors @WaffleLapkin @jieyouxu