Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #129428

Closed
wants to merge 35 commits into from

Commits on Jul 29, 2024

  1. Configuration menu
    Copy the full SHA
    0b87af9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    608901b View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Document WebAssembly target feature expectations

    This commit is a result of the discussion on rust-lang#128475 and incorporates
    parts of rust-lang#109807 as well. This is all done as a new page of
    documentation for the `wasm32-unknown-unknown` target which previously
    did not exist. This new page goes into details about the preexisting
    target and additionally documents the expectations for WebAssembly
    features and code generation.
    
    The tl;dr is that LLVM will enable features over time after most engines
    have had support for awhile. Compiling without features requires
    `-Ctarget-cpu=mvp` to rustc plus `-Zbuild-std` to Cargo.
    
    Closes rust-lang#109807
    Closes rust-lang#128475
    alexcrichton committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    e65a48e View commit details
    Browse the repository at this point in the history
  2. Review comments

    alexcrichton committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    dea3846 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    927633c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cfe3ea6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ce7f1b7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b6f65a4 View commit details
    Browse the repository at this point in the history
  7. Appease tidy

    alexcrichton committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    a5082ef View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Review comments

    alexcrichton committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    06197ef View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Configuration menu
    Copy the full SHA
    6899f5a View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Review comments

    alexcrichton committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    7d2595f View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Configuration menu
    Copy the full SHA
    6a8ec81 View commit details
    Browse the repository at this point in the history
  2. Update RELEASES.md

    Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
    apiraino and Mark-Simulacrum committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    cd7cc3f View commit details
    Browse the repository at this point in the history
  3. Update RELEASES.md

    Co-authored-by: Jubilee <46493976+workingjubilee@users.noreply.github.com>
    apiraino and workingjubilee committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7613eee View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Configuration menu
    Copy the full SHA
    063bd74 View commit details
    Browse the repository at this point in the history
  2. mark rust-lld-compress-debug-sections test as needing zstd

    also make it fail if there's a compression issue
    lqd committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    37a56f8 View commit details
    Browse the repository at this point in the history
  3. make compressed-debuginfo test about zlib only

    zlib is seemingly always enabled, so we can test it unconditionally
    lqd committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    d7e56cf View commit details
    Browse the repository at this point in the history
  4. prepare test for expanding scope

    lqd committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    0cb8a81 View commit details
    Browse the repository at this point in the history
  5. expand zstd debuginfo compression test

    it now checks zlib and zstd, via rustc and rust-lld
    lqd committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c439f68 View commit details
    Browse the repository at this point in the history
  6. move and rename zstd script

    move it where it's used, and name it like the other scripts
    lqd committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    9acf344 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4ad2e1b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8513a35 View commit details
    Browse the repository at this point in the history
  9. allow llvm.libzstd with download-ci-llvm = true

    but warn about it
    lqd committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    1649e71 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Configuration menu
    Copy the full SHA
    c51f2d2 View commit details
    Browse the repository at this point in the history
  2. Update RELEASES.md

    Co-authored-by: Josh Stone <cuviper@gmail.com>
    apiraino and cuviper committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    87e4b67 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6a878a9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8eb1558 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#126985 - Mrmaxmeier:dwarf-embed-source, r=d…

    …avidtwco
    
    Implement `-Z embed-source` (DWARFv5 source code embedding extension)
    
    Implement rust-lang/compiler-team#764 MCP which adds an unstable flag that exposes LLVM's [DWARFv5 source code embedding](https://dwarfstd.org/issues/180201.1.html) support.
    matthiaskrgr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    51e5cf7 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#128511 - alexcrichton:doc-wasm-features, r=…

    …jieyouxu
    
    Document WebAssembly target feature expectations
    
    This commit is a result of the discussion on rust-lang#128475 and incorporates parts of rust-lang#109807 as well. This is all done as a new page of documentation for the `wasm32-unknown-unknown` target which previously did not exist. This new page goes into details about the preexisting target and additionally documents the expectations for WebAssembly features and code generation.
    
    The tl;dr is that LLVM will enable features over time after most engines have had support for awhile. Compiling without features requires `-Ctarget-cpu=mvp` to rustc plus `-Zbuild-std` to Cargo.
    
    Closes rust-lang#109807
    Closes rust-lang#119811
    Closes rust-lang#128475
    matthiaskrgr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    4553e97 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#128935 - lqd:needs-zstd, r=Kobzol

    More work on `zstd` compression
    
    r? ```@Kobzol``` as we've discussed this.
    
    This is a draft to show the current approach of supporting zstd in compiletest, and making the tests using it unconditional.
    
    Knowing whether llvm/lld was built with `LLVM_ENABLE_ZSTD` is quite hard, so there are two strategies. There are details in the code, and we can discuss this approach. Until we know the config used to build CI artifacts, it seems our options are somewhat limited in any case.
    
    zlib compression seems always enabled, so we only check this in its dedicated test, allowing the test to ignore errors due to zstd not being supported.
    
    The zstd test is made unconditional in what it tests, by relying on `needs-llvm-zstd` to be ignored when `llvm.libzstd` isn't enabled in `config.toml`.
    
    try-job: x86_64-gnu
    matthiaskrgr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    a34b4cc View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#129263 - apiraino:add-missing-compat-note, …

    …r=cuviper
    
    Add a missing compatibility note in the 1.80.0 release notes
    
    rust-lang#99969 missed being included in the release notes. As discussed [on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/.2399969.20missed.20the.20release.20notes/near/463002451).
    
    (the discussion about the _a posteriori_ breakage the ecosystem is experiencing is another topic)
    
    Thanks
    
    r? ```@rust-lang/release```
    matthiaskrgr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    a29bc06 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#129386 - cjgillot:local-resolved-arg, r=com…

    …piler-errors
    
    Use a LocalDefId in ResolvedArg.
    matthiaskrgr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6b0dd24 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#129408 - Urgau:macro-arg-drop_copy, r=compi…

    …ler-errors
    
    Fix handling of macro arguments within the `dropping_copy_types` lint
    
    This PR fixes the handling of spans with different context (aka macro arguments) than the primary expression within the different `{drop,forget}ing_copy_types` and `{drop,forget}ing_references` lints.
    
    <details>
    <summary>Before</summary>
    
    ```
    warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing
     --> drop_writeln.rs:5:5
      |
    5 |     drop(writeln!(&mut msg, "test"));
      |     ^^^^^--------------------------^
      |          |
      |          argument has type `Result<(), std::fmt::Error>`
      |
      = note: `#[warn(dropping_copy_types)]` on by default
    help: use `let _ = ...` to ignore the expression or result
     --> /home/[..]/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/macros/mod.rs:688:9
      |
    68|         let _ =
      |         ~~~~~~~
    ```
    
    </details>
    
    <details>
    <summary>With this PR</summary>
    
    ```
    warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing
     --> drop_writeln.rs:5:5
      |
    5 |     drop(writeln!(&mut msg, "test"));
      |     ^^^^^--------------------------^
      |          |
      |          argument has type `Result<(), std::fmt::Error>`
      |
      = note: `#[warn(dropping_copy_types)]` on by default
    help: use `let _ = ...` to ignore the expression or result
      |
    5 -     drop(writeln!(&mut msg, "test"));
    5 +     let _ = writeln!(&mut msg, "test");
      |
    ```
    
    </details>
    
    ```@rustbot``` label +L-dropping_copy_types
    matthiaskrgr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    279a3e4 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#129417 - compiler-errors:refine-err, r=lqd

    Don't trigger refinement lint if predicates reference errors
    
    Fixes rust-lang#129404
    matthiaskrgr committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    bdc2db8 View commit details
    Browse the repository at this point in the history