make unsupported_calling_conventions a hard error #129935
Conversation
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
S-waiting-on-review
|
These commits modify compiler targets. Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
@bors try |
RalfJung
force-pushed
the
unsupported_calling_conventions
branch
from
d933cf5
to
0c5a9b3
Compare
…ions, r= make unsupported_calling_conventions a hard error This has been a future-compat lint (not shown in dependencies) since Rust 1.55, released 3 years ago. Hopefully that was enough time so this can be made a hard error now. Given that long timeframe, I think it's justified to skip the "show in dependencies" stage. There were [not many crates hitting this](rust-lang#86231 (comment)) even when the PR was landed. This should get cratered, and I assume then it needs a t-compiler FCP. Fixes rust-lang#88397
This comment has been minimized.
This comment has been minimized.
|
Damn, this needs a change in the reference.^^ |
Waiting 24 hours will also unblock, since beta week ends. |
|
☀️ Try build successful - checks-actions |
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🎉 Experiment
|
craterbot
added
S-waiting-on-review
|
6 crates on crates.io are affected, those all look like genuine regressions. They are all rarely used (the one with most downloads has 12k total downloads, that one also has not seen any updates in 8 years). I have filed issues for the 4 crates that saw updates in the last 5 years, see the backlinks above. |
RalfJung
force-pushed
the
unsupported_calling_conventions
branch
from
0c5a9b3
to
2620cb2
Compare
|
@fee1-dead I think this is then ready for review. Does it need a t-compiler FCP because it is a breaking change? |
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
unsupported_calling_conventions
branch
from
2620cb2
to
cee68d8
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
unsupported_calling_conventions
branch
from
cee68d8
to
e2e4dc7
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
unsupported_calling_conventions
branch
from
e2e4dc7
to
c9c1f54
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
unsupported_calling_conventions
branch
from
c9c1f54
to
2f63731
Compare
|
My vibe is that some process would probably need to be followed. I'm currently overloaded so will hand off to another reviewer. r? compiler |
|
👍 @rfcbot fcp merge |
|
Team member @compiler-errors has proposed to merge this. The next step is review by the rest of the tagged team members:
No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
|
☔ The latest upstream changes (presumably #128543) made this pull request unmergeable. Please resolve the merge conflicts. |
This has been a future-compat lint (not shown in dependencies) since Rust 1.55, released 3 years ago. Hopefully that was enough time so this can be made a hard error now. Given that long timeframe, I think it's justified to skip the "show in dependencies" stage. There were not many crates hitting this even when the lint was originally added.
This should get cratered, and I assume then it needs a t-compiler FCP.
Fixes #88397