make unsupported_calling_conventions a hard error #129935

RalfJung · 2024-09-03T16:52:10Z

This has been a future-compat lint (not shown in dependencies) since Rust 1.55, released 3 years ago. Hopefully that was enough time so this can be made a hard error now. Given that long timeframe, I think it's justified to skip the "show in dependencies" stage. There were not many crates hitting this even when the lint was originally added.

This should get cratered, and I assume then it needs a t-compiler FCP. (t-compiler because this looks entirely like an implementation oversight -- for the vast majority of ABIs, we already have a hard error, but some were initially missed, and we are finally fixing that.)

Fixes #87678

rustbot · 2024-09-03T16:52:18Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-09-03T16:52:19Z

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

RalfJung · 2024-09-03T16:55:56Z

@bors try

…ions, r= make unsupported_calling_conventions a hard error This has been a future-compat lint (not shown in dependencies) since Rust 1.55, released 3 years ago. Hopefully that was enough time so this can be made a hard error now. Given that long timeframe, I think it's justified to skip the "show in dependencies" stage. There were [not many crates hitting this](rust-lang#86231 (comment)) even when the PR was landed. This should get cratered, and I assume then it needs a t-compiler FCP. Fixes rust-lang#88397

bors · 2024-09-03T16:57:08Z

⌛ Testing commit 0c5a9b3 with merge 498fce2...

RalfJung · 2024-09-03T17:37:07Z

Damn, this needs a change in the reference.^^

ehuss · 2024-09-03T18:33:38Z

Damn, this needs a change in the reference.^^

Waiting 24 hours will also unblock, since beta week ends.

bors · 2024-09-03T18:49:56Z

☀️ Try build successful - checks-actions
Build commit: 498fce2 (498fce24f39c1ecbb0abe08824e72162da853341)

RalfJung · 2024-09-03T18:52:47Z

@craterbot check
The fact that crater is Linux-only is actually good here; on Windows the ABI keeps being accepted on all targets, only on other OSes does it get rejected.

craterbot · 2024-09-03T18:53:00Z

👌 Experiment pr-129935 created and queued.
🤖 Automatically detected try build 498fce2
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2024-09-06T08:20:10Z

🚧 Experiment pr-129935 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2024-09-08T19:35:55Z

🎉 Experiment pr-129935 is completed!
📊 29 regressed and 3 fixed (508635 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

RalfJung · 2024-09-09T06:19:59Z

6 crates on crates.io are affected, those all look like genuine regressions. They are all rarely used (the one with most downloads has 12k total downloads, that one also has not seen any updates in 8 years).

I have filed issues for the 4 crates that saw updates in the last 5 years, see the backlinks above.

RalfJung · 2024-09-09T06:21:32Z

@fee1-dead I think this is then ready for review.

Does it need a t-compiler FCP because it is a breaking change?

rfcbot · 2024-10-21T20:38:27Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

compiler-errors · 2024-10-22T01:41:18Z

@bors r+

bors · 2024-10-22T01:41:21Z

📌 Commit de3cbf3 has been approved by compiler-errors

It is now in the queue for this repository.

…ntions, r=compiler-errors make unsupported_calling_conventions a hard error This has been a future-compat lint (not shown in dependencies) since Rust 1.55, released 3 years ago. Hopefully that was enough time so this can be made a hard error now. Given that long timeframe, I think it's justified to skip the "show in dependencies" stage. There were [not many crates hitting this](rust-lang#86231 (comment)) even when the lint was originally added. This should get cratered, and I assume then it needs a t-compiler FCP. (t-compiler because this looks entirely like an implementation oversight -- for the vast majority of ABIs, we already have a hard error, but some were initially missed, and we are finally fixing that.) Fixes rust-lang#87678

Rollup of 6 pull requests Successful merges: - rust-lang#129935 (make unsupported_calling_conventions a hard error) - rust-lang#130432 (rust_for_linux: -Zregparm=<N> commandline flag for X86 (rust-lang#116972)) - rust-lang#131697 (`rt::Argument`: elide lifetimes) - rust-lang#131954 (shave 150ms off bootstrap) - rust-lang#131982 (Represent `hir::TraitBoundModifiers` as distinct parts in HIR) - rust-lang#132017 (Update triagebot.toml) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-10-22T03:24:43Z

⌛ Testing commit de3cbf3 with merge 1de57a5...

rust-highfive · 2024-10-22T05:47:03Z

📣 Toolstate changed by #129935!

Tested on commit 1de57a5.
Direct link to PR: #129935

💔 reference on linux: test-pass → test-fail (cc @Havvy @matthewjasper @ehuss).

@Havvy

Tested on commit rust-lang/rust@1de57a5. Direct link to PR: <rust-lang/rust#129935> 💔 reference on linux: test-pass → test-fail (cc @Havvy @matthewjasper @ehuss).

bors · 2024-10-22T05:48:11Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 1de57a5 to master...

RalfJung · 2024-10-22T06:15:46Z

Reference should be fixed by rust-lang/reference#1600

rust-timer · 2024-10-22T07:09:30Z

Finished benchmarking commit (1de57a5): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.6%	[-2.6%, -2.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.6%	[-2.6%, -2.6%]	1

Max RSS (memory usage)

Results (primary 1.7%, secondary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.7%	[1.7%, 1.7%]	1
Regressions ❌ (secondary)	1.6%	[1.6%, 1.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	1.7%	[1.7%, 1.7%]	1

Cycles

Results (primary -2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.6%	[-2.6%, -2.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.6%	[-2.6%, -2.6%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 781.081s -> 779.742s (-0.17%)
Artifact size: 333.69 MiB -> 333.70 MiB (0.00%)

rust-lang/rust#129935 made `unsupported_calling_conventions` a hard-error, which in turn makes this test fail.

ehuss · 2024-10-22T13:35:59Z

@RalfJung There is an additional test that needs to be fixed. I posted rust-lang/reference#1659 to fix that.

…ions, r=compiler-errors make unsupported_calling_conventions a hard error This has been a future-compat lint (not shown in dependencies) since Rust 1.55, released 3 years ago. Hopefully that was enough time so this can be made a hard error now. Given that long timeframe, I think it's justified to skip the "show in dependencies" stage. There were [not many crates hitting this](rust-lang#86231 (comment)) even when the lint was originally added. This should get cratered, and I assume then it needs a t-compiler FCP. (t-compiler because this looks entirely like an implementation oversight -- for the vast majority of ABIs, we already have a hard error, but some were initially missed, and we are finally fixing that.) Fixes rust-lang#87678

rustbot assigned fee1-dead Sep 3, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 3, 2024

RalfJung force-pushed the unsupported_calling_conventions branch from d933cf5 to 0c5a9b3 Compare September 3, 2024 16:56

This comment has been minimized.

Sign in to view

RalfJung mentioned this pull request Sep 3, 2024

dont use stdcall on x86_64 where it is not a valid ABI rust-lang/reference#1600

Merged

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2024

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 8, 2024

RalfJung force-pushed the unsupported_calling_conventions branch from 0c5a9b3 to 2620cb2 Compare September 9, 2024 06:20

This comment has been minimized.

Sign in to view

RalfJung force-pushed the unsupported_calling_conventions branch from c3cca9a to 4de549d Compare October 19, 2024 07:42

This comment has been minimized.

Sign in to view

RalfJung force-pushed the unsupported_calling_conventions branch from 4de549d to e9bec19 Compare October 19, 2024 08:31

make unsupported_calling_conventions a hard error

de3cbf3

RalfJung force-pushed the unsupported_calling_conventions branch from e9bec19 to de3cbf3 Compare October 20, 2024 13:23

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2024

fmease mentioned this pull request Oct 22, 2024

Rollup of 6 pull requests #132018

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 22, 2024

bors merged commit 1de57a5 into rust-lang:master Oct 22, 2024
7 checks passed

rustbot added this to the 1.84.0 milestone Oct 22, 2024

RalfJung deleted the unsupported_calling_conventions branch October 22, 2024 07:23

ehuss added a commit to ehuss/reference that referenced this pull request Oct 22, 2024

Fix example broken by recent rustc change

afe7539

rust-lang/rust#129935 made `unsupported_calling_conventions` a hard-error, which in turn makes this test fail.

ehuss mentioned this pull request Oct 22, 2024

Fix stdcall example broken by recent rustc change rust-lang/reference#1659

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make unsupported_calling_conventions a hard error #129935

make unsupported_calling_conventions a hard error #129935

RalfJung commented Sep 3, 2024 •

edited

Loading

rustbot commented Sep 3, 2024

rustbot commented Sep 3, 2024

RalfJung commented Sep 3, 2024

bors commented Sep 3, 2024

This comment has been minimized.

RalfJung commented Sep 3, 2024

ehuss commented Sep 3, 2024

bors commented Sep 3, 2024

RalfJung commented Sep 3, 2024 •

edited

Loading

craterbot commented Sep 3, 2024

craterbot commented Sep 6, 2024

craterbot commented Sep 8, 2024

RalfJung commented Sep 9, 2024

RalfJung commented Sep 9, 2024

This comment has been minimized.

This comment has been minimized.

rfcbot commented Oct 21, 2024

compiler-errors commented Oct 22, 2024

bors commented Oct 22, 2024

bors commented Oct 22, 2024

rust-highfive commented Oct 22, 2024

bors commented Oct 22, 2024

RalfJung commented Oct 22, 2024

rust-timer commented Oct 22, 2024

ehuss commented Oct 22, 2024

make unsupported_calling_conventions a hard error #129935

make unsupported_calling_conventions a hard error #129935

Conversation

RalfJung commented Sep 3, 2024 • edited Loading

rustbot commented Sep 3, 2024

rustbot commented Sep 3, 2024

RalfJung commented Sep 3, 2024

bors commented Sep 3, 2024

This comment has been minimized.

RalfJung commented Sep 3, 2024

ehuss commented Sep 3, 2024

bors commented Sep 3, 2024

RalfJung commented Sep 3, 2024 • edited Loading

craterbot commented Sep 3, 2024

craterbot commented Sep 6, 2024

craterbot commented Sep 8, 2024

RalfJung commented Sep 9, 2024

RalfJung commented Sep 9, 2024

This comment has been minimized.

This comment has been minimized.

rfcbot commented Oct 21, 2024

compiler-errors commented Oct 22, 2024

bors commented Oct 22, 2024

bors commented Oct 22, 2024

rust-highfive commented Oct 22, 2024

bors commented Oct 22, 2024

RalfJung commented Oct 22, 2024

rust-timer commented Oct 22, 2024

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

ehuss commented Oct 22, 2024

RalfJung commented Sep 3, 2024 •

edited

Loading

RalfJung commented Sep 3, 2024 •

edited

Loading