Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for UNSUPPORTED_CALLING_CONVENTIONS #88397

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Tracking issue for UNSUPPORTED_CALLING_CONVENTIONS #88397

merged 1 commit into from
Aug 27, 2021

Conversation

nagisa
Copy link
Member

@nagisa nagisa commented Aug 27, 2021

This was previously forgotten. Nominating for 1.55 as this lint will make it into stable in that release.

r? @Mark-Simulacrum

@nagisa nagisa added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 27, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2021
@nagisa nagisa mentioned this pull request Aug 27, 2021
Closed
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Aug 27, 2021

📌 Commit 5b21fe0d7442cb4448ba6e19210c6fb73394527a has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nagisa
Copy link
Member Author

nagisa commented Aug 27, 2021

Ah, I should've blessed the tests. will do it whenever I fix my build environment.

@Mark-Simulacrum
Copy link
Member

@bors r- for now

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 27, 2021
@nagisa nagisa force-pushed the nagisa/unsupported-calling-conventions branch from 5b21fe0 to fb5fbaa Compare August 27, 2021 17:47
@nagisa
Copy link
Member Author

nagisa commented Aug 27, 2021

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Aug 27, 2021

📌 Commit fb5fbaa has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 27, 2021
@bors
Copy link
Contributor

bors commented Aug 27, 2021

⌛ Testing commit fb5fbaa with merge dfd8472...

@bors
Copy link
Contributor

bors commented Aug 27, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing dfd8472 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 27, 2021
@bors bors merged commit dfd8472 into rust-lang:master Aug 27, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 27, 2021
@nagisa nagisa mentioned this pull request Aug 30, 2021
Merged
@apiraino
Copy link
Contributor

apiraino commented Sep 2, 2021

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 2, 2021
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 4, 2021
Merged
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 4, 2021
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.56.0, 1.55.0 Sep 4, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 4, 2021
@bors
Auto merge of rust-lang#88641 - Mark-Simulacrum:beta-next, r=Mark-Sim…
e721434 
…ulacrum

[beta] backports

This PR backports:

* Concrete regions can show up in mir borrowck if the originated from there rust-lang#88533 (fixes rust-lang#83190)
* Fix loading large rlibs rust-lang#88506 (fixes rust-lang#88351)
* Display associated types of implementors rust-lang#88490 (fixes rust-lang#86631)
* Tracking issue for UNSUPPORTED_CALLING_CONVENTIONS rust-lang#88397

r? `@Mark-Simulacrum`
@RalfJung RalfJung mentioned this pull request Sep 3, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 3, 2024
@bors
Auto merge of rust-lang#129935 - RalfJung:unsupported_calling_convent…
498fce2 
…ions, r=

make unsupported_calling_conventions a hard error

This has been a future-compat lint (not shown in dependencies) since Rust 1.55, released 3 years ago. Hopefully that was enough time so this can be made a hard error now. Given that long timeframe, I think it's justified to skip the "show in dependencies" stage. There were [not many crates hitting this](rust-lang#86231 (comment)) even when the PR was landed.

This should get cratered, and I assume then it needs a t-compiler FCP.

Fixes rust-lang#88397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
7 participants
@nagisa @Mark-Simulacrum @bors @rust-log-analyzer @apiraino @rust-highfive @rustbot