Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #132661

Merged
merged 17 commits into from
Nov 6, 2024
Merged

Rollup of 8 pull requests #132661

merged 17 commits into from
Nov 6, 2024

Commits on Oct 31, 2024

  1. rustc_codegen_llvm: Add a new 'pc' option to branch-protection

    Add a new 'pc' option to -Z branch-protection for aarch64 that
    enables the use of PC as a diversifier in PAC branch protection code.
    
    When the pauth-lr target feature is enabled in combination
    with -Z branch-protection=pac-ret,pc, the new 9.5-a instructions
    (pacibsppc, retaasppc, etc) will be generated.
    mrkajetanp committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    10edeea View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. chore(style): sync submodule exclusion list between tidy and rustfmt

    As asked in the FIXME comments
    ismailarilik committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    4e0d71f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    67a8592 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2024

  1. Configuration menu
    Copy the full SHA
    06fc531 View commit details
    Browse the repository at this point in the history
  2. Properly suggest E::assoc when we encounter E::Variant::assoc

    Use the right span when encountering an enum variant followed by an associated item so we don't lose the associated item in the resulting code.
    
    Do not suggest the thing twice, once as a removal of the associated item and a second time as a typo suggestion.
    estebank committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    e26ad8b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. add const_eval_select macro to reduce redundancy

    also move internal const_panic helpers to a better location
    RalfJung committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    613f53e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2eac3c0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3300960 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    02b3415 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#132259 - mrkajetanp:branch-protection-pauth…

    …-lr, r=davidtwco
    
    rustc_codegen_llvm: Add a new 'pc' option to branch-protection
    
    Add a new 'pc' option to -Z branch-protection for aarch64 that enables the use of PC as a diversifier in PAC branch protection code.
    
    When the pauth-lr target feature is enabled in combination with -Z branch-protection=pac-ret,pc, the new 9.5-a instructions (pacibsppc, retaasppc, etc) will be generated.
    matthiaskrgr authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    c8247c0 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#132409 - MarcoIeni:ci-remove-linux-4c-large…

    …, r=Kobzol
    
    CI: switch 7 linux jobs to free runners
    
    try-job: x86_64-gnu-aux
    try-job: x86_64-gnu-nopt
    try-job: x86_64-gnu-tools
    matthiaskrgr authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    0078e64 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#132498 - uellenberg:typo-and-let-suggestion…

    …s, r=estebank
    
    Suggest fixing typos and let bindings at the same time
    
    Fixes rust-lang#132483
    
    Currently, a suggestion for adding a let binding won't be shown if we suggest fixing a typo. This changes that behavior to always show both, if possible. Essentially, this turns the suggestion from
    ```rust
    error[E0425]: cannot find value `x2` in this scope
     --> src/main.rs:4:5
      |
    4 |     x2 = 2;
      |     ^^ help: a local variable with a similar name exists: `x1`
    
    For more information about this error, try `rustc --explain E0425`.
    ```
    
    to
    ```rust
    error[E0425]: cannot find value `x2` in this scope
     --> src/main.rs:4:5
      |
    4 |     x2 = 2;
      |     ^^
      |
    help: a local variable with a similar name exists
      |
    4 |     x1 = 2;
      |     ~~
    help: you might have meant to introduce a new binding
      |
    4 |     let x2 = 2;
      |     +++
    
    For more information about this error, try `rustc --explain E0425`.
    ```
    
    for the following code:
    ```rust
    fn main() {
        let x1 = 1;
        x2 = 2;
    }
    ```
    
    The original behavior only shows the suggestion for a let binding if a typo suggestion wasn't already displayed. However, this falls apart in the cases like the one above where we have multiple similar variables. I don't think it makes sense to hide this suggestion if there's a similar variable, since that defeats the purpose of this suggestion in that case (it's meant to help those coming from languages like Python).
    matthiaskrgr authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b236558 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#132524 - ismailarilik:chore/style/sync-subm…

    …odule-exclusion-list-between-tidy-and-rustfmt, r=jieyouxu
    
    chore(style): sync submodule exclusion list between tidy and rustfmt
    
    As asked in the FIXME comments
    matthiaskrgr authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b524be5 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#132567 - estebank:bad-suggestion, r=Nadrieril

    Properly suggest `E::assoc` when we encounter `E::Variant::assoc`
    
    Use the right span when encountering an enum variant followed by an associated item so we don't lose the associated item in the resulting code.
    
    Do not suggest the thing twice, once as a removal of the associated item and a second time as a typo suggestion.
    matthiaskrgr authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    bb50ebf View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#132571 - RalfJung:const_eval_select_macro, …

    …r=oli-obk
    
    add const_eval_select macro to reduce redundancy
    
    I played around a bit with a macro to make const_eval_select invocations look a bit nicer and avoid repeating the argument lists. Here's what I got. What do you think?
    
    I didn't apply this everywhere yet because I wanted to gather feedback first.
    
    The second commit moves the macros from rust-lang#132542 into a more sensible place. It didn't seem worth its own PR and would conflict with this PR if done separately.
    
    Cc ``@oli-obk`` ``@saethlin`` ``@tgross35``
    
    try-job: dist-aarch64-msvc
    matthiaskrgr authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    aa4fe48 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#132637 - blyxyas:lint-less-passes, r=flip1995

    Do not filter empty lint passes & re-do CTFE pass
    
    Some structs implement `LintPass` without having a `Lint` associated with them rust-lang#125116 broke that behaviour by filtering them out. This PR ensures that lintless passes are not filtered out.
    matthiaskrgr authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    560248f View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#132642 - GuillaumeGomez:attr-docs, r=compil…

    …er-errors
    
    Add documentation on `ast::Attribute`
    
    I was working again with attributes in clippy recently and I often find myself in need to read the source code to ensure it's doing what I want.
    
    Instead, a bit of documentation would allow me (and hopefully others) to skip this step.
    matthiaskrgr authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    4346249 View commit details
    Browse the repository at this point in the history