test: Fix run-make on windows #13795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # trailing slash (`c:/path/to/test/`). | ||
| # the easist workaround is to remove the slash (`c:/path/to/test`). | ||
| # msys2 seems to fix this problem. | ||
| path = path[:-1] |
There was a problem hiding this comment.
Wow, that's a little terrifying
|
Awesome job! |
|
rebased; fixed |
bors
added a commit
that referenced
this pull request
Apr 28, 2014
Fixes #12303. Also contains a partial fix for `make check` failure.
arcnmx
pushed a commit
to arcnmx/rust
that referenced
this pull request
Jan 9, 2023
…n-path-deps, r=jonas-schievink fix: Use the correct edition when formatting code in path dependencies Fixes rust-lang/rust-analyzer#13790 Don't go through the Cargo workspace info, since that doesn't contain path dependencies. Instead, query the crate graph via `Analysis::crate_edition`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12303.
Also contains a partial fix for
make checkfailure.