Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make check failures on windows 7 #13439

Closed
liigo opened this issue Apr 10, 2014 · 4 comments
Closed

make check failures on windows 7 #13439

liigo opened this issue Apr 10, 2014 · 4 comments
Labels
O-windows Operating system: Windows

Comments

@liigo
Copy link
Contributor

liigo commented Apr 10, 2014

When I try to compile Rust from latest source.

failures:

---- [run-pass] run-pass/exponential-notation.rs stdout ----

        error: test run failed!
        command: PATH="i686-pc-mingw32/stage2/bin/rustlib/i686-pc-mingw32/lib;;.;D:\MinGW\msys\1.0\local\bin;d:\mingw\bin;D:\MinGW\msys\1.0\bin;c:\Perl64\site\bin;c:\Perl64\bin;c:\Windows\system32;c:\Windows;c:\Windows\System32\Wbem;c:\Windows\System32\WindowsPowerShell\v1.0\;d:\CrossGCC\mips\share;d:\CrossGCC\mips\bin;d:\Program Files\TortoiseSVN\bin;c:\Program Files (x86)\Windows Kits\8.0\Windows Performance Toolkit\;d:\Go\bin;d:\Go\3rd\bin;d:\Program Files (x86)\Git\bin;d:\Program Files\MariaDB 5.5\bin;c:\Program Files\Microsoft SQL Server\110\Tools\Binn\;d:\Programs\lua52;c:\Program Files(x86)\Bitvise SSH Client;d:\Program Files\TortoiseGit\bin;c:\Python27;c:\Python27\Scripts;d:\Liigo\rust\rust-nightly\bin;d:\Program Files (x86)\Microsoft Visual studio\Common\Tools\WinNT;d:\Program Files (x86)\Microsoft Visual Studio\Common
\MSDev98\Bin;d:\Program Files (x86)\Microsoft Visual Studio\Common\Tools;d:\Program Files (x86)\Microsoft Visual Studio\VC98\bin;d:\Program Files (x86)\CMake 2.8\bin;d:\Program Files (x86)\XinAnTong;d:\Programs\Pawn\bin;c:\nasm;i686-pc-ming
w32\stage2\bin\rustlib\i686-pc-mingw32\lib" i686-pc-mingw32\test\run-pass\exponential-notation.stage2-i686-pc-mingw32.exe
        stdout:
        ------------------------------------------

        ------------------------------------------
        stderr:
        ------------------------------------------
        task '<main>' failed at 'called `Option::unwrap()` on a `None` value', D:\MinGW\msys\1.0\home\LIIGO\rust\rust\src\libstd\option.rs:264

        ------------------------------------------

        task '[run-pass] run-pass/exponential-notation.rs' failed at 'explicit failure', D:\MinGW\msys\1.0\home\LIIGO\rust\rust\src\compiletest\runtest.rs:962

---- [run-pass] run-pass/struct-lit-functional-update-no-fields.rs stdout ----
        task '[run-pass] run-pass/struct-lit-functional-update-no-fields.rs' failed at 'failed to exec `i686-pc-mingw32\test\run-pass\struct-lit-functional-update-no-fields.stage2-i686-pc-mingw32.exe`', D:\MinGW\msys\1.0\home\LIIGO\rust\rust\src\libstd\option.rs:245


failures:
    [run-pass] run-pass/exponential-notation.rs
    [run-pass] run-pass/struct-lit-functional-update-no-fields.rs

test result: FAILED. 1387 passed; 2 failed; 50 ignored; 0 measured

task '<main>' failed at 'Some tests failed', D:\MinGW\msys\1.0\home\LIIGO\rust\rust\src\compiletest\compiletest.rs:253
make: *** [tmp/check-stage2-T-i686-pc-mingw32-H-i686-pc-mingw32-rpass.ok] Error 101
@mrec
Copy link
Contributor

mrec commented Apr 27, 2014

I've just built Rust from latest source (for the first time) on Win7-64, and with make check-fast I only get the second of these:

failures:

---- [run-pass] run-pass/struct-lit-functional-update-no-fields.rs stdout ----
        task '[run-pass] run-pass/struct-lit-functional-update-no-fields.rs' fai
led at 'failed to exec `i686-pc-mingw32\test\run-pass\struct-lit-functional-upda
te-no-fields.stage2-i686-pc-mingw32.exe`', C:\msys\home\Mike\rust\src\libstd\opt
ion.rs:245

failures:
    [run-pass] run-pass/struct-lit-functional-update-no-fields.rs

test result: FAILED. 1401 passed; 1 failed; 42 ignored; 0 measured

If I try to run struct-lit-functional-update-no-fields.stage2-i686-pc-mingw32.exe directly from a cmd prompt, I get a UAC prompt. I don't know whether that's expected behaviour or even a sensible thing to try, but I tried the same with a few of the non-failing tests and got a different error (complaining about missing what looks like a temporary test fixture DLL).

@klutzy
Copy link
Contributor

klutzy commented Apr 28, 2014

@mrec recent windows (>= 7) triggers UAC if executable has "update" in filename. There was attempt to fix it by adding manifest (#10878) but it was reverted later since it caused some other issues.
What we do now is to rename files if it causes problem. :( #13795 has a patch for it.

@Rufflewind
Copy link
Contributor

Here is a fix/workaround for the bug with exponential-notation.rs.

@alexcrichton
Copy link
Member

These tests are both currently running successfully on our windows bots.

compiler-errors pushed a commit to compiler-errors/rust that referenced this issue Oct 26, 2022
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 24, 2024
Use contiguous spans for empty_line_after_* suggestion

Replacing an empty span (which an empty line is) with an empty string triggers a debug assertion in rustc. This fixes the debug assertion by using contiguous spans, with the same resulting suggestion.

r? `@Alexendoo`

This unblocks the sync

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-windows Operating system: Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants