Embed Windows application manifests #10878
Conversation
| fn postprocess_executable(sess: Session, filename: &Path) { | ||
|
|
||
| let default_manifest = concat!( | ||
| "<?xml version='1.0' encoding='UTF-8' standalone='yes'?>\r\n", |
There was a problem hiding this comment.
Is it possible to just do this as a literal:
"<?xml version='1.0' encoding='UTF-8' standalone='yes'?>\r
<assembly xmlns='urn:schemas-microsoft-com:asm.v1' manifestVersion='1.0'>\r
<trustInfo xmlns='urn:schemas-microsoft-com:asm.v3'>\r
...
"?
There was a problem hiding this comment.
concat!() performs compile-time concatenation, so this is a single literal.
There was a problem hiding this comment.
I know that, I was talking at a source level because it just seems a little peculiar to have 10 strings rather than 1 (and concat! will possibly be removed, because it is designed to allow things like concat!("foo", some_macro!()) rather than just plain strings, and this "local expansion" can cause problems with hygiene, apparently.)
|
silly windows, but nice work! |
|
@alexcrichton: moved manifest stuff to a separate file, added comments as you asked. r? |
|
Needs a rebase. |
|
@alexcrichton: Rebased |
|
It appears some rebasing indentation has gone wrong. While you're at it, could you rebase these into a single commit? |
|
Done. |
|
@alexcrichton: retry ...please :) |
|
Grrr... this trailing whitespace check is infuriating. Also, rebased |
|
I can't fathom how could this have broken Android but not other unixes... Perhaps a spurious build machine error? |
In order to avoid UAC installer detection silliness... Closes #10512
…et,GuillaumeGomez Allow more attributes in `clippy::useless_attribute` Fixes rust-lang#12753 Fixes rust-lang#4467 Fixes rust-lang#11595 Fixes rust-lang#10878 changelog: [`useless_attribute`]: Attributes allowed on `use` items now include `ambiguous_glob_exports`, `hidden_glob_reexports`, `dead_code`, `unused_braces`, and `clippy::disallowed_types`.
In order to avoid UAC installer detection silliness...
Closes #10512