Support cross-compiling for iOS (armv7) #14715
Conversation
|
There's a tidy issue: https://travis-ci.org/mozilla/rust/jobs/27001033 |
|
@sfackler fixed |
| CC_arm-apple-ios = $(shell xcrun -find -sdk iphoneos clang) | ||
| CXX_arm-apple-ios = $(shell xcrun -find -sdk iphoneos clang++) | ||
| CPP_arm-apple-ios = $(shell xcrun -find -sdk iphoneos clang++) | ||
| AR_arm-apple-ios = $(shell xcrun -find -sdk iphoneos ar) |
There was a problem hiding this comment.
The current invocations of xcrun are guarded with ifeq ($(CFG_OSTYPE),apple-darwin), could you add those around these to make sure we're not running xcrun when it doesn't exist?
|
This looks pretty awesome, thank you for this! |
|
@alexcrichton |
| OsAndroid => ".note.rustc", | ||
| OsFreebsd => ".note.rustc" | ||
| abi::OsMacos => "__note.rustc", | ||
| abi::OsiOS => "__note.rustc", |
There was a problem hiding this comment.
As above, I think this could possibly just be fail!()
There was a problem hiding this comment.
This one works, i.e. it seems meta_section_name is always called from trans::base::write_metadata, but read_meta_section_name isn't in case of iOS
|
Just a few minor things, but otherwise looks good to me! Don't worry about the travis failure, it's a known problem. |
|
Great. Regarding Travis - there is also linking error in log just before timeout, so it seems requires a little attention anyway, may be updated |
|
Was unable to reproduce Travis fail - builds and checks everything fine on Linux |
|
It's pretty ironic that build fails because of broken support of Android in updated compiler-rt |
Previous update unfortunately included changes which broke Android compilation. This update fixes it and should allow correct compilation of SjLj for iOS and all builtins for Android.
|
Does it needs a new approval now? |
It seems in one of rebases I’ve resolved conflicts wrong and left one redundant line, it is absent in current master and it might cause compilation failure by copying file into itself.
|
@alexcrichton It seems I've found reason of win32 build failure, need one more approval. |
Refactor symbol index Closes rust-lang/rust-analyzer#14677 instead of eagerly fetching the source data in symbol index we do it lazily now, this shouldn't make it much more expensive as we had to parse the source most of the time anyways even after fetching.
No description provided.