Make note of noalias in unsafe reference section #23813

steveklabnik · 2015-03-28T19:43:14Z

Fixes #19733

rust-highfive · 2015-03-28T19:43:25Z

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

Manishearth · 2015-03-29T09:23:19Z

@bors: r+ rollup

bors · 2015-03-29T09:23:20Z

📌 Commit 8a015e5 has been approved by Manishearth

huonw · 2015-03-29T11:23:52Z

@bors r-

@luqmana noted on IRC that the statement about & isn't quite true:

[18:01:26] <Luqman> steveklabnik: for https://github.com/rust-lang/rust/pull/23813, not all &T are marked noalias just those for which T contains no UnsafeCell<U>

steveklabnik · 2015-03-29T20:52:27Z

@huonw @luqmana updated, r?

huonw · 2015-03-30T01:42:14Z

src/doc/reference.md

@@ -1237,6 +1237,9 @@ the guarantee that these issues are never caused by safe code.
 * Breaking the [pointer aliasing
  rules](http://llvm.org/docs/LangRef.html#pointer-aliasing-rules)
  with raw pointers (a subset of the rules used by C)
+* `&mut` and `&` follow LLVM’s scoped [noalias] model, except if the `&T`


There's a point just above talking about UnsafeCell, maybe these could be merged/moved closer together?

Fixes rust-lang#19733

steveklabnik · 2015-03-30T16:36:29Z

@huonw : makes sense. I've moved that down, as I think it flows better overall.

emberian · 2015-03-30T22:43:06Z

@bors: r+ rollup

bors · 2015-03-30T22:43:07Z

📌 Commit 6c0314a has been approved by cmr

Fixes rust-lang#19733

- Successful merges: #23558, #23813, #23826, #23836, #23839, #23846, #23852, #23859, #23862, #23865, #23866, #23869, #23874 - Failed merges:

rust-highfive assigned huonw Mar 28, 2015

steveklabnik force-pushed the gh19733 branch from 8a015e5 to 7c49346 Compare March 29, 2015 20:52

huonw reviewed Mar 30, 2015
View reviewed changes

Make note of noalias in unsafe reference section

6c0314a

Fixes rust-lang#19733

steveklabnik force-pushed the gh19733 branch from 7c49346 to 6c0314a Compare March 30, 2015 16:36

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 31, 2015

Rollup merge of rust-lang#23813 - steveklabnik:gh19733, r=cmr

470996a

Fixes rust-lang#19733

Manishearth mentioned this pull request Mar 31, 2015

Rollup of 13 pull requests #23884

Merged

bors added a commit that referenced this pull request Mar 31, 2015

Auto merge of #23884 - Manishearth:rollup, r=Manishearth

b3317d6

- Successful merges: #23558, #23813, #23826, #23836, #23839, #23846, #23852, #23859, #23862, #23865, #23866, #23869, #23874 - Failed merges:

bors merged commit 6c0314a into rust-lang:master Mar 31, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make note of noalias in unsafe reference section #23813

Make note of noalias in unsafe reference section #23813

steveklabnik commented Mar 28, 2015

rust-highfive commented Mar 28, 2015

Manishearth commented Mar 29, 2015

bors commented Mar 29, 2015

huonw commented Mar 29, 2015

steveklabnik commented Mar 29, 2015

huonw Mar 30, 2015

steveklabnik commented Mar 30, 2015

emberian commented Mar 30, 2015

bors commented Mar 30, 2015

Make note of noalias in unsafe reference section #23813

Make note of noalias in unsafe reference section #23813

Conversation

steveklabnik commented Mar 28, 2015

rust-highfive commented Mar 28, 2015

Manishearth commented Mar 29, 2015

bors commented Mar 29, 2015

huonw commented Mar 29, 2015

steveklabnik commented Mar 29, 2015

huonw Mar 30, 2015

Choose a reason for hiding this comment

steveklabnik commented Mar 30, 2015

emberian commented Mar 30, 2015

bors commented Mar 30, 2015