rustdoc: prefer output from stderr on test panic #23846
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
Could this actually print both just be safe? Other than that looks good to me! (although a squashing of the commits would also be nice) |
rayglover
force-pushed
the
patch-rustdoc-stderr
branch
from
fe4bcc4
to
cef3d11
Compare
Forward output from stderr when a test executable panics/fails.
rayglover
force-pushed
the
patch-rustdoc-stderr
branch
from
cef3d11
to
5dc23be
Compare
|
Updated. I'm happy with this, although ultimately I'd prefer the handling/capturing of stdout to be somewhat more like the main test runner. |
…lexcrichton Currently if a rustdoc test panics then the fatal error message is not forwarded to the user. This change will have the test runner prefer forwarding anything on the stderr of the test process.
Currently if a rustdoc test panics then the fatal error message is not forwarded to the user. This change will have the test runner prefer forwarding anything on the stderr of the test process.