Gate unsigned unary negate #23945
Gate unsigned unary negate #23945
Conversation
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
bootstraps (and I'm running Obviously in need of a rebase too, though. |
|
(also I forgot to remove the |
|
r+ if we remove the impl |
|
Removed the @alexcrichton what is our rollup schedule? I.e. what is expected deadline for beta, has it passed? |
|
We should be able to land everything so long as it's in the queue in the next 3.5 hours (and maybe even slightly after!) |
Namely, the special case treatment for `div`/`rem` is only applicable to signed integer values. Clearly RFC 1027 would have saved us here! ;)
|
(adding to 1.0 beta milestone so that it does not get forgotten by accident. Though it may well get discarded by choice, if this local bootstrap does not get finished soon... how on earth is the compiler so slow for me ...) |
|
@alexcrichton reports that this commit alexcrichton@6fe1233 gets him through |
Conflicts: src/libcore/num/mod.rs
|
r=nikomatsakis f86318d |
|
⌛ Testing commit f86318d with merge 207bb63... |
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit f86318d with merge 9e5b5bd... |
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit f86318d with merge cccfe38... |
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit f86318d with merge 35b0653... |
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit f86318d with merge 4ae7033... |
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit f86318d with merge 299333b... |
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit f86318d with merge ce5c99a... |
|
💔 Test failed - auto-mac-64-opt |
As per rust-lang/rust#23945, Neg is no longer implemented for unsigned types. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
As per rust-lang/rust#23945, Neg is no longer implemented for unsigned types. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
As per rust-lang/rust#23945, Neg is no longer implemented for unsigned types. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
It's been gone since rust-lang#23945, before Rust 1.0. The former wrapping semantics have also been available as inherent methods for a long time now. There's no reason to keep this unused macro around.
…crum Remove the last remnant of unsigned Neg It's been gone since rust-lang#23945, before Rust 1.0. The former wrapping semantics have also been available as inherent methods for a long time now. There's no reason to keep this unused macro around.
Feature-gate unsigned unary negate.
Discussed in weekly meeting here: https://github.com/rust-lang/meeting-minutes/blob/master/weekly-meetings/2015-03-31.md#feature-gate--expr
and also in the internals thread here: http://internals.rust-lang.org/t/forbid-unsigned-integer/752
Also, one might rightfully point out that this is fallout from rust-lang/rfcs#560 , which has tracking issue #22020