Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the last remnant of unsigned Neg #71112

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Apr 14, 2020

It's been gone since #23945, before Rust 1.0. The former wrapping
semantics have also been available as inherent methods for a long time
now. There's no reason to keep this unused macro around.

It's been gone since rust-lang#23945, before Rust 1.0. The former wrapping
semantics have also been available as inherent methods for a long time
now. There's no reason to keep this unused macro around.
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 14, 2020
@Mark-Simulacrum
Copy link
Member

Looks great. Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 14, 2020

📌 Commit 9ede5b0 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 14, 2020
Rollup of 5 pull requests

Successful merges:

 - rust-lang#71112 (Remove the last remnant of unsigned Neg)
 - rust-lang#71120 (Clean up E0517 explanation)
 - rust-lang#71121 (Fix broken link in documentation for String::from_utf8)
 - rust-lang#71122 (update `FnCtxt::lookup_method` docs)
 - rust-lang#71124 (Add missing comma)

Failed merges:

r? @ghost
@bors bors merged commit 216e070 into rust-lang:master Apr 14, 2020
@cuviper cuviper deleted the unsigned-Neg branch May 30, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants