Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Remove mention of 30 minute intro #25220

Merged
merged 1 commit into from
May 13, 2015
Merged

doc: Remove mention of 30 minute intro #25220

merged 1 commit into from
May 13, 2015

Conversation

brson
Copy link
Contributor

@brson brson commented May 8, 2015

No description provided.

@rust-highfive
Copy link
Collaborator

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

The book provides a lengthy explanation of Rust, its syntax, and its
concepts. Upon completing the book, you'll be an intermediate Rust
developer, and will have a good grasp of the fundamental ideas behind
Rust.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to reduce awkward repetition: "behind Rust" -> "behind the language"

I'd go as far as removing the "you'll be an intermediate Rust developer"

I'm also wondering if "explanation of Rust" excludes Rust concepts, and I wonder if there's a need to mention that the book will also talk syntax (obvious). I'd trim things so that we'd have something like:

If you haven't seen Rust at all yet, the first thing you should read is the introduction. It'll give
you some idea of what Rust is like. The book will explain the language in much greater detail. You should have a good grasp of the fundamental ideas upon completing it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to reduce awkward repetition: "behind Rust" -> "behind the language"

👍

I'd go as far as removing the "you'll be an intermediate Rust developer"

👍

My suggested wording for that paragraph

If this is your first encounter with Rust, the first thing you should read is the introduction. It'll introduce you to the syntax, the primary motivations for creating Rust, and how to set up your own Rust development environment. The rest of the book will explain the language in much greater detail and upon completing it you should have a good grasp of the fundamental ideas behind the Rust programming language.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement, but we got to have a pause:

..much greater detail, and upon completing...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brson, what do you think? I don't feel strongly that this paragraph needs updating, but I don't mind @echochamber 's version either.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 12, 2015

📌 Commit 51a1e83 has been approved by steveklabnik

@steveklabnik
Copy link
Member

Merging this because I'm okay with not taking the nits.

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 12, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request May 12, 2015
bors added a commit that referenced this pull request May 12, 2015
@bors bors merged commit 51a1e83 into rust-lang:master May 13, 2015
@steveklabnik steveklabnik mentioned this pull request May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants