-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
book: typo fixes, wording improvements. #25334
Conversation
The text in iterators.md wasn't wrong, but it read awkwardly to my ear.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
are *lazy* and don't need to generate all of the values upfront. | ||
This code, for example, does not actually generate the numbers | ||
`1-100`, and just creates a value that represents the sequence: | ||
can be *lazy* and not generate all of the values upfront. This code, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, all iterators are lazy, but this is good future-proofing :)
@bors: r+ rollup |
📌 Commit a22b327 has been approved by |
Thanks so much! |
@@ -82,7 +82,7 @@ Let’s go over them by category: | |||
Integer types come in two varieties: signed and unsigned. To understand the | |||
difference, let’s consider a number with four bits of size. A signed, four-bit | |||
number would let you store numbers from `-8` to `+7`. Signed numbers use | |||
“two’s compliment representation”. An unsigned four bit number, since it does | |||
“two’s complement representation”. An unsigned four bit number, since it does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be changed from four bit
to four-bit
?
☔ The latest upstream changes (presumably #25340) made this pull request unmergeable. Please resolve the merge conflicts. |
No description provided.