Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

book: typo fixes, wording improvements. #25334

Merged
merged 1 commit into from
May 13, 2015
Merged

Conversation

wheals
Copy link
Contributor

@wheals wheals commented May 12, 2015

No description provided.

The text in iterators.md wasn't wrong, but it read awkwardly to my ear.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

are *lazy* and don't need to generate all of the values upfront.
This code, for example, does not actually generate the numbers
`1-100`, and just creates a value that represents the sequence:
can be *lazy* and not generate all of the values upfront. This code,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, all iterators are lazy, but this is good future-proofing :)

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 12, 2015

📌 Commit a22b327 has been approved by steveklabnik

@steveklabnik
Copy link
Member

Thanks so much!

@@ -82,7 +82,7 @@ Let’s go over them by category:
Integer types come in two varieties: signed and unsigned. To understand the
difference, let’s consider a number with four bits of size. A signed, four-bit
number would let you store numbers from `-8` to `+7`. Signed numbers use
“two’s compliment representation”. An unsigned four bit number, since it does
“two’s complement representation”. An unsigned four bit number, since it does
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be changed from four bit to four-bit?

bors added a commit that referenced this pull request May 12, 2015
@bors
Copy link
Contributor

bors commented May 13, 2015

☔ The latest upstream changes (presumably #25340) made this pull request unmergeable. Please resolve the merge conflicts.

bors added a commit that referenced this pull request May 13, 2015
@bors bors merged commit a22b327 into rust-lang:master May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants