Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Address issue of crates not being explained when introduced. #30836

Merged
merged 1 commit into from
Jan 15, 2016
Merged

doc: Address issue of crates not being explained when introduced. #30836

merged 1 commit into from
Jan 15, 2016

Conversation

flukejones
Copy link
Contributor

Ref issue 30825

This commit should suffice to add a concise introduction to the concept of crates.
My only worry, is that it is maybe too concise; but, the book seems to be written with the understanding that the new Rust user is coming from another language, and so will understand what a Library or Code Package is.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Member

@bors: r+ rollup

thank you!

@bors
Copy link
Contributor

bors commented Jan 12, 2016

📌 Commit bda8e1e has been approved by steveklabnik

@steveklabnik
Copy link
Member

@bors: r-

actually, there's a weird commit in here that doesn't do anything, would you mind rebasing this first?

@flukejones
Copy link
Contributor Author

@steveklabnik I also changed "it's" to "it is", which makes that sentence easier to read.

If you do prefer, I'll rebase and remove it. Otherwise it seems to be a good change. I'd just forgotten to comment on it

@steveklabnik
Copy link
Member

It's a good change! The merge commit is just the issue.

@flukejones
Copy link
Contributor Author

Errr... Can you point me to some info please? I've pulled latest changes and merged, then rebased, but there doesn't appear to be any change.
I'm not really sure what I'm looking for, or what you're seeing :)

@steveklabnik
Copy link
Member

It's this one:

2016-01-14-200621_402x41_scrot

and now there's a new one:

2016-01-14-200641_698x59_scrot

git rebase should eliminate these kinds of things....

* ref: Issue #30825
Small punctuation change in "Crates and Modules".
@steveklabnik
Copy link
Member

wooot! thanks for sticking with this

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jan 15, 2016

📌 Commit 52786de has been approved by steveklabnik

@flukejones
Copy link
Contributor Author

Got it! I even learnt a few new tricks 😀

Manishearth added a commit to Manishearth/rust that referenced this pull request Jan 15, 2016
Ref issue [30825](rust-lang#30825)

This commit should suffice to add a concise introduction to the concept of crates.
My only worry, is that it is maybe too concise; but, the book seems to be written with the understanding that the new Rust user is coming from another language, and so will understand what a Library or Code Package is.
bors added a commit that referenced this pull request Jan 15, 2016
@bors bors merged commit 52786de into rust-lang:master Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants