Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update blksize_t in raw to reflect libc change under openbsd #30925

Merged
merged 1 commit into from
Jan 15, 2016

Conversation

semarie
Copy link
Contributor

@semarie semarie commented Jan 15, 2016

make os::raw::tests::unix test to pass again

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+ b1d8554

@alexcrichton
Copy link
Member

@bors: rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request Jan 15, 2016
make `os::raw::tests::unix` test to pass again

r? @alexcrichton
bors added a commit that referenced this pull request Jan 15, 2016
@bors bors merged commit b1d8554 into rust-lang:master Jan 15, 2016
@semarie semarie deleted the blksize_t branch January 15, 2016 15:21
@aturon
Copy link
Member

aturon commented Jan 16, 2016

I just wanted to check in on this: we had mega problems making a similar change on Android, which was similarly considered having non-first tier support. Are we confident this won't instigate the same sort of breakage and dependency hell we saw there?

@semarie
Copy link
Contributor Author

semarie commented Jan 16, 2016

@aturon I am not sure to exactly understand the question. Some days ago, I updated OpenBSD Rust-libc based on libc-test (test suite of libc), and checking the C code. It results several code update to adjust Rust-libc with C-libc (see rust-lang/libc#110 for all changes).

blksize_t change (for OpenBSD) is part of these changes:

@alexcrichton
Copy link
Member

@aturon yes I suspect this to have far less breakage for two reasons:

  • The blksize_t type is much more rarely used than c_char
  • OpenBSD is also more rarely used right now than even Android

I suspect it won't take long to mitigate any breakage that comes up, even if it does so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants