Run compiler callbacks even when there are errors. #31250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
|
☔ The latest upstream changes (presumably #30900) made this pull request unmergeable. Please resolve the merge conflicts. |
| let result = f(); | ||
| count -= self.err_count(); | ||
| let count = self.err_count() - count; |
There was a problem hiding this comment.
Nit: can we rename these variables to
let old_count = ...;
let new_errors = ... - old_count;
|
r=me, needs rebase |
Fixes rust-lang#31207 by removing abort_if_new_errors
|
📌 Commit c0ac539 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 31, 2016
With this PR we can save-analysis on code with errors, essential foundation work for IDE support.
|
💔 Test failed - auto-mac-64-opt |
|
📌 Commit 5a35c53 has been approved by |
|
⌛ Testing commit 5a35c53 with merge 9a183da... |
|
💔 Test failed - auto-mac-64-opt |
|
📌 Commit 185a0e5 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 1, 2016
With this PR we can save-analysis on code with errors, essential foundation work for IDE support.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Apr 8, 2016
This was a regression introduced by rust-lang#31250 where the compiler deferred returning the results of compilation a little too late (after the `Stop` check was looked at). This commit alters the stop point to first try to return an erroneous `result` and only if it was successful return the sentinel `Err(0)`. Closes rust-lang#31576
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 8, 2016
This was a regression introduced by rust-lang#31250 where the compiler deferred returning the results of compilation a little too late (after the `Stop` check was looked at). This commit alters the stop point to first try to return an erroneous `result` and only if it was successful return the sentinel `Err(0)`. Closes rust-lang#31576
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Apr 11, 2016
This was a regression introduced by rust-lang#31250 where the compiler deferred returning the results of compilation a little too late (after the `Stop` check was looked at). This commit alters the stop point to first try to return an erroneous `result` and only if it was successful return the sentinel `Err(0)`. Closes rust-lang#31576
bors
added a commit
that referenced
this pull request
Apr 12, 2016
rustdoc: Fix testing no_run code blocks This was a regression introduced by #31250 where the compiler deferred returning the results of compilation a little too late (after the `Stop` check was looked at). This commit alters the stop point to first try to return an erroneous `result` and only if it was successful return the sentinel `Err(0)`. Closes #31576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we can save-analysis on code with errors, essential foundation work for IDE support.