rustdoc: Fix testing no_run code blocks #32811

alexcrichton · 2016-04-07T23:53:41Z

This was a regression introduced by #31250 where the compiler deferred returning
the results of compilation a little too late (after the Stop check was looked
at). This commit alters the stop point to first try to return an erroneous
result and only if it was successful return the sentinel Err(0).

Closes #31576

alexcrichton · 2016-04-07T23:53:58Z

This is small enough that we may be able to sneak it into beta as well, preventing the regression altogether!

alexcrichton · 2016-04-07T23:56:34Z

r? @nikomatsakis

nikomatsakis · 2016-04-08T00:00:07Z

makes sense to me... but ideally @nrc would give his take

alexcrichton · 2016-04-08T00:02:03Z

Looks like I had to also ignore a test due to #32445 as it crashes rustdoc now

nrc · 2016-04-08T00:02:26Z

@bors: r+

bors · 2016-04-08T00:02:27Z

📌 Commit b8526d7 has been approved by nrc

This was a regression introduced by rust-lang#31250 where the compiler deferred returning the results of compilation a little too late (after the `Stop` check was looked at). This commit alters the stop point to first try to return an erroneous `result` and only if it was successful return the sentinel `Err(0)`. Closes rust-lang#31576

bors · 2016-04-10T12:22:43Z

⌛ Testing commit b8526d7 with merge 40a1a29...

bors · 2016-04-10T12:29:47Z

⛄ The build was interrupted to prioritize another pull request.

bors · 2016-04-10T12:29:49Z

⌛ Testing commit b8526d7 with merge 2467295...

Manishearth · 2016-04-10T12:30:01Z

@bors r-

failures:

---- [pretty] pretty/coerce-expect-unsized.rs stdout ----

error: pretty-printed source (expanded) does not typecheck
status: exit code: 101
command: i686-unknown-linux-gnu/stage2/bin/rustc - -Zno-trans --target=i686-unknown-linux-gnu -L i686-unknown-linux-gnu/test/run-pass/ -L i686-unknown-linux-gnu/test/run-pass/coerce-expect-unsized.stage2-i686-unknown-linux-gnu.pretty.libaux --cfg rtopt -C rpath -O -L i686-unknown-linux-gnu/rt
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
<anon>:74:73: 74:100 error: use of unstable library feature 'fmt_internals': internal to format_args! (see issue #0)
<anon>:74                                                                        [::std::fmt::ArgumentV1::new(__arg0,
                                                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:74:73: 74:100 help: add #![feature(fmt_internals)] to the crate attributes to enable
<anon>:63:37: 63:66 error: use of unstable library feature 'fmt_internals': internal to format_args! (see issue #0)
<anon>:63                  ::std::fmt::format(::std::fmt::Arguments::new_v1({
                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:63:37: 63:66 help: add #![feature(fmt_internals)] to the crate attributes to enable
<anon>:18:5: 18:25 warning: unused import, #[warn(unused_imports)] on by default
<anon>:18 use std::prelude::v1::*;
              ^~~~~~~~~~~~~~~~~~~~
<anon>:15:10: 15:26 warning: lint unknown_features has been renamed to unused_features, #[warn(renamed_and_removed_lints)] on by default
<anon>:15 #![allow(unknown_features)]
                   ^~~~~~~~~~~~~~~~
error: aborting due to 2 previous errors

------------------------------------------

thread '[pretty] pretty/coerce-expect-unsized.rs' panicked at 'explicit panic', /buildslave/rust-buildbot/slave/auto-linux-32-opt/build/src/compiletest/runtest.rs:1679
note: Run with `RUST_BACKTRACE=1` for a backtrace.

---- [pretty] pretty/deriving-via-extension-hash-enum.rs stdout ----

error: pretty-printed source (expanded) does not typecheck
status: exit code: 101
command: i686-unknown-linux-gnu/stage2/bin/rustc - -Zno-trans --target=i686-unknown-linux-gnu -L i686-unknown-linux-gnu/test/run-pass/ -L i686-unknown-linux-gnu/test/run-pass/deriving-via-extension-hash-enum.stage2-i686-unknown-linux-gnu.pretty.libaux --cfg rtopt -C rpath -O -L i686-unknown-linux-gnu/rt
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
<anon>:27:46: 27:83 error: use of unstable library feature 'core_intrinsics': intrinsics are unlikely to ever be stabilized, instead they should be used through stabilized interfaces in the rest of the standard library (see issue #0)
<anon>:27                                              ::std::intrinsics::discriminant_value(self)
                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:27:46: 27:83 help: add #![feature(core_intrinsics)] to the crate attributes to enable
<anon>:34:46: 34:83 error: use of unstable library feature 'core_intrinsics': intrinsics are unlikely to ever be stabilized, instead they should be used through stabilized interfaces in the rest of the standard library (see issue #0)
<anon>:34                                              ::std::intrinsics::discriminant_value(self)
                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:34:46: 34:83 help: add #![feature(core_intrinsics)] to the crate attributes to enable
<anon>:51:46: 51:83 error: use of unstable library feature 'core_intrinsics': intrinsics are unlikely to ever be stabilized, instead they should be used through stabilized interfaces in the rest of the standard library (see issue #0)
<anon>:51                                              ::std::intrinsics::discriminant_value(self)
                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:51:46: 51:83 help: add #![feature(core_intrinsics)] to the crate attributes to enable
<anon>:56:46: 56:83 error: use of unstable library feature 'core_intrinsics': intrinsics are unlikely to ever be stabilized, instead they should be used through stabilized interfaces in the rest of the standard library (see issue #0)
<anon>:56                                              ::std::intrinsics::discriminant_value(self)
                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:56:46: 56:83 help: add #![feature(core_intrinsics)] to the crate attributes to enable
<anon>:61:46: 61:83 error: use of unstable library feature 'core_intrinsics': intrinsics are unlikely to ever be stabilized, instead they should be used through stabilized interfaces in the rest of the standard library (see issue #0)
<anon>:61                                              ::std::intrinsics::discriminant_value(self)
                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:61:46: 61:83 help: add #![feature(core_intrinsics)] to the crate attributes to enable
<anon>:66:46: 66:83 error: use of unstable library feature 'core_intrinsics': intrinsics are unlikely to ever be stabilized, instead they should be used through stabilized interfaces in the rest of the standard library (see issue #0)
<anon>:66                                              ::std::intrinsics::discriminant_value(self)
                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:66:46: 66:83 help: add #![feature(core_intrinsics)] to the crate attributes to enable
<anon>:4:5: 4:25 warning: unused import, #[warn(unused_imports)] on by default
<anon>:4 use std::prelude::v1::*;
             ^~~~~~~~~~~~~~~~~~~~
<anon>:19:1: 19:49 warning: enum is never used: `Foo`, #[warn(dead_code)] on by default
<anon>:19 enum Foo { Bar(isize, char), Baz(char, isize), }
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:20:1: 20:25 warning: unused attribute, #[warn(unused_attributes)] on by default
<anon>:20 #[automatically_derived]
          ^~~~~~~~~~~~~~~~~~~~~~~~
<anon>:43:1: 43:23 warning: enum is never used: `A`, #[warn(dead_code)] on by default
<anon>:43 enum A { B, C, D, E, }
          ^~~~~~~~~~~~~~~~~~~~~~
<anon>:44:1: 44:25 warning: unused attribute, #[warn(unused_attributes)] on by default
<anon>:44 #[automatically_derived]
          ^~~~~~~~~~~~~~~~~~~~~~~~
error: aborting due to 6 previous errors

------------------------------------------

thread '[pretty] pretty/deriving-via-extension-hash-enum.rs' panicked at 'explicit panic', /buildslave/rust-buildbot/slave/auto-linux-32-opt/build/src/compiletest/runtest.rs:1679

---- [pretty] pretty/foreign-dupe.rs stdout ----

error: pretty-printed source (expanded) does not typecheck
status: exit code: 101
command: i686-unknown-linux-gnu/stage2/bin/rustc - -Zno-trans --target=i686-unknown-linux-gnu -L i686-unknown-linux-gnu/test/run-pass/ -L i686-unknown-linux-gnu/test/run-pass/foreign-dupe.stage2-i686-unknown-linux-gnu.pretty.libaux --cfg rtopt -C rpath -O -L i686-unknown-linux-gnu/rt
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------
<anon>:79:93: 79:120 error: use of unstable library feature 'fmt_internals': internal to format_args! (see issue #0)
<anon>:79                                                                                            [::std::fmt::ArgumentV1::new(__arg0,
                                                                                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:79:93: 79:120 help: add #![feature(fmt_internals)] to the crate attributes to enable
<anon>:81:93: 81:120 error: use of unstable library feature 'fmt_internals': internal to format_args! (see issue #0)
<anon>:81                                                                                             ::std::fmt::ArgumentV1::new(__arg1,
                                                                                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:81:93: 81:120 help: add #![feature(fmt_internals)] to the crate attributes to enable
<anon>:64:57: 64:86 error: use of unstable library feature 'fmt_internals': internal to format_args! (see issue #0)
<anon>:64                             ::std::rt::begin_unwind_fmt(::std::fmt::Arguments::new_v1({
                                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:64:57: 64:86 help: add #![feature(fmt_internals)] to the crate attributes to enable
<anon>:64:29: 64:56 error: use of unstable library feature 'libstd_sys_internals': used by the panic! macro (see issue #0)
<anon>:64                             ::std::rt::begin_unwind_fmt(::std::fmt::Arguments::new_v1({
                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:64:29: 64:56 help: add #![feature(libstd_sys_internals)] to the crate attributes to enable
<anon>:117:93: 117:120 error: use of unstable library feature 'fmt_internals': internal to format_args! (see issue #0)
<anon>:117                                                                                            [::std::fmt::ArgumentV1::new(__arg0,
                                                                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:117:93: 117:120 help: add #![feature(fmt_internals)] to the crate attributes to enable
<anon>:119:93: 119:120 error: use of unstable library feature 'fmt_internals': internal to format_args! (see issue #0)
<anon>:119                                                                                             ::std::fmt::ArgumentV1::new(__arg1,
                                                                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:119:93: 119:120 help: add #![feature(fmt_internals)] to the crate attributes to enable
<anon>:102:57: 102:86 error: use of unstable library feature 'fmt_internals': internal to format_args! (see issue #0)
<anon>:102                             ::std::rt::begin_unwind_fmt(::std::fmt::Arguments::new_v1({
                                                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:102:57: 102:86 help: add #![feature(fmt_internals)] to the crate attributes to enable
<anon>:102:29: 102:56 error: use of unstable library feature 'libstd_sys_internals': used by the panic! macro (see issue #0)
<anon>:102                             ::std::rt::begin_unwind_fmt(::std::fmt::Arguments::new_v1({
                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
<anon>:102:29: 102:56 help: add #![feature(libstd_sys_internals)] to the crate attributes to enable
<anon>:19:5: 19:25 warning: unused import, #[warn(unused_imports)] on by default
<anon>:19 use std::prelude::v1::*;
              ^~~~~~~~~~~~~~~~~~~~
<anon>:25:9: 25:29 warning: unused import, #[warn(unused_imports)] on by default
<anon>:25     use std::prelude::v1::*;
                  ^~~~~~~~~~~~~~~~~~~~
<anon>:36:9: 36:29 warning: unused import, #[warn(unused_imports)] on by default
<anon>:36     use std::prelude::v1::*;
                  ^~~~~~~~~~~~~~~~~~~~
<anon>:46:9: 46:29 warning: unused import, #[warn(unused_imports)] on by default
<anon>:46     use std::prelude::v1::*;
                  ^~~~~~~~~~~~~~~~~~~~
error: aborting due to 8 previous errors

------------------------------------------

thread '[pretty] pretty/foreign-dupe.rs' panicked at 'explicit panic', /buildslave/rust-buildbot/slave/auto-linux-32-opt/build/src/compiletest/runtest.rs:1679


failures:
    [pretty] pretty/coerce-expect-unsized.rs
    [pretty] pretty/deriving-via-extension-hash-enum.rs
    [pretty] pretty/foreign-dupe.rs

Manishearth · 2016-04-10T12:52:01Z

@bors r- force clean

Manishearth · 2016-04-10T14:29:16Z

@bors clean

Manishearth · 2016-04-10T19:41:24Z

homu seems really confused about this PR :/

Manishearth · 2016-04-10T19:41:37Z

@bors clean force

Manishearth · 2016-04-10T19:52:08Z

@bors r=nrc

hm, that failure wasn't due to this PR, though I could swear I saw it in the travis results. not sure what happened here.

bors · 2016-04-10T19:52:08Z

📌 Commit b8526d7 has been approved by nrc

Manishearth · 2016-04-10T19:52:24Z

@bors clean retry

bors · 2016-04-10T22:01:57Z

⌛ Testing commit b8526d7 with merge 43220a7...

bors · 2016-04-10T23:36:27Z

💔 Test failed - auto-win-msvc-32-opt

alexcrichton · 2016-04-11T01:18:21Z

@bors: retry

On Sun, Apr 10, 2016 at 4:36 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-msvc-32-opt
http://buildbot.rust-lang.org/builders/auto-win-msvc-32-opt/builds/2932

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#32811 (comment)

bors · 2016-04-11T05:42:45Z

⌛ Testing commit b8526d7 with merge 0ec0071...

bors · 2016-04-11T07:32:39Z

💔 Test failed - auto-linux-musl-64-opt

This was a regression introduced by rust-lang#31250 where the compiler deferred returning the results of compilation a little too late (after the `Stop` check was looked at). This commit alters the stop point to first try to return an erroneous `result` and only if it was successful return the sentinel `Err(0)`. Closes rust-lang#31576

alexcrichton · 2016-04-11T16:27:08Z

@bors: r=nrc

bors · 2016-04-11T16:27:08Z

📌 Commit 42bcb40 has been approved by nrc

bors · 2016-04-12T14:14:55Z

⌛ Testing commit 42bcb40 with merge 9330006...

rustdoc: Fix testing no_run code blocks This was a regression introduced by #31250 where the compiler deferred returning the results of compilation a little too late (after the `Stop` check was looked at). This commit alters the stop point to first try to return an erroneous `result` and only if it was successful return the sentinel `Err(0)`. Closes #31576

bors · 2016-04-12T17:12:53Z

rust-highfive assigned nikomatsakis Apr 7, 2016

alexcrichton force-pushed the check-lints branch from 73090bf to b8526d7 Compare April 8, 2016 00:01

Manishearth mentioned this pull request Apr 9, 2016

Rollup of 10 pull requests #32860

Closed

Manishearth closed this Apr 10, 2016

Manishearth reopened this Apr 10, 2016

Manishearth closed this Apr 10, 2016

Manishearth reopened this Apr 10, 2016

Manishearth closed this Apr 10, 2016

Manishearth reopened this Apr 10, 2016

Manishearth closed this Apr 10, 2016

Manishearth reopened this Apr 10, 2016

alexcrichton force-pushed the check-lints branch from b8526d7 to 42bcb40 Compare April 11, 2016 16:27

bors merged commit 42bcb40 into rust-lang:master Apr 12, 2016

alexcrichton deleted the check-lints branch April 13, 2016 23:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rustdoc: Fix testing no_run code blocks #32811

rustdoc: Fix testing no_run code blocks #32811

alexcrichton commented Apr 7, 2016

alexcrichton commented Apr 7, 2016

alexcrichton commented Apr 7, 2016

nikomatsakis commented Apr 8, 2016

alexcrichton commented Apr 8, 2016

nrc commented Apr 8, 2016

bors commented Apr 8, 2016

bors commented Apr 10, 2016

bors commented Apr 10, 2016

bors commented Apr 10, 2016

Manishearth commented Apr 10, 2016

Manishearth commented Apr 10, 2016

Manishearth commented Apr 10, 2016

Manishearth commented Apr 10, 2016

Manishearth commented Apr 10, 2016

Manishearth commented Apr 10, 2016

bors commented Apr 10, 2016

Manishearth commented Apr 10, 2016

bors commented Apr 10, 2016

bors commented Apr 10, 2016

alexcrichton commented Apr 11, 2016

bors commented Apr 11, 2016

bors commented Apr 11, 2016

alexcrichton commented Apr 11, 2016

bors commented Apr 11, 2016

bors commented Apr 12, 2016

bors commented Apr 12, 2016

rustdoc: Fix testing no_run code blocks #32811

rustdoc: Fix testing no_run code blocks #32811

Conversation

alexcrichton commented Apr 7, 2016

alexcrichton commented Apr 7, 2016

alexcrichton commented Apr 7, 2016

nikomatsakis commented Apr 8, 2016

alexcrichton commented Apr 8, 2016

nrc commented Apr 8, 2016

bors commented Apr 8, 2016

bors commented Apr 10, 2016

bors commented Apr 10, 2016

bors commented Apr 10, 2016

Manishearth commented Apr 10, 2016

Manishearth commented Apr 10, 2016

Manishearth commented Apr 10, 2016

Manishearth commented Apr 10, 2016

Manishearth commented Apr 10, 2016

Manishearth commented Apr 10, 2016

bors commented Apr 10, 2016

Manishearth commented Apr 10, 2016

bors commented Apr 10, 2016

bors commented Apr 10, 2016

alexcrichton commented Apr 11, 2016

bors commented Apr 11, 2016

bors commented Apr 11, 2016

alexcrichton commented Apr 11, 2016

bors commented Apr 11, 2016

bors commented Apr 12, 2016

bors commented Apr 12, 2016