Rollup of 10 pull requests #32860
Closed
Rollup of 10 pull requests #32860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
Apr 9, 2016
Manishearth
commented
- Successful merges: Add doc examples for Iter and IterMut #32768, add regression test for #32505 #32802, rustdoc: Fix testing no_run code blocks #32811, Adds data race in docs #32815, Blacklist fn item types from being used with variadic functions. #32816, Read "is-like-msvc" target option from JSON #32823, resolve: import resolution diagnostics #32849, resolve: Add regression tests for fixed issues #32850, Don't read past limit for in BufRead instance of Take #32855, librustc_back: fix incorrect comment about RUST_TARGET_PATH #32856
- Failed merges:
…abnik Add doc examples for Iter and IterMut Fixes rust-lang#29374. r? @steveklabnik
|
@bors r+ p=20 |
|
📌 Commit a7246af has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit a7246af with merge ddb6667... |
|
💔 Test failed - auto-linux-32-opt |
|
@bors r+ force |
|
📌 Commit 891e2ff has been approved by |
|
@bors force |
1 similar comment
|
@bors force |
|
⌛ Testing commit 891e2ff with merge 5c754a6... |
|
💔 Test failed - auto-win-msvc-32-opt |
|
@bors r+ force |
|
📌 Commit 220744b has been approved by |
|
@bors force |
|
⌛ Testing commit 220744b with merge 0f62b61... |
|
💔 Test failed - auto-win-msvc-32-opt |
add regression test for rust-lang#32505 Fixes rust-lang#32505 r? @eddyb
Adds data race in docs Thanks for all your hard work! This is in reference to rust-lang#32733 I know there has been a discussion about this on PR rust-lang#32538 so you are welcome to keep the code as is or merge my documentation in. Let me know what you think and/or if you want me to modify anything!
Blacklist fn item types from being used with variadic functions. Fixes rust-lang#32201 by adding fn types to the variadic blacklist which currently includes `bool`, `i8`, `u8`, `i16`, `u16` and `f32`.
…tics, r=eddyb resolve: import resolution diagnostics This improves the diagnostics for failing import resolutions (fixes rust-lang#32833). r? @eddyb
resolve: Add regression tests for fixed issues This adds regression tests for fixed issues in resolve (closes rust-lang#22146, closes rust-lang#24883, closes rust-lang#26930). r? @eddyb
…chton Don't read past limit for in BufRead instance of Take Similar to `Read::read`, `BufRead::fill_buf` impl of `Take` should not call `inner.fill_buf` if the limit is already reached.
|
@bors r+ |
|
📌 Commit db8f4d6 has been approved by |
|
⌛ Testing commit db8f4d6 with merge 43a6e22... |
|
💔 Test failed - auto-win-msvc-32-opt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.