Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read "is-like-msvc" target option from JSON #32823

Merged
merged 1 commit into from
Apr 12, 2016
Merged

Read "is-like-msvc" target option from JSON #32823

merged 1 commit into from
Apr 12, 2016

Conversation

pravic
Copy link
Contributor

@pravic pravic commented Apr 8, 2016

This is in reference to #32818.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jroesch (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@pravic
Copy link
Contributor Author

pravic commented Apr 8, 2016

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned jroesch Apr 8, 2016
@alexcrichton
Copy link
Member

@bors: r+ a6e86ec rollup

@cardoe cardoe mentioned this pull request Apr 9, 2016
Closed
@Manishearth Manishearth mentioned this pull request Apr 9, 2016
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 11, 2016
@steveklabnik
Rollup merge of rust-lang#32823 - pravic:target-json, r=alexcrichton
9989a95 
Read "is-like-msvc" target option from JSON

This is in reference to rust-lang#32818.
@steveklabnik steveklabnik mentioned this pull request Apr 11, 2016
Merged
bors added a commit that referenced this pull request Apr 11, 2016
@bors
Auto merge of #32882 - steveklabnik:rollup, r=steveklabnik
c0221c8 
Rollup of 9 pull requests

- Successful merges: #32768, #32802, #32815, #32823, #32849, #32854, #32862, #32870, #32873
- Failed merges:
@bors bors merged commit a6e86ec into rust-lang:master Apr 12, 2016
@pravic pravic mentioned this pull request Apr 14, 2016
Closed
@cardoe cardoe mentioned this pull request Apr 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pravic @rust-highfive @alexcrichton @jroesch @bors