Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't read past limit for in BufRead instance of Take #32855

Merged
merged 1 commit into from
Apr 15, 2016

Conversation

troplin
Copy link
Contributor

@troplin troplin commented Apr 9, 2016

Similar to Read::read, BufRead::fill_buf impl of Take should not call inner.fill_buf if the limit is already reached.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+ a3329f5

Thanks!

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 10, 2016
…chton

Don't read past limit for in BufRead instance of Take

Similar to `Read::read`, `BufRead::fill_buf` impl of `Take` should not call `inner.fill_buf` if the limit is already reached.
@alexcrichton
Copy link
Member

@bors: rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 14, 2016
…chton

Don't read past limit for in BufRead instance of Take

Similar to `Read::read`, `BufRead::fill_buf` impl of `Take` should not call `inner.fill_buf` if the limit is already reached.
@bors
Copy link
Contributor

bors commented Apr 14, 2016

⌛ Testing commit a3329f5 with merge bda39d0...

@bors
Copy link
Contributor

bors commented Apr 14, 2016

💔 Test failed - auto-win-msvc-64-cargotest

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Apr 14, 2016 at 12:36 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-msvc-64-cargotest
http://buildbot.rust-lang.org/builders/auto-win-msvc-64-cargotest/builds/73


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#32855 (comment)

bors added a commit that referenced this pull request Apr 14, 2016
@bors bors merged commit a3329f5 into rust-lang:master Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants