Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rustbuild option to use Ninja for LLVM build #32865

Merged
merged 2 commits into from
Apr 15, 2016
Merged

Add rustbuild option to use Ninja for LLVM build #32865

merged 2 commits into from
Apr 15, 2016

Conversation

caipre
Copy link
Contributor

@caipre caipre commented Apr 10, 2016

This change adds support for a ninja option in the [llvm] section of rustbuild's config.toml. When true, the option enables use of the Ninja build tool. Note that this change does not add support for Ninja to the old makefile based build system.

Closes #32809

r? @alexcrichton

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+ 7dd0beb

Nice!

@alexcrichton
Copy link
Member

@bors: rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 14, 2016
@steveklabnik
Rollup merge of rust-lang#32865 - caipre:llvm-ninja, r=alexcrichton
d1f1f38 
Add rustbuild option to use Ninja for LLVM build

This change adds support for a `ninja` option in the `[llvm]` section of rustbuild's `config.toml`. When `true`, the option enables use of the Ninja build tool. Note that this change does not add support for Ninja to the old makefile based build system.

Closes rust-lang#32809

r? @alexcrichton
@steveklabnik steveklabnik mentioned this pull request Apr 14, 2016
Merged
@bors
Copy link
Contributor

bors commented Apr 14, 2016

⌛ Testing commit 7dd0beb with merge e5803b1...

@bors
Copy link
Contributor

bors commented Apr 14, 2016

💔 Test failed - auto-win-gnu-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Apr 14, 2016 at 12:40 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-gnu-32-opt
http://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/3797

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#32865 (comment)

bors added a commit that referenced this pull request Apr 14, 2016
@bors
Auto merge of #32960 - steveklabnik:rollup, r=steveklabnik
2174bd9 
Rollup of 15 pull requests

- Successful merges: #32646, #32855, #32856, #32865, #32868, #32869, #32876, #32884, #32885, #32893, #32894, #32932, #32937, #32940, #32941
- Failed merges: #32912
@bors bors merged commit 7dd0beb into rust-lang:master Apr 15, 2016
@caipre caipre deleted the llvm-ninja branch April 15, 2016 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caipre @rust-highfive @alexcrichton @bors